Merge 2fa2a9480a into 506c11ba43

* Wayland: Ignore key repeat events when no window has keyboard focus

CONTRIBUTORS.md

@@ -229,7 +229,7 @@ video tutorials.
  - Brandon Schaefer
  - Sebastian Schuberth
  - Scr3amer
- - Jan Schuerkamp
+ - Jan Schürkamp
  - Christian Sdunek
  - Matt Sealey
  - Steve Sexton

README.md

@@ -129,6 +129,7 @@ information on what to include when reporting a bug.
  - [Wayland] Bugfix: The fractional scaling related objects were not destroyed
  - [Wayland] Bugfix: `glfwInit` would segfault on compositor with no seat (#2517)
  - [Wayland] Bugfix: A drag entering a non-GLFW surface could cause a segfault
+ - [Wayland] Bugfix: Ignore key repeat events when no window has keyboard focus (#2727)
  - [X11] Bugfix: Running without a WM could trigger an assert (#2593,#2601,#2631)
  - [Null] Added Vulkan 'window' surface creation via `VK_EXT_headless_surface`
  - [Null] Added EGL context creation on Mesa via `EGL_MESA_platform_surfaceless`

deps/nuklear.h

@@ -423,6 +423,11 @@ NK_STATIC_ASSERT(sizeof(nk_rune) >= 4);
 NK_STATIC_ASSERT(sizeof(nk_size) >= sizeof(void*));
 NK_STATIC_ASSERT(sizeof(nk_ptr) >= sizeof(void*));
 
+#if defined(_MSC_VER)
+/* disable `operands are different enum types` warning on MSVC */ 
+#pragma warning( disable: 5287 )
+#endif
+
 /* ============================================================================
  *
  *                                  API

src/wl_window.c

@@ -1267,17 +1267,21 @@ static void handleEvents(double* timeout)
 
             if (read(_glfw.wl.keyRepeatTimerfd, &repeats, sizeof(repeats)) == 8)
             {
-                for (uint64_t i = 0; i < repeats; i++)
+                if(_glfw.wl.keyboardFocus)
                 {
-                    _glfwInputKey(_glfw.wl.keyboardFocus,
+                    for (uint64_t i = 0; i < repeats; i++)
-                                  translateKey(_glfw.wl.keyRepeatScancode),
+                    {
-                                  _glfw.wl.keyRepeatScancode,
+                        _glfwInputKey(_glfw.wl.keyboardFocus,
-                                  GLFW_PRESS,
+                                      translateKey(_glfw.wl.keyRepeatScancode),
-                                  _glfw.wl.xkb.modifiers);
+                                      _glfw.wl.keyRepeatScancode,
-                    inputText(_glfw.wl.keyboardFocus, _glfw.wl.keyRepeatScancode);
+                                      GLFW_PRESS,
+                                      _glfw.wl.xkb.modifiers);
+                        inputText(_glfw.wl.keyboardFocus, _glfw.wl.keyRepeatScancode);
+                    }
+
+                    event = GLFW_TRUE;
                 }
 
-                event = GLFW_TRUE;
             }
         }
 

tests/tearing.c

@@ -36,6 +36,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <math.h>
+#include <limits.h>
 
 #include "linmath.h"
 
@@ -103,7 +104,7 @@ static void key_callback(GLFWwindow* window, int key, int scancode, int action,
     {
         case GLFW_KEY_UP:
         {
-            if (swap_interval + 1 > swap_interval)
+            if (swap_interval <= INT_MAX - 1)
                 set_swap_interval(window, swap_interval + 1);
             break;
         }
@@ -112,12 +113,12 @@ static void key_callback(GLFWwindow* window, int key, int scancode, int action,
         {
             if (swap_tear)
             {
-                if (swap_interval - 1 < swap_interval)
+                if (swap_interval >= INT_MIN + 1)
                     set_swap_interval(window, swap_interval - 1);
             }
             else
             {
-                if (swap_interval - 1 >= 0)
+                if (swap_interval >= 1)
                     set_swap_interval(window, swap_interval - 1);
             }
             break;