Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2024-11-14 09:34:46 +00:00
Code Issues Packages Projects Releases Wiki Activity
553054b26b
pybind11/tests/test_class_sh_trampoline_shared_from_this.py

79 lines
2.6 KiB
Python
Raw Normal View History

First fully successful attempt to make `shared_from_this` and trampolines play nicely. Now also passes the open_spiel iterated_prisoners_dilemma_test ASAN clean, in addition to all pybind11 and PyCLIF unit tests. The problem was that calling `std::shared_ptr<void>::reset()` with a `void` pointer cannot possibly update the `shared_from_this` `weak_ptr`. The solution is to store a `shd_ptr_reset` function pointer in `guarded_deleter` (similar in idea to the stored function pointer for calling `delete`). This commit still includes all debugging code, i.e. is "dirty". The code will be cleaned up after the GitHub CI is fully successful.
2021-06-20 01:13:27 +00:00
# -*- coding: utf-8 -*-
import pybind11_tests.class_sh_trampoline_shared_from_this as m
Adding tests involving stashing `shared_ptr`s. WIP.
2021-06-20 15:35:51 +00:00
import gc
import weakref
First fully successful attempt to make `shared_from_this` and trampolines play nicely. Now also passes the open_spiel iterated_prisoners_dilemma_test ASAN clean, in addition to all pybind11 and PyCLIF unit tests. The problem was that calling `std::shared_ptr<void>::reset()` with a `void` pointer cannot possibly update the `shared_from_this` `weak_ptr`. The solution is to store a `shd_ptr_reset` function pointer in `guarded_deleter` (similar in idea to the stored function pointer for calling `delete`). This commit still includes all debugging code, i.e. is "dirty". The code will be cleaned up after the GitHub CI is fully successful.
2021-06-20 01:13:27 +00:00
Adding tests involving stashing `shared_ptr`s. WIP.
2021-06-20 15:35:51 +00:00
class PySft(m.Sft):
First fully successful attempt to make `shared_from_this` and trampolines play nicely. Now also passes the open_spiel iterated_prisoners_dilemma_test ASAN clean, in addition to all pybind11 and PyCLIF unit tests. The problem was that calling `std::shared_ptr<void>::reset()` with a `void` pointer cannot possibly update the `shared_from_this` `weak_ptr`. The solution is to store a `shd_ptr_reset` function pointer in `guarded_deleter` (similar in idea to the stored function pointer for calling `delete`). This commit still includes all debugging code, i.e. is "dirty". The code will be cleaned up after the GitHub CI is fully successful.
2021-06-20 01:13:27 +00:00
pass
def test_pass_shared_ptr():
Adding tests involving stashing `shared_ptr`s. WIP.
2021-06-20 15:35:51 +00:00
obj = PySft("PySft")
assert obj.history == "PySft"
assert obj.use_count() == 2
m.pass_shared_ptr(obj)
assert obj.history == "PySft_PassSharedPtr"
assert obj.use_count() == 2
First fully successful attempt to make `shared_from_this` and trampolines play nicely. Now also passes the open_spiel iterated_prisoners_dilemma_test ASAN clean, in addition to all pybind11 and PyCLIF unit tests. The problem was that calling `std::shared_ptr<void>::reset()` with a `void` pointer cannot possibly update the `shared_from_this` `weak_ptr`. The solution is to store a `shd_ptr_reset` function pointer in `guarded_deleter` (similar in idea to the stored function pointer for calling `delete`). This commit still includes all debugging code, i.e. is "dirty". The code will be cleaned up after the GitHub CI is fully successful.
2021-06-20 01:13:27 +00:00
m.pass_shared_ptr(obj)
Adding tests involving stashing `shared_ptr`s. WIP.
2021-06-20 15:35:51 +00:00
assert obj.history == "PySft_PassSharedPtr_PassSharedPtr"
assert obj.use_count() == 2
def test_pass_shared_ptr_while_stashed():
obj = PySft("PySft")
obj_wr = weakref.ref(obj)
stash1 = m.SftSharedPtrStash(1)
stash1.Add(obj)
assert obj.history == "PySft_Stash1Add"
assert obj.use_count() == 2
First fully successful attempt to make `shared_from_this` and trampolines play nicely. Now also passes the open_spiel iterated_prisoners_dilemma_test ASAN clean, in addition to all pybind11 and PyCLIF unit tests. The problem was that calling `std::shared_ptr<void>::reset()` with a `void` pointer cannot possibly update the `shared_from_this` `weak_ptr`. The solution is to store a `shd_ptr_reset` function pointer in `guarded_deleter` (similar in idea to the stored function pointer for calling `delete`). This commit still includes all debugging code, i.e. is "dirty". The code will be cleaned up after the GitHub CI is fully successful.
2021-06-20 01:13:27 +00:00
m.pass_shared_ptr(obj)
Adding tests involving stashing `shared_ptr`s. WIP.
2021-06-20 15:35:51 +00:00
assert obj.history == "PySft_Stash1Add_PassSharedPtr"
assert obj.use_count() == 2
stash2 = m.SftSharedPtrStash(2)
stash2.Add(obj)
assert obj.history == "PySft_Stash1Add_PassSharedPtr_Stash2Add"
assert obj.use_count() == 2
assert stash2.history(0) == "PySft_Stash1Add_PassSharedPtr_Stash2Add"
assert stash2.use_count(0) == 1 # TODO: this is not great.
stash2.Add(obj)
assert obj.history == "PySft_Stash1Add_PassSharedPtr_Stash2Add_Stash2Add"
assert obj.use_count() == 2
assert stash1.use_count(0) == 1
assert stash1.history(0) == "PySft_Stash1Add_PassSharedPtr_Stash2Add_Stash2Add"
assert stash2.use_count(0) == 1
assert stash2.history(0) == "PySft_Stash1Add_PassSharedPtr_Stash2Add_Stash2Add"
assert stash2.use_count(1) == 1
assert stash2.history(1) == "PySft_Stash1Add_PassSharedPtr_Stash2Add_Stash2Add"
del obj
assert stash2.use_count(0) == 1
assert stash2.history(0) == "PySft_Stash1Add_PassSharedPtr_Stash2Add_Stash2Add"
assert stash2.use_count(1) == 1
assert stash2.history(1) == "PySft_Stash1Add_PassSharedPtr_Stash2Add_Stash2Add"
del stash2
gc.collect()
assert obj_wr() is not None
assert stash1.history(0) == "PySft_Stash1Add_PassSharedPtr_Stash2Add_Stash2Add"
del stash1
gc.collect()
assert obj_wr() is None
def test_pass_shared_ptr_while_stashed_with_shared_from_this():
obj = PySft("PySft")
obj_wr = weakref.ref(obj)
stash1 = m.SftSharedPtrStash(1)
stash1.AddSharedFromThis(obj)
assert obj.history == "PySft_Stash1AddSharedFromThis"
assert stash1.use_count(0) == 2
stash1.AddSharedFromThis(obj)
assert obj.history == "PySft_Stash1AddSharedFromThis_Stash1AddSharedFromThis"
assert stash1.use_count(0) == 3
assert stash1.use_count(1) == 3
First fully successful attempt to make `shared_from_this` and trampolines play nicely. Now also passes the open_spiel iterated_prisoners_dilemma_test ASAN clean, in addition to all pybind11 and PyCLIF unit tests. The problem was that calling `std::shared_ptr<void>::reset()` with a `void` pointer cannot possibly update the `shared_from_this` `weak_ptr`. The solution is to store a `shd_ptr_reset` function pointer in `guarded_deleter` (similar in idea to the stored function pointer for calling `delete`). This commit still includes all debugging code, i.e. is "dirty". The code will be cleaned up after the GitHub CI is fully successful.
2021-06-20 01:13:27 +00:00
del obj
Adding tests involving stashing `shared_ptr`s. WIP.
2021-06-20 15:35:51 +00:00
del stash1
gc.collect()
assert obj_wr() is None
Reference in New Issue Copy Permalink