Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2025-02-12 11:47:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace loaded_v_h.type = get_type_info(typeid(type)) with loaded_v_h.type = typeinfo in unique_ptr type_caster and remove pytest.skip() in test_class_sh_disowning_mi.py

Browse Source
This commit is contained in:
Ralf W. Grosse-Kunstleve 2024-07-10 08:18:24 -07:00
parent f855283be4
commit 127058cb16
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/pybind11/cast.h
View File

@ -1027,7 +1027,7 @@ public:
void load_value(value_and_holder &&v_h) { void load_value(value_and_holder &&v_h) {
if (typeinfo->default_holder) { if (typeinfo->default_holder) {
sh_load_helper.loaded_v_h = v_h; sh_load_helper.loaded_v_h = v_h;
sh_load_helper.loaded_v_h.type = get_type_info(typeid(type)); sh_load_helper.loaded_v_h.type = typeinfo;
value = sh_load_helper.get_void_ptr_or_nullptr(); value = sh_load_helper.get_void_ptr_or_nullptr();
return; return;
} }

3
tests/test_class_sh_disowning_mi.py
View File

@ -61,9 +61,6 @@ def test_disown_d(var_to_disown):
b = d.b() b = d.b()
c0 = d.c0() c0 = d.c0()
c1 = d.c1() c1 = d.c1()
pytest.skip(
"BAKEIN_BREAK: Root cause for crashes in test_class_sh_shared_ptr_copy_move?"
)
m.disown_b(locals()[var_to_disown]) m.disown_b(locals()[var_to_disown])
assert is_disowned(d.get) assert is_disowned(d.get)
assert is_disowned(c1.get) assert is_disowned(c1.get)