fix: Add missing spaces to error string (#4906)

* [minor] Add a missing space

Add a missing space to error message

* Add space after period, always add newline.
This commit is contained in:
Chun Yang 2023-10-26 20:40:19 -07:00 committed by GitHub
parent fa27d2fd43
commit 1e28599e41
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -305,19 +305,19 @@ private:
"https://pybind11.readthedocs.io/en/stable/advanced/" "https://pybind11.readthedocs.io/en/stable/advanced/"
"misc.html#common-sources-of-global-interpreter-lock-errors for debugging advice.\n" "misc.html#common-sources-of-global-interpreter-lock-errors for debugging advice.\n"
"If you are convinced there is no bug in your code, you can #define " "If you are convinced there is no bug in your code, you can #define "
"PYBIND11_NO_ASSERT_GIL_HELD_INCREF_DECREF" "PYBIND11_NO_ASSERT_GIL_HELD_INCREF_DECREF "
"to disable this check. In that case you have to ensure this #define is consistently " "to disable this check. In that case you have to ensure this #define is consistently "
"used for all translation units linked into a given pybind11 extension, otherwise " "used for all translation units linked into a given pybind11 extension, otherwise "
"there will be ODR violations.", "there will be ODR violations.",
function_name.c_str()); function_name.c_str());
fflush(stderr);
if (Py_TYPE(m_ptr)->tp_name != nullptr) { if (Py_TYPE(m_ptr)->tp_name != nullptr) {
fprintf(stderr, fprintf(stderr,
"The failing %s call was triggered on a %s object.\n", " The failing %s call was triggered on a %s object.",
function_name.c_str(), function_name.c_str(),
Py_TYPE(m_ptr)->tp_name); Py_TYPE(m_ptr)->tp_name);
fflush(stderr);
} }
fprintf(stderr, "\n");
fflush(stderr);
throw std::runtime_error(function_name + " PyGILState_Check() failure."); throw std::runtime_error(function_name + " PyGILState_Check() failure.");
} }
#endif #endif