From 1f8b4a7f1a1c5cc9bd6e0d63fe15540e6c458b24 Mon Sep 17 00:00:00 2001 From: Hintay Date: Fri, 20 Sep 2024 00:24:35 +0900 Subject: [PATCH] fix(cmake): `NO_EXTRAS` in `pybind11_add_module` function partially working (#5378) --- tools/pybind11NewTools.cmake | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/pybind11NewTools.cmake b/tools/pybind11NewTools.cmake index d3e938fab..8bac211e1 100644 --- a/tools/pybind11NewTools.cmake +++ b/tools/pybind11NewTools.cmake @@ -274,10 +274,6 @@ function(pybind11_add_module target_name) target_link_libraries(${target_name} PRIVATE pybind11::embed) endif() - if(MSVC) - target_link_libraries(${target_name} PRIVATE pybind11::windows_extras) - endif() - # -fvisibility=hidden is required to allow multiple modules compiled against # different pybind versions to work properly, and for some features (e.g. # py::module_local). We force it on everything inside the `pybind11`