Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2024-11-22 21:25:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: add missing moves for buffer_func and staticmethod in pybind11.h (#3969)

Browse Source 
* Use move converting ctor when making class staticmethod

* Add missing caster move in buffer func

* fix use after move

* add back move to staticmethod

* avoid shadowing with varname
This commit is contained in:
Aaron Gokaslan 2022-05-25 12:14:07 -04:00 committed by GitHub
parent 4624e8e164
commit 2d4a20c8cb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
include/pybind11/pybind11.h
View File

@ -1566,7 +1566,8 @@ public:
scope(*this), scope(*this),
sibling(getattr(*this, name_, none())), sibling(getattr(*this, name_, none())),
extra...); extra...);
attr(cf.name()) = staticmethod(cf); auto cf_name = cf.name();
attr(std::move(cf_name)) = staticmethod(std::move(cf));
return *this; return *this;
} }
@ -1620,7 +1621,7 @@ public:
if (!caster.load(obj, false)) { if (!caster.load(obj, false)) {
return nullptr; return nullptr;
} }
return new buffer_info(((capture *) ptr)->func(caster)); return new buffer_info(((capture *) ptr)->func(std::move(caster)));
}, },
ptr); ptr);
weakref(m_ptr, cpp_function([ptr](handle wr) { weakref(m_ptr, cpp_function([ptr](handle wr) {