Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2024-11-29 16:37:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adding minor comment (change to internals needed to distinguish uninitialized/disowned in error message).

Browse Source
This commit is contained in:
Ralf W. Grosse-Kunstleve 2021-01-15 16:52:09 -08:00
parent a72e5f0c8f
commit 2f8e01748b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/test_classh_wip.cpp
View File

@ -64,7 +64,8 @@ struct smart_holder_type_caster_load {
auto inst = reinterpret_cast<instance *>(src.ptr()); auto inst = reinterpret_cast<instance *>(src.ptr());
loaded_v_h = inst->get_value_and_holder(get_type_info(typeid(T))); loaded_v_h = inst->get_value_and_holder(get_type_info(typeid(T)));
if (!loaded_v_h.holder_constructed()) { if (!loaded_v_h.holder_constructed()) {
// IMPROVEABLE: Error message. // IMPROVEABLE: Error message. A change to the existing internals is
// needed to cleanly distinguish between uninitialized or disowned.
throw std::runtime_error("Missing value for wrapped C++ type:" throw std::runtime_error("Missing value for wrapped C++ type:"
" Python instance is uninitialized or was disowned."); " Python instance is uninitialized or was disowned.");
} }