Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2025-02-22 08:29:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Changes accessor::operator=() to throw error_already_set() instead of using pybind11_fail().

Browse Source 
PyObject_SetItem and PyObject_SetAttr both throws an exception on
failure so this will show the underlying exception instead of masking
it.

Fixes #303.
This commit is contained in:
Trygve Laugstøl 2016-08-01 08:45:16 +02:00
parent f38f359f96
commit 3572bc3e82
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/pybind11/pytypes.h
View File

@ -117,10 +117,10 @@ public:
void operator=(const handle &value) { void operator=(const handle &value) {
if (attr) { if (attr) {
if (PyObject_SetAttr(obj.ptr(), key.ptr(), value.ptr()) == -1) if (PyObject_SetAttr(obj.ptr(), key.ptr(), value.ptr()) == -1)
pybind11_fail("Unable to set object attribute"); throw error_already_set();
} else { } else {
if (PyObject_SetItem(obj.ptr(), key.ptr(), value.ptr()) == -1) if (PyObject_SetItem(obj.ptr(), key.ptr(), value.ptr()) == -1)
pybind11_fail("Unable to set object item"); throw error_already_set();
} }
} }