further eval() improvements

.appveyor.yml

@@ -23,7 +23,4 @@ build_script:
   - cd c:\projects\pybind11
   - cmake -G "%CMAKE_PLATFORM%" -DPYTHON_EXECUTABLE:FILEPATH=%PYTHON_DIR%/python.exe
   - set MSBuildLogger="C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll"
-  - cmake --build . --config %Configuration% -- /v:m /logger:%MSBuildLogger%
-  - set PATH=%PYTHON_DIR%;%PATH%
-  - python example/example18.py
   - cmake --build . --config %Configuration% --target check -- /v:m /logger:%MSBuildLogger%

include/pybind11/eval.h

@@ -29,7 +29,7 @@ enum eval_mode {
 };
 
 template <eval_mode mode = eval_expr>
-object eval(const std::string& str, object global = object(), object local = object()) {
+object eval(str expr, object global = object(), object local = object()) {
     if (!global) {
         global = object(PyEval_GetGlobals(), true);
         if (!global)
@@ -38,6 +38,10 @@ object eval(const std::string& str, object global = object(), object local = obj
     if (!local)
         local = global;
 
+    /* PyRun_String does not accept a PyObject / encoding specifier,
+       this seems to be the only alternative */
+    std::string buffer = "# -*- coding: utf-8 -*-\n" + (std::string) expr;
+
     int start;
     switch (mode) {
         case eval_expr:             start = Py_eval_input;   break;
@@ -46,7 +50,7 @@ object eval(const std::string& str, object global = object(), object local = obj
         default: pybind11_fail("invalid evaluation mode");
     }
 
-    object result(PyRun_String(str.c_str(), start, global.ptr(), local.ptr()), false);
+    object result(PyRun_String(buffer.c_str(), start, global.ptr(), local.ptr()), false);
 
     if (!result)
         throw error_already_set();
@@ -54,7 +58,7 @@ object eval(const std::string& str, object global = object(), object local = obj
 }
 
 template <eval_mode mode = eval_statements>
-object eval_file(const std::string& fname, object global = object(), object local = object()) {
+object eval_file(str fname, object global = object(), object local = object()) {
     if (!global) {
         global = object(PyEval_GetGlobals(), true);
         if (!global)
@@ -71,12 +75,27 @@ object eval_file(const std::string& fname, object global = object(), object loca
         default: pybind11_fail("invalid evaluation mode");
     }
 
-    FILE *f = fopen(fname.c_str(), "r");
+    int closeFile = 1;
-    if (!f)
+    std::string fname_str = (std::string) fname;
-        pybind11_fail("File \"" + fname + "\" could not be opened!");
+#if PY_VERSION_HEX >= 0x03040000
+    FILE *f = _Py_fopen_obj(fname.ptr(), "r");
+#elif PY_VERSION_HEX >= 0x03000000
+    FILE *f = _Py_fopen(fname.ptr(), "r");
+#else
+    /* No unicode support in open() :( */
+    object fobj(PyFile_FromString(fname_str.c_str(), const_cast<char*>("r")), false);
+    FILE *f = nullptr;
+    if (fobj)
+        f = PyFile_AsFile(fobj.ptr());
+    closeFile = 0;
+#endif
+    if (!f) {
+        PyErr_Clear();
+        pybind11_fail("File \"" + fname_str + "\" could not be opened!");
+    }
 
-    object result(PyRun_FileEx(f, fname.c_str(), Py_file_input, global.ptr(),
+    object result(PyRun_FileEx(f, fname_str.c_str(), start, global.ptr(),
-                               local.ptr(), 1),
+                               local.ptr(), closeFile),
                   false);
 
     if (!result)

include/pybind11/pytypes.h

@@ -343,6 +343,11 @@ public:
         if (!m_ptr) pybind11_fail("Could not allocate string object!");
     }
 
+    str(const char *c)
+        : object(PyUnicode_FromString(c), false) {
+        if (!m_ptr) pybind11_fail("Could not allocate string object!");
+    }
+
     operator std::string() const {
         object temp = *this;
         if (PyUnicode_Check(m_ptr)) {