mirror of
https://github.com/pybind/pybind11.git
synced 2024-11-22 05:05:11 +00:00
enable two new clang-tidy checks (#3988)
* enable two new clang-tidy checks * Use better loop var for char
This commit is contained in:
parent
42a41bf3e7
commit
554c045377
@ -10,6 +10,7 @@ cppcoreguidelines-pro-type-static-cast-downcast,
|
|||||||
cppcoreguidelines-slicing,
|
cppcoreguidelines-slicing,
|
||||||
google-explicit-constructor,
|
google-explicit-constructor,
|
||||||
llvm-namespace-comment,
|
llvm-namespace-comment,
|
||||||
|
misc-definitions-in-headers,
|
||||||
misc-misplaced-const,
|
misc-misplaced-const,
|
||||||
misc-non-copyable-objects,
|
misc-non-copyable-objects,
|
||||||
misc-static-assert,
|
misc-static-assert,
|
||||||
@ -17,6 +18,7 @@ misc-throw-by-value-catch-by-reference,
|
|||||||
misc-uniqueptr-reset-release,
|
misc-uniqueptr-reset-release,
|
||||||
misc-unused-parameters,
|
misc-unused-parameters,
|
||||||
modernize-avoid-bind,
|
modernize-avoid-bind,
|
||||||
|
modernize-loop-convert,
|
||||||
modernize-make-shared,
|
modernize-make-shared,
|
||||||
modernize-redundant-void-arg,
|
modernize-redundant-void-arg,
|
||||||
modernize-replace-auto-ptr,
|
modernize-replace-auto-ptr,
|
||||||
@ -63,6 +65,8 @@ readability-uniqueptr-delete-release,
|
|||||||
CheckOptions:
|
CheckOptions:
|
||||||
- key: performance-for-range-copy.WarnOnAllAutoCopies
|
- key: performance-for-range-copy.WarnOnAllAutoCopies
|
||||||
value: true
|
value: true
|
||||||
|
- key: performance-inefficient-string-concatenation.StrictMode
|
||||||
|
value: true
|
||||||
- key: performance-unnecessary-value-param.AllowedTypes
|
- key: performance-unnecessary-value-param.AllowedTypes
|
||||||
value: 'exception_ptr$;'
|
value: 'exception_ptr$;'
|
||||||
- key: readability-implicit-bool-conversion.AllowPointerConditions
|
- key: readability-implicit-bool-conversion.AllowPointerConditions
|
||||||
|
@ -31,8 +31,8 @@ py::bytes return_bytes() {
|
|||||||
std::string print_bytes(const py::bytes &bytes) {
|
std::string print_bytes(const py::bytes &bytes) {
|
||||||
std::string ret = "bytes[";
|
std::string ret = "bytes[";
|
||||||
const auto value = static_cast<std::string>(bytes);
|
const auto value = static_cast<std::string>(bytes);
|
||||||
for (size_t i = 0; i < value.length(); ++i) {
|
for (char c : value) {
|
||||||
ret += std::to_string(static_cast<int>(value[i])) + " ";
|
ret += std::to_string(static_cast<int>(c)) + ' ';
|
||||||
}
|
}
|
||||||
ret.back() = ']';
|
ret.back() = ']';
|
||||||
return ret;
|
return ret;
|
||||||
|
Loading…
Reference in New Issue
Block a user