Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2024-11-25 06:35:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add const to buffer:request() (#1890)

Browse Source
This commit is contained in:
Stephen Larew 2019-08-27 08:05:47 -07:00 committed by Wenzel Jakob
parent 8f5a8ab4ac
commit 5b4751af26
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/pybind11/pytypes.h
View File

@ -1312,7 +1312,7 @@ class buffer : public object {
public: public:
PYBIND11_OBJECT_DEFAULT(buffer, object, PyObject_CheckBuffer) PYBIND11_OBJECT_DEFAULT(buffer, object, PyObject_CheckBuffer)
buffer_info request(bool writable = false) { buffer_info request(bool writable = false) const {
int flags = PyBUF_STRIDES | PyBUF_FORMAT; int flags = PyBUF_STRIDES | PyBUF_FORMAT;
if (writable) flags |= PyBUF_WRITABLE; if (writable) flags |= PyBUF_WRITABLE;
Py_buffer *view = new Py_buffer(); Py_buffer *view = new Py_buffer();

2
tests/test_buffers.cpp
View File

@ -78,7 +78,7 @@ TEST_SUBMODULE(buffers, m) {
py::class_<Matrix>(m, "Matrix", py::buffer_protocol()) py::class_<Matrix>(m, "Matrix", py::buffer_protocol())
.def(py::init<ssize_t, ssize_t>()) .def(py::init<ssize_t, ssize_t>())
/// Construct from a buffer /// Construct from a buffer
.def(py::init([](py::buffer b) { .def(py::init([](py::buffer const b) {
py::buffer_info info = b.request(); py::buffer_info info = b.request();
if (info.format != py::format_descriptor<float>::format() || info.ndim != 2) if (info.format != py::format_descriptor<float>::format() || info.ndim != 2)
throw std::runtime_error("Incompatible buffer format!"); throw std::runtime_error("Incompatible buffer format!");