Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2024-11-11 08:03:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Changing cast_error("... Python instance was disowned.") to value_error (which changes RuntimeError to ValueError). (#2880)

Browse Source
This commit is contained in:
Ralf W. Grosse-Kunstleve 2021-02-26 23:19:23 -08:00 committed by GitHub
parent 01e0045547
commit 666fc0d8e8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/pybind11/detail/smart_holder_type_casters.h
View File

@ -388,8 +388,8 @@ private:
" Python instance is uninitialized.");
}
if (!holder().has_pointee()) {
throw cast_error("Missing value for wrapped C++ type:"
" Python instance was disowned.");
throw value_error("Missing value for wrapped C++ type:"
" Python instance was disowned.");
}
}

2
tests/test_class_sh_basic.py
View File

@ -78,7 +78,7 @@ def test_load_with_rtrn_f(pass_f, rtrn_f, expected):
def test_pass_unique_ptr_disowns(pass_f, rtrn_f, expected):
obj = rtrn_f()
assert pass_f(obj) == expected
with pytest.raises(RuntimeError) as exc_info:
with pytest.raises(ValueError) as exc_info:
pass_f(obj)
assert str(exc_info.value) == (
"Missing value for wrapped C++ type: Python instance was disowned."

2
tests/test_class_sh_unique_ptr_member.py
View File

@ -17,7 +17,7 @@ def test_pointee_and_ptr_owner(give_up_ownership_via):
obj = m.pointee()
assert obj.get_int() == 213
owner = m.ptr_owner(obj)
with pytest.raises(RuntimeError) as exc_info:
with pytest.raises(ValueError) as exc_info:
obj.get_int()
assert (
str(exc_info.value)