Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2024-11-25 06:35:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move object in pop method of List. (#3116)

Browse Source 
* Move item instead of copy.

* Make Clang 3.6 happy.

Co-authored-by: c99 <email@dummy.com>
This commit is contained in:
blacktea 2021-07-20 18:48:09 +03:00 committed by GitHub
parent 9626483cdf
commit 6d5d4e738c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/pybind11/stl_bind.h
View File

@ -191,7 +191,7 @@ void vector_modifiers(enable_if_t<is_copy_constructible<typename Vector::value_t
[](Vector &v) { [](Vector &v) {
if (v.empty()) if (v.empty())
throw index_error(); throw index_error();
T t = v.back(); T t = std::move(v.back());
v.pop_back(); v.pop_back();
return t; return t;
}, },
@ -201,8 +201,8 @@ void vector_modifiers(enable_if_t<is_copy_constructible<typename Vector::value_t
cl.def("pop", cl.def("pop",
[wrap_i](Vector &v, DiffType i) { [wrap_i](Vector &v, DiffType i) {
i = wrap_i(i, v.size()); i = wrap_i(i, v.size());
T t = v[(SizeType) i]; T t = std::move(v[(SizeType) i]);
v.erase(v.begin() + i); v.erase(std::next(v.begin(), i));
return t; return t;
}, },
arg("i"), arg("i"),