Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2025-01-19 09:25:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixing very minor oversights discovered while proof-reading the initial version for the first time on GitHub. Pushing directly. Not worth a PR.

Browse Source
This commit is contained in:
Ralf W. Grosse-Kunstleve 2021-04-05 14:02:08 -07:00
parent 0b63dd0eb2
commit 71603042d2
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
README_smart_holder.rst
View File

@ -85,8 +85,8 @@ disadvantage of having to use the ``PYBIND11_SMART_HOLDER_TYPE_CASTERS`` macro.
Conservative mode Conservative mode
----------------- -----------------
Here is a minimal example for wrapping a C++ type with the `smart_holder` Here is a minimal example for wrapping a C++ type with ``py::smart_holder`` as
type as the holder: holder:
.. code-block:: cpp .. code-block:: cpp
@ -106,7 +106,7 @@ There are three small differences compared to traditional pybind11:
- ``#include <pybind11/smart_holder.h>`` is used instead of - ``#include <pybind11/smart_holder.h>`` is used instead of
``#include <pybind11/pybind11.h>``. ``#include <pybind11/pybind11.h>``.
- ``py::classh`` is used instead of `py::class_`. - ``py::classh`` is used instead of ``py::class_``.
- The ``PYBIND11_SMART_HOLDER_TYPE_CASTERS(Foo)`` macro is needed. - The ``PYBIND11_SMART_HOLDER_TYPE_CASTERS(Foo)`` macro is needed.
@ -183,7 +183,7 @@ GitHub testing of PRs against the smart_holder branch
PRs against the smart_holder branch need to be tested in both PRs against the smart_holder branch need to be tested in both
modes (conservative, progressive), with the only difference that modes (conservative, progressive), with the only difference that
`PYBIND11_USE_SMART_HOLDER_AS_DEFAULT` is defined for progressive mode ``PYBIND11_USE_SMART_HOLDER_AS_DEFAULT`` is defined for progressive mode
testing. Currently this is handled simply by creating a secondary PR with a testing. Currently this is handled simply by creating a secondary PR with a
one-line change in ``include/pybind11/detail/smart_holder_sfinae_hooks_only.h`` one-line change in ``include/pybind11/detail/smart_holder_sfinae_hooks_only.h``
(as in e.g. `PR #2879 <https://github.com/pybind/pybind11/pull/2879>`_). It (as in e.g. `PR #2879 <https://github.com/pybind/pybind11/pull/2879>`_). It