Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2024-11-25 14:45:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a memory leak when creating Python3 modules. (#2019)

Browse Source
This commit is contained in:
Nils Berg 2019-12-11 15:01:45 +00:00 committed by Wenzel Jakob
parent dc9006db4f
commit 819802da99
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
include/pybind11/pybind11.h
View File

@ -794,11 +794,16 @@ public:
explicit module(const char *name, const char *doc = nullptr) { explicit module(const char *name, const char *doc = nullptr) {
if (!options::show_user_defined_docstrings()) doc = nullptr; if (!options::show_user_defined_docstrings()) doc = nullptr;
#if PY_MAJOR_VERSION >= 3 #if PY_MAJOR_VERSION >= 3
PyModuleDef *def = new PyModuleDef(); PyModuleDef *def = PyMem_New(PyModuleDef, 1);
std::memset(def, 0, sizeof(PyModuleDef)); std::memset(def, 0, sizeof(PyModuleDef));
def->m_name = name; def->m_name = name;
def->m_doc = doc; def->m_doc = doc;
def->m_size = -1; def->m_size = -1;
def->m_free = [](void* module ) {
if (module != nullptr) {
Py_XDECREF(PyModule_GetDef((PyObject*) module));
}
};
Py_INCREF(def); Py_INCREF(def);
m_ptr = PyModule_Create(def); m_ptr = PyModule_Create(def);
#else #else