From 90bac96321e3f189f4b60074c1e4ad782dd3ceb6 Mon Sep 17 00:00:00 2001 From: Jason Rhinelander Date: Fri, 14 Apr 2017 17:50:44 -0400 Subject: [PATCH] Keep skipping buffer tests on pypy Adding numpy to the pypy test exposed a segfault caused by the buffer tests in test_stl_binders.py: the first such test was explicitly skipped on pypy, but the second (test_vector_buffer_numpy) which also seems to cause an occasional segfault was just marked as requiring numpy. Explicitly skip it on pypy as well (until a workaround, fix, or pypy fix are found). --- tests/test_stl_binders.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/test_stl_binders.py b/tests/test_stl_binders.py index 0edf9e26e..b200be433 100644 --- a/tests/test_stl_binders.py +++ b/tests/test_stl_binders.py @@ -33,6 +33,8 @@ def test_vector_int(): assert v_int2 == VectorInt([0, 99, 2, 3]) +# As of pypy 5.7.1, running this and the next test seems to trigger a segfault +# related to the PyPy's buffer protocol. @pytest.unsupported_on_pypy def test_vector_buffer(): from pybind11_tests import VectorUChar, create_undeclstruct @@ -53,6 +55,7 @@ def test_vector_buffer(): create_undeclstruct() # Undeclared struct contents, no buffer interface +@pytest.unsupported_on_pypy @pytest.requires_numpy def test_vector_buffer_numpy(): from pybind11_tests import VectorInt, VectorStruct, get_vectorstruct