mirror of
https://github.com/pybind/pybind11.git
synced 2024-11-11 08:03:55 +00:00
Fix Clazy warnings (#4988)
* stl.h: Use C++11 range-loops with const reference This saves copy-ctor and dtor for non-trivial types by value Found by clazy (range-loop-reference) * test_smart_ptr.cpp cleanup Introduce `pointer_set<T>` https://github.com/boostorg/unordered/issues/139 > Based on the standard, the first move should leave a in a "valid but unspecified state"; --------- Co-authored-by: Ralf W. Grosse-Kunstleve <rwgk@google.com>
This commit is contained in:
parent
eeac2f4572
commit
976fea05a3
@ -172,7 +172,7 @@ struct list_caster {
|
||||
auto s = reinterpret_borrow<sequence>(src);
|
||||
value.clear();
|
||||
reserve_maybe(s, &value);
|
||||
for (auto it : s) {
|
||||
for (const auto &it : s) {
|
||||
value_conv conv;
|
||||
if (!conv.load(it, convert)) {
|
||||
return false;
|
||||
@ -247,7 +247,7 @@ public:
|
||||
return false;
|
||||
}
|
||||
size_t ctr = 0;
|
||||
for (auto it : l) {
|
||||
for (const auto &it : l) {
|
||||
value_conv conv;
|
||||
if (!conv.load(it, convert)) {
|
||||
return false;
|
||||
|
@ -103,21 +103,26 @@ private:
|
||||
int value;
|
||||
};
|
||||
|
||||
template <typename T>
|
||||
std::unordered_set<T *> &pointer_set() {
|
||||
// https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
|
||||
static auto singleton = new std::unordered_set<T *>();
|
||||
return *singleton;
|
||||
}
|
||||
|
||||
// test_unique_nodelete
|
||||
// Object with a private destructor
|
||||
class MyObject4;
|
||||
std::unordered_set<MyObject4 *> myobject4_instances;
|
||||
class MyObject4 {
|
||||
public:
|
||||
explicit MyObject4(int value) : value{value} {
|
||||
print_created(this);
|
||||
myobject4_instances.insert(this);
|
||||
pointer_set<MyObject4>().insert(this);
|
||||
}
|
||||
int value;
|
||||
|
||||
static void cleanupAllInstances() {
|
||||
auto tmp = std::move(myobject4_instances);
|
||||
myobject4_instances.clear();
|
||||
auto tmp = std::move(pointer_set<MyObject4>());
|
||||
pointer_set<MyObject4>().clear();
|
||||
for (auto *o : tmp) {
|
||||
delete o;
|
||||
}
|
||||
@ -125,7 +130,7 @@ public:
|
||||
|
||||
private:
|
||||
~MyObject4() {
|
||||
myobject4_instances.erase(this);
|
||||
pointer_set<MyObject4>().erase(this);
|
||||
print_destroyed(this);
|
||||
}
|
||||
};
|
||||
@ -133,19 +138,17 @@ private:
|
||||
// test_unique_deleter
|
||||
// Object with std::unique_ptr<T, D> where D is not matching the base class
|
||||
// Object with a protected destructor
|
||||
class MyObject4a;
|
||||
std::unordered_set<MyObject4a *> myobject4a_instances;
|
||||
class MyObject4a {
|
||||
public:
|
||||
explicit MyObject4a(int i) : value{i} {
|
||||
print_created(this);
|
||||
myobject4a_instances.insert(this);
|
||||
pointer_set<MyObject4a>().insert(this);
|
||||
};
|
||||
int value;
|
||||
|
||||
static void cleanupAllInstances() {
|
||||
auto tmp = std::move(myobject4a_instances);
|
||||
myobject4a_instances.clear();
|
||||
auto tmp = std::move(pointer_set<MyObject4a>());
|
||||
pointer_set<MyObject4a>().clear();
|
||||
for (auto *o : tmp) {
|
||||
delete o;
|
||||
}
|
||||
@ -153,7 +156,7 @@ public:
|
||||
|
||||
protected:
|
||||
virtual ~MyObject4a() {
|
||||
myobject4a_instances.erase(this);
|
||||
pointer_set<MyObject4a>().erase(this);
|
||||
print_destroyed(this);
|
||||
}
|
||||
};
|
||||
|
Loading…
Reference in New Issue
Block a user