Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2024-11-25 14:45:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

detail/init.h: fix the "see above" comments

Browse Source 
The "see above" comment being referenced in the code comments isn't
"above" anymore; copy the later factory init comment into the first
constructor block to fix it.
This commit is contained in:
Jason Rhinelander 2017-08-21 16:50:46 -04:00
parent 1fb9df601c
commit 9f6a636e54
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/pybind11/detail/init.h
View File

@ -168,7 +168,9 @@ template <typename... Args> struct constructor {
auto *cl_type = get_type_info(typeid(Cpp<Class>)); auto *cl_type = get_type_info(typeid(Cpp<Class>));
cl.def("__init__", [cl_type](handle self_, Args... args) { cl.def("__init__", [cl_type](handle self_, Args... args) {
auto v_h = load_v_h(self_, cl_type); auto v_h = load_v_h(self_, cl_type);
if (v_h.instance_registered()) return; // Ignore duplicate __init__ calls (see above) // If this value is already registered it must mean __init__ is invoked multiple times;
// we really can't support that in C++, so just ignore the second __init__.
if (v_h.instance_registered()) return;
construct<Class>(v_h, new Cpp<Class>(std::forward<Args>(args)...), false); construct<Class>(v_h, new Cpp<Class>(std::forward<Args>(args)...), false);
}, extra...); }, extra...);