From a7e7a6e8460767b70f11b375ea564d3856272260 Mon Sep 17 00:00:00 2001 From: Axel Huebl Date: Thu, 17 Mar 2022 11:21:28 -0700 Subject: [PATCH 1/2] Docs: No Strip in Debug (#3779) The docs were not 100% the same as we advertise with our tooling function: most users do not want to strip symbols in Debug builds. --- docs/compiling.rst | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/compiling.rst b/docs/compiling.rst index 4ae9234e1..2b543be0b 100644 --- a/docs/compiling.rst +++ b/docs/compiling.rst @@ -505,7 +505,10 @@ You can use these targets to build complex applications. For example, the target_link_libraries(example PRIVATE pybind11::module pybind11::lto pybind11::windows_extras) pybind11_extension(example) - pybind11_strip(example) + if(NOT MSVC AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug|RelWithDebInfo) + # Strip unnecessary sections of the binary on Linux/macOS + pybind11_strip(example) + endif() set_target_properties(example PROPERTIES CXX_VISIBILITY_PRESET "hidden" CUDA_VISIBILITY_PRESET "hidden") From 8b1944d390e9a89f22a1e47d2acbe7c547662aad Mon Sep 17 00:00:00 2001 From: JonTriebenbach <40633432+JonTriebenbach@users.noreply.github.com> Date: Thu, 17 Mar 2022 14:51:16 -0500 Subject: [PATCH 2/2] Remove idioms in code comments (#3809) --- .github/workflows/ci.yml | 2 +- docs/advanced/pycpp/numpy.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 11c93bafc..3523e82c0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -667,7 +667,7 @@ jobs: # This verifies that the documentation is not horribly broken, and does a - # basic sanity check on the SDist. + # basic validation check on the SDist. doxygen: name: "Documentation build test" runs-on: ubuntu-latest diff --git a/docs/advanced/pycpp/numpy.rst b/docs/advanced/pycpp/numpy.rst index 8ad341004..b6ef019ed 100644 --- a/docs/advanced/pycpp/numpy.rst +++ b/docs/advanced/pycpp/numpy.rst @@ -87,7 +87,7 @@ buffer objects (e.g. a NumPy matrix). /* Request a buffer descriptor from Python */ py::buffer_info info = b.request(); - /* Some sanity checks ... */ + /* Some basic validation checks ... */ if (info.format != py::format_descriptor::format()) throw std::runtime_error("Incompatible format: expected a double array!");