Add shellcheck style checking (#3114)

This commit is contained in:
Aaron Gokaslan 2021-07-14 16:52:13 -04:00 committed by GitHub
parent cd061aeef1
commit c4b0dc7cdd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 3 deletions

View File

@ -95,6 +95,11 @@ repos:
exclude: ".supp$" exclude: ".supp$"
args: ["-L", "nd,ot,thist"] args: ["-L", "nd,ot,thist"]
- repo: https://github.com/shellcheck-py/shellcheck-py
rev: v0.7.2.1
hooks:
- id: shellcheck
# The original pybind11 checks for a few C++ style items # The original pybind11 checks for a few C++ style items
- repo: local - repo: local
hooks: hooks:

View File

@ -16,11 +16,11 @@ check_style_errors=0
IFS=$'\n' IFS=$'\n'
found="$(grep '\<\(if\|for\|while\|catch\)(\|){' $@ -rn --color=always)" found="$(grep '\<\(if\|for\|while\|catch\)(\|){' "$@" -rn --color=always)"
if [ -n "$found" ]; then if [ -n "$found" ]; then
echo -e '\033[31;01mError: found the following coding style problems:\033[0m' echo -e '\033[31;01mError: found the following coding style problems:\033[0m'
check_style_errors=1 check_style_errors=1
echo "$found" | sed -e 's/^/ /' echo "${found//^/ /}"
fi fi
found="$(awk ' found="$(awk '
@ -34,7 +34,7 @@ last && /^\s*{/ {
last="" last=""
} }
{ last = /(if|for|while|catch|switch)\s*\(.*\)\s*$/ ? $0 : "" } { last = /(if|for|while|catch|switch)\s*\(.*\)\s*$/ ? $0 : "" }
' $(find include -type f) $@)" ' "$(find include -type f)" "$@")"
if [ -n "$found" ]; then if [ -n "$found" ]; then
check_style_errors=1 check_style_errors=1
echo -e '\033[31;01mError: braces should occur on the same line as the if/while/.. statement. Found issues in the following files:\033[0m' echo -e '\033[31;01mError: braces should occur on the same line as the if/while/.. statement. Found issues in the following files:\033[0m'