From c65d5dfaa80086f09983ccf38e098f437d7c6479 Mon Sep 17 00:00:00 2001
From: "Ralf W. Grosse-Kunstleve" <rwgk@google.com>
Date: Sun, 14 Jul 2024 00:42:45 -0700
Subject: [PATCH] Systematically use `is_base_of<type_caster_generic,
 make_caster<D>>` in `property_cpp_function<>` specializations.

---
 include/pybind11/pybind11.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/include/pybind11/pybind11.h b/include/pybind11/pybind11.h
index 547f377a7..f13f9c5b7 100644
--- a/include/pybind11/pybind11.h
+++ b/include/pybind11/pybind11.h
@@ -1635,8 +1635,8 @@ struct property_cpp_function<
     T,
     D,
     detail::enable_if_t<
-        detail::all_of<std::is_base_of<detail::type_caster_base<T>, detail::type_caster<T>>,
-                       std::is_base_of<detail::type_caster_base<D>, detail::make_caster<D>>,
+        detail::all_of<std::is_base_of<detail::type_caster_generic, detail::type_caster<T>>,
+                       std::is_base_of<detail::type_caster_generic, detail::make_caster<D>>,
                        std::is_pointer<D>>::value>> {
 
     using drp = typename std::remove_pointer<D>::type;
@@ -1683,8 +1683,8 @@ struct property_cpp_function<
     T,
     D,
     detail::enable_if_t<
-        detail::all_of<std::is_base_of<detail::type_caster_base<T>, detail::type_caster<T>>,
-                       std::is_base_of<detail::type_caster_base<D>, detail::type_caster<D>>,
+        detail::all_of<std::is_base_of<detail::type_caster_generic, detail::type_caster<T>>,
+                       std::is_base_of<detail::type_caster_generic, detail::make_caster<D>>,
                        detail::none_of<std::is_pointer<D>,
                                        std::is_array<D>,
                                        detail::is_instantiation<std::unique_ptr, D>,
@@ -1743,10 +1743,10 @@ struct property_cpp_function<
     T,
     D,
     detail::enable_if_t<
-        detail::all_of<std::is_base_of<detail::type_caster_base<T>, detail::type_caster<T>>,
+        detail::all_of<std::is_base_of<detail::type_caster_generic, detail::type_caster<T>>,
                        detail::is_instantiation<std::unique_ptr, D>,
-                       std::is_base_of<detail::type_caster_base<typename D::element_type>,
-                                       detail::type_caster<typename D::element_type>>>::value>> {
+                       std::is_base_of<detail::type_caster_generic,
+                                       detail::make_caster<typename D::element_type>>>::value>> {
 
     template <typename PM, must_be_member_function_pointer<PM> = 0>
     static cpp_function readonly(PM, const handle &) {