Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2024-11-25 22:52:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

MSVC but not Clang: /MP (#2824)

Browse Source 
On Windows, clang-cl does not understand /MP.
```
clang-cl: warning: argument unused during compilation: '/MP' [-Wunused-command-line-argument]
```
with Clang 10.0.0
This commit is contained in:
Axel Huebl 2021-02-08 12:40:04 -08:00 committed by GitHub
parent e791ec4e27
commit c78dfb69f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/pybind11Common.cmake
View File

@ -115,14 +115,16 @@ endif()
add_library(pybind11::windows_extras IMPORTED INTERFACE ${optional_global}) add_library(pybind11::windows_extras IMPORTED INTERFACE ${optional_global})
if(MSVC) if(MSVC) # That's also clang-cl
# /MP enables multithreaded builds (relevant when there are many files), /bigobj is # /bigobj is needed for bigger binding projects due to the limit to 64k
# needed for bigger binding projects due to the limit to 64k addressable sections # addressable sections
set_property( set_property(
TARGET pybind11::windows_extras TARGET pybind11::windows_extras
APPEND APPEND
PROPERTY INTERFACE_COMPILE_OPTIONS /bigobj) PROPERTY INTERFACE_COMPILE_OPTIONS /bigobj)
# /MP enables multithreaded builds (relevant when there are many files) for MSVC
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC") # no Clang no Intel
if(CMAKE_VERSION VERSION_LESS 3.11) if(CMAKE_VERSION VERSION_LESS 3.11)
set_property( set_property(
TARGET pybind11::windows_extras TARGET pybind11::windows_extras
@ -136,7 +138,9 @@ if(MSVC)
set_property( set_property(
TARGET pybind11::windows_extras TARGET pybind11::windows_extras
APPEND APPEND
PROPERTY INTERFACE_COMPILE_OPTIONS $<$<NOT:$<CONFIG:Debug>>:$<$<COMPILE_LANGUAGE:CXX>:/MP>>) PROPERTY INTERFACE_COMPILE_OPTIONS
$<$<NOT:$<CONFIG:Debug>>:$<$<COMPILE_LANGUAGE:CXX>:/MP>>)
endif()
endif() endif()
endif() endif()