Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2025-02-15 05:07:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix actual undefined behavior exposed by previous changes.

Browse Source 
It turns out the previous commit message is incorrect, the `inst` pointer is actually dereferenced, in the `value_and_holder` ctor here:

f3e0602802/include/pybind11/detail/type_caster_base.h (L262-L263)

```
259     // Main constructor for a found value/holder:
260     value_and_holder(instance *i, const detail::type_info *type, size_t vpos, size_t index)
261         : inst{i}, index{index}, type{type},
262           vh{inst->simple_layout ? inst->simple_value_holder
263                                  : &inst->nonsimple.values_and_holders[vpos]} {}
```
This commit is contained in:
Ralf W. Grosse-Kunstleve 2023-07-31 10:26:13 -07:00
parent cf5958d516
commit c89561f77a
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
include/pybind11/detail/type_caster_base.h
View File

@ -349,12 +349,16 @@ public:
const type_vec *types = nullptr; const type_vec *types = nullptr;
value_and_holder curr; value_and_holder curr;
friend struct values_and_holders; friend struct values_and_holders;
iterator(instance *inst, const type_vec *tinfo) iterator(instance *inst, const type_vec *tinfo) : inst{inst}, types{tinfo} {
: inst{inst}, types{tinfo}, if (inst != nullptr) {
curr(inst /* instance */, assert(!types->empty());
types->empty() ? nullptr : (*types)[0] /* type info */, curr = value_and_holder(
0, /* vpos: (non-simple types only): the first vptr comes first */ inst /* instance */,
0 /* index */) {} (*types)[0] /* type info */,
0, /* vpos: (non-simple types only): the first vptr comes first */
0 /* index */);
}
}
// Past-the-end iterator: // Past-the-end iterator:
explicit iterator(size_t end) : curr(end) {} explicit iterator(size_t end) : curr(end) {}