Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2024-11-25 14:45:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix small bug introduced with PR #4735 (#4845)

Browse Source 
* Bug fix: `result[0]` called if `result.empty()`

* Add unit test that fails without the fix.
This commit is contained in:
Ralf W. Grosse-Kunstleve 2023-09-14 09:47:34 -07:00 committed by GitHub
parent 8c7b8dd0ae
commit d06d53694a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
include/pybind11/pybind11.h
View File

@ -57,11 +57,13 @@ inline std::string replace_newlines_and_squash(const char *text) {
std::string result(text); std::string result(text);
bool previous_is_whitespace = false; bool previous_is_whitespace = false;
// Do not modify string representations if (result.size() >= 2) {
char first_char = result[0]; // Do not modify string representations
char last_char = result[result.size() - 1]; char first_char = result[0];
if (first_char == last_char && first_char == '\'') { char last_char = result[result.size() - 1];
return result; if (first_char == last_char && first_char == '\'') {
return result;
}
} }
result.clear(); result.clear();

2
tests/test_kwargs_and_defaults.cpp
View File

@ -85,6 +85,8 @@ TEST_SUBMODULE(kwargs_and_defaults, m) {
"kw_lb_func7", "kw_lb_func7",
[](const std::string &) {}, [](const std::string &) {},
py::arg("str_arg") = "First line.\n Second line."); py::arg("str_arg") = "First line.\n Second line.");
m.def(
"kw_lb_func8", [](const CustomRepr &) {}, py::arg("custom") = CustomRepr(""));
// test_args_and_kwargs // test_args_and_kwargs
m.def("args_function", [](py::args args) -> py::tuple { m.def("args_function", [](py::args args) -> py::tuple {

4
tests/test_kwargs_and_defaults.py
View File

@ -55,6 +55,10 @@ def test_function_signatures(doc):
doc(m.kw_lb_func7) doc(m.kw_lb_func7)
== "kw_lb_func7(str_arg: str = 'First line.\\n Second line.') -> None" == "kw_lb_func7(str_arg: str = 'First line.\\n Second line.') -> None"
) )
assert (
doc(m.kw_lb_func8)
== "kw_lb_func8(custom: m.kwargs_and_defaults.CustomRepr = ) -> None"
)
def test_named_arguments(): def test_named_arguments():