Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2025-01-18 17:05:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix oversight: remove __NVCOMPILER elif branch in PYBIND11_BUILD_ABI block.

Browse Source 
Also add comment pointing to this PR (#5439).
This commit is contained in:
Ralf W. Grosse-Kunstleve 2024-11-25 13:24:43 -08:00
parent 9fc9515885
commit d412303e72
No known key found for this signature in database
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/pybind11/conduit/pybind11_platform_abi_id.h
View File

@ -64,11 +64,9 @@
# error "Unknown major version for MSC_VER: PLEASE REVISE THIS CODE." # error "Unknown major version for MSC_VER: PLEASE REVISE THIS CODE."
# endif # endif
# endif # endif
# elif defined(__NVCOMPILER) // NVHPC (PGI-based).
# define PYBIND11_BUILD_ABI "" // TODO: What should be here, to prevent UB?
# elif defined(_LIBCPP_ABI_VERSION) // https://libcxx.llvm.org/DesignDocs/ABIVersioning.html # elif defined(_LIBCPP_ABI_VERSION) // https://libcxx.llvm.org/DesignDocs/ABIVersioning.html
# define PYBIND11_BUILD_ABI "_abi" PYBIND11_PLATFORM_ABI_ID_TOSTRING(_LIBCPP_ABI_VERSION) # define PYBIND11_BUILD_ABI "_abi" PYBIND11_PLATFORM_ABI_ID_TOSTRING(_LIBCPP_ABI_VERSION)
# elif defined(__GXX_ABI_VERSION) # elif defined(__GXX_ABI_VERSION) // See PR #5439.
# if __GXX_ABI_VERSION >= 1002 && __GXX_ABI_VERSION < 2000 # if __GXX_ABI_VERSION >= 1002 && __GXX_ABI_VERSION < 2000
# if !defined(_GLIBCXX_USE_CXX11_ABI) # if !defined(_GLIBCXX_USE_CXX11_ABI)
# error "UNEXPECTED: _GLIBCXX_USE_CXX11_ABI not defined: PLEASE REVISE THIS CODE." # error "UNEXPECTED: _GLIBCXX_USE_CXX11_ABI not defined: PLEASE REVISE THIS CODE."