Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2025-01-19 09:25:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(smart_holder): Use std::default_delete. (#4924)

Browse Source 
Ensures `std::default_delete<T>` is used to look up the deleter for a type instead of `delete` directly.
This commit is contained in:
Ivor Wanders 2023-11-06 18:56:21 -05:00 committed by GitHub
parent edfaaed87e
commit e02fe001cd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/pybind11/detail/smart_holder_poc.h
View File

@ -103,7 +103,7 @@ struct guarded_delete {
template <typename T, typename std::enable_if<std::is_destructible<T>::value, int>::type = 0> template <typename T, typename std::enable_if<std::is_destructible<T>::value, int>::type = 0>
inline void builtin_delete_if_destructible(void *raw_ptr) { inline void builtin_delete_if_destructible(void *raw_ptr) {
delete static_cast<T *>(raw_ptr); std::default_delete<T>{}(static_cast<T *>(raw_ptr));
} }
template <typename T, typename std::enable_if<!std::is_destructible<T>::value, int>::type = 0> template <typename T, typename std::enable_if<!std::is_destructible<T>::value, int>::type = 0>