chore(clang-tidy): add more modernize clang-tidy checks (#3049)

* Add more modernize clang-tidy checks

* Enable a few more
This commit is contained in:
Aaron Gokaslan 2021-06-19 18:38:56 -04:00 committed by GitHub
parent af6218ff78
commit e0b5cbd4c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 6 deletions

View File

@ -2,12 +2,17 @@ FormatStyle: file
Checks: ' Checks: '
llvm-namespace-comment, llvm-namespace-comment,
modernize-use-override, modernize-avoid-bind,
readability-container-size-empty, modernize-replace-auto-ptr,
modernize-use-using, modernize-replace-disallow-copy-and-assign-macro,
modernize-use-equals-default, modernize-shrink-to-fit,
modernize-use-auto, modernize-use-auto,
modernize-use-equals-default,
modernize-use-equals-delete,
modernize-use-emplace, modernize-use-emplace,
modernize-use-override,
modernize-use-using,
readability-container-size-empty,
' '
CheckOptions: CheckOptions:
@ -15,3 +20,5 @@ CheckOptions:
value: 'exception_ptr$;' value: 'exception_ptr$;'
HeaderFilterRegex: 'pybind11/.*h' HeaderFilterRegex: 'pybind11/.*h'
WarningsAsErrors: '*'

View File

@ -20,12 +20,12 @@ class TestFactory1 {
TestFactory1() : value("(empty)") { print_default_created(this); } TestFactory1() : value("(empty)") { print_default_created(this); }
TestFactory1(int v) : value(std::to_string(v)) { print_created(this, value); } TestFactory1(int v) : value(std::to_string(v)) { print_created(this, value); }
TestFactory1(std::string v) : value(std::move(v)) { print_created(this, value); } TestFactory1(std::string v) : value(std::move(v)) { print_created(this, value); }
public:
std::string value;
TestFactory1(TestFactory1 &&) = delete; TestFactory1(TestFactory1 &&) = delete;
TestFactory1(const TestFactory1 &) = delete; TestFactory1(const TestFactory1 &) = delete;
TestFactory1 &operator=(TestFactory1 &&) = delete; TestFactory1 &operator=(TestFactory1 &&) = delete;
TestFactory1 &operator=(const TestFactory1 &) = delete; TestFactory1 &operator=(const TestFactory1 &) = delete;
public:
std::string value;
~TestFactory1() { print_destroyed(this); } ~TestFactory1() { print_destroyed(this); }
}; };
// Non-public construction, but moveable: // Non-public construction, but moveable: