Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2024-11-29 08:32:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Slightly rewording comment. (There were also other failures.)

Browse Source
This commit is contained in:
Ralf W. Grosse-Kunstleve 2022-05-13 00:17:22 -07:00
parent 2ad22854dc
commit e3ebb0dbca
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
include/pybind11/pybind11.h
View File

@ -2612,12 +2612,13 @@ void print(Args &&...args) {
error_already_set::~error_already_set() { error_already_set::~error_already_set() {
// Not using py::gil_scoped_acquire here since that calls get_internals, // Not using py::gil_scoped_acquire here since that calls get_internals,
// which triggers tensorflow failures (a full explanation is currently unknown). // which is known to trigger failures in the wild (a full explanation is
// currently unknown).
// gil_scoped_acquire_local here is a straight copy from get_internals code. // gil_scoped_acquire_local here is a straight copy from get_internals code.
// I.e. py::gil_scoped_acquire acquires the GIL in detail/internals.h exactly // I.e. py::gil_scoped_acquire acquires the GIL in detail/internals.h exactly
// like we do here now, releases it, then acquires it again in gil.h. // like we do here now, releases it, then acquires it again in gil.h.
// Using gil_scoped_acquire_local cuts out the get_internals overhead and // Using gil_scoped_acquire_local cuts out the get_internals overhead and
// fixes the tensorflow failures. // fixes the failures observed in the wild. See PR #1895 for more background.
struct gil_scoped_acquire_local { struct gil_scoped_acquire_local {
gil_scoped_acquire_local() : state(PyGILState_Ensure()) {} gil_scoped_acquire_local() : state(PyGILState_Ensure()) {}
~gil_scoped_acquire_local() { PyGILState_Release(state); } ~gil_scoped_acquire_local() { PyGILState_Release(state); }