Zengtudor/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2024-12-03 18:37:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Abuse assignment operator

Browse Source
This commit is contained in:
Aaron Gokaslan 2022-04-24 11:29:12 -04:00
parent 98aff18132
commit e71d9b9586
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
include/pybind11/pytypes.h
View File

@ -13,6 +13,7 @@
#include "buffer_info.h" #include "buffer_info.h"
#include <exception> #include <exception>
#include <stdexcept>
#include <string> #include <string>
#include <type_traits> #include <type_traits>
#include <utility> #include <utility>
@ -387,13 +388,16 @@ public:
} }
} }
error_already_set(const error_already_set &) = default; error_already_set(const error_already_set &) noexcept = default;
error_already_set(error_already_set &&) = default; error_already_set(error_already_set &&) noexcept = default;
inline ~error_already_set() override; inline ~error_already_set() override;
const char *what() const noexcept override { const char *what() const noexcept override {
if (m_lazy_what.empty()) { auto *sup_what = std::runtime_error::what();
if (sup_what[0] != '\0') {
return sup_what;
} else if (m_lazy_what.empty()) {
try { try {
m_lazy_what = detail::error_string(m_type.ptr(), m_value.ptr(), m_trace.ptr()); m_lazy_what = detail::error_string(m_type.ptr(), m_value.ptr(), m_trace.ptr());
} catch (const std::exception &e) { } catch (const std::exception &e) {
@ -407,6 +411,7 @@ public:
return m_lazy_what.c_str(); return m_lazy_what.c_str();
} }
} }
assert(!m_lazy_what.empty()); assert(!m_lazy_what.empty());
return m_lazy_what.c_str(); return m_lazy_what.c_str();
} }
@ -415,7 +420,8 @@ public:
/// already set it is cleared first. After this call, the current object no longer stores the /// already set it is cleared first. After this call, the current object no longer stores the
/// error variables (but the `.what()` string is still available). /// error variables (but the `.what()` string is still available).
void restore() { void restore() {
what(); // Force-build `.what()`. // Abuse assignment operator to cache what()
std::runtime_error::operator=(std::runtime_error(what())); // Force-build `.what()`.
if (m_lazy_what.empty()) { if (m_lazy_what.empty()) {
pybind11_fail("Critical error building lazy error_string()."); pybind11_fail("Critical error building lazy error_string().");
} }