Go back to using union as originally suggested by jbms@. The trick (also suggested by jbms@) is to add empty ctor + dtor.

This commit is contained in:
Ralf W. Grosse-Kunstleve 2023-10-08 22:38:19 -07:00
parent 38317c3139
commit e7b8c4f0fc

View File

@ -21,7 +21,6 @@
#include <functional> #include <functional>
#include <numeric> #include <numeric>
#include <sstream> #include <sstream>
#include <stdalign.h>
#include <string> #include <string>
#include <type_traits> #include <type_traits>
#include <typeindex> #include <typeindex>
@ -55,16 +54,21 @@ public:
// Multiple threads may run this concurrently, but that is fine. // Multiple threads may run this concurrently, but that is fine.
auto value = initialize(); // May release and re-acquire the GIL. auto value = initialize(); // May release and re-acquire the GIL.
if (!initialized_) { // This runs with the GIL held, if (!initialized_) { // This runs with the GIL held,
new // therefore this is reached only once. new (&value_) // therefore this is reached only once.
(reinterpret_cast<T *>(value_storage_)) T(std::move(value)); T(std::move(value));
initialized_ = true; initialized_ = true;
} }
} }
return *reinterpret_cast<T *>(value_storage_); return value_;
} }
LazyInitializeAtLeastOnceDestroyNever() {}
~LazyInitializeAtLeastOnceDestroyNever() {}
private: private:
alignas(T) char value_storage_[sizeof(T)]; union {
T value_;
};
bool initialized_ = false; bool initialized_ = false;
}; };