diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 703b6dea3..40209adb4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -905,8 +905,7 @@ jobs: - { sys: mingw64, env: x86_64 } - { sys: mingw32, env: i686 } steps: - # Force version because of https://github.com/msys2/setup-msys2/issues/167 - - uses: msys2/setup-msys2@v2.4.2 + - uses: msys2/setup-msys2@v2 with: msystem: ${{matrix.sys}} install: >- @@ -936,10 +935,10 @@ jobs: run: cmake --build build --target pytest -j 2 - name: C++11 tests - run: cmake --build build --target cpptest -j 2 + run: PYTHONHOME=/${{matrix.sys}} PYTHONPATH=/${{matrix.sys}} cmake --build build --target cpptest -j 2 - name: Interface test C++11 - run: cmake --build build --target test_cmake_build + run: PYTHONHOME=/${{matrix.sys}} PYTHONPATH=/${{matrix.sys}} cmake --build build --target test_cmake_build - name: Clean directory run: git clean -fdx @@ -954,10 +953,10 @@ jobs: run: cmake --build build2 --target pytest -j 2 - name: C++14 tests - run: cmake --build build2 --target cpptest -j 2 + run: PYTHONHOME=/${{matrix.sys}} PYTHONPATH=/${{matrix.sys}} cmake --build build2 --target cpptest -j 2 - name: Interface test C++14 - run: cmake --build build2 --target test_cmake_build + run: PYTHONHOME=/${{matrix.sys}} PYTHONPATH=/${{matrix.sys}} cmake --build build2 --target test_cmake_build - name: Clean directory run: git clean -fdx @@ -972,7 +971,7 @@ jobs: run: cmake --build build3 --target pytest -j 2 - name: C++17 tests - run: cmake --build build3 --target cpptest -j 2 + run: PYTHONHOME=/${{matrix.sys}} PYTHONPATH=/${{matrix.sys}} cmake --build build3 --target cpptest -j 2 - name: Interface test C++17 - run: cmake --build build3 --target test_cmake_build + run: PYTHONHOME=/${{matrix.sys}} PYTHONPATH=/${{matrix.sys}} cmake --build build3 --target test_cmake_build diff --git a/docs/advanced/classes.rst b/docs/advanced/classes.rst index 6330af5eb..ba006252a 100644 --- a/docs/advanced/classes.rst +++ b/docs/advanced/classes.rst @@ -9,7 +9,7 @@ that you are already familiar with the basics from :doc:`/classes`. Overriding virtual functions in Python ====================================== -Suppose that a C++ class or interface has a virtual function that we'd like to +Suppose that a C++ class or interface has a virtual function that we'd like to override from within Python (we'll focus on the class ``Animal``; ``Dog`` is given as a specific example of how one would do this with traditional C++ code).