From f7b27efbc982a6d8a7bf8da9f467bd2064c62ccb Mon Sep 17 00:00:00 2001 From: Jason Rhinelander Date: Thu, 19 Jul 2018 15:03:26 -0300 Subject: [PATCH] Fix compatibility with catch v2 Catch v2 changed the `run(...)` signature to take a `char *argv[]`, arguing partly that technically a `char *argv[]` type is the correct `main()` signature rather than `const char *argv[]`. Dropping the `const` here doesn't appear to cause any problems with catch v1 (tested against both the cmake-downloaded 1.9.3 and Debian's 1.12.1 package) so we can follow suit. --- tests/test_embed/catch.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_embed/catch.cpp b/tests/test_embed/catch.cpp index 236409dbd..dd137385c 100644 --- a/tests/test_embed/catch.cpp +++ b/tests/test_embed/catch.cpp @@ -14,7 +14,7 @@ namespace py = pybind11; -int main(int argc, const char *argv[]) { +int main(int argc, char *argv[]) { py::scoped_interpreter guard{}; auto result = Catch::Session().run(argc, argv);