Ralf W. Grosse-Kunstleve
011c795b5f
test_class_sh_disowning.py: BAKEIN_WIP: Why is the behavior different?
2024-07-07 09:03:00 -07:00
Ralf W. Grosse-Kunstleve
1158dbc57b
Remove pytest.skip("BAKEIN_BREAK: ...") in test_class_sh_disowning_mi.py (tests pass without any further changes).
2024-07-07 08:47:04 -07:00
Ralf W. Grosse-Kunstleve
bb6b429a2f
MESSY but success for: test_get_vec_size_raw_shared[get_drvd_as_base0_raw_ptr-vec_size_base0_shared_ptr]
...
scons -j 48 selected_test_cpp=test_class_sh_mi_thunks.cpp && "$(cat PYROOT)"/bin/python3 $HOME/clone/pybind11_scons/run_tests.py ../pybind11 test_class_sh_mi_thunks.py -s -vv -k 'test_get_vec_size_raw_shared[get_drvd_as_base0_raw_ptr-vec_size_base0_shared_ptr]'
```
=========================================================== test session starts ============================================================
platform linux -- Python 3.11.8, pytest-7.4.4, pluggy-1.5.0 -- /usr/bin/python3
cachedir: .pytest_cache
C++ Info: 13.2.0 C++20 __pybind11_internals_v10000000_gcc_libstdcpp_cxxabi1018__ PYBIND11_SIMPLE_GIL_MANAGEMENT=False PYBIND11_NUMPY_1_ONLY=False
rootdir: /usr/local/google/home/rwgk/forked/pybind11/tests
configfile: pytest.ini
plugins: xdist-3.5.0
collected 10 items / 9 deselected / 1 selected
test_class_sh_mi_thunks.py::test_get_vec_size_raw_shared[get_drvd_as_base0_raw_ptr-vec_size_base0_shared_ptr]
LOOOK A
LOOOK get raw drvd 47927280
LOOOK get raw base 47927312
LOOOK B
LOOOK shd load(src, convert) X
LOOOK shd try_implicit_casts(src, convert) Q
LOOOK shd try_implicit_casts(src, convert) R
LOOOK shd load(src, convert) X
LOOOK shd load_value(v_h) ENTRY
LOOOK shd load_value(v_h) A
LOOOK shd load_value(v_h) B
LOOOK shd load(src, convert) Y 47927280
LOOOK shd try_implicit_casts(src, convert) S
LOOOK shd load(src, convert) Y 47927312
LOOOK operator std::shared_ptr<type> & A 47927312 /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../cast.h:891
LOOOK /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:838
LOOOK /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:842
LOOOK operator std::shared_ptr<type> & B 47927312 /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../cast.h:893
LOOOK shd const Base0 *obj 47927312
LOOOK shd const auto *obj_der 47927280
LOOOK C
PASSED
===================================================== 1 passed, 9 deselected in 0.01s ======================================================
```
2024-07-07 06:31:23 -07:00
Ralf W. Grosse-Kunstleve
b201eece19
Remove pytest.skip("BAKEIN_BREAK: ...") in test_class_sh_mi_thunks.py (tests still fail)
2024-07-06 13:17:20 -07:00
Ralf W. Grosse-Kunstleve
70ba91f721
Inline smart_holder_type_caster_support, trampoline_self_life_support in type_caster_base.h: the organization of the existing code makes it very difficult to factor the added code properly.
2024-07-06 11:04:25 -07:00
Ralf W. Grosse-Kunstleve
2180dd4b6b
Add test_class_sh_disowning_mi, test_class_sh_mi_thunks in CMakeLists.txt
2024-07-05 15:33:39 -07:00
Ralf W. Grosse-Kunstleve
34b8d360a2
Add pytest.skip("BAKEIN_BREAK: ...") in test_class_sh_disowning_mi.py
2024-07-05 15:27:05 -07:00
Ralf W. Grosse-Kunstleve
7173a3ab9d
Bring in tests/test_class_sh_disowning_mi.cpp,py from smart_holder branch as-is (AssertionError).
2024-07-05 15:21:49 -07:00
Ralf W. Grosse-Kunstleve
3466ce5f63
Add pytest.skip("BAKEIN_BREAK: ...") in test_class_sh_mi_thunks.py
2024-07-05 15:20:07 -07:00
Ralf W. Grosse-Kunstleve
25c8edf994
Bring in tests/test_class_sh_mi_thunks.cpp,py from smart_holder branch as-is (Segmentation fault).
2024-07-05 14:47:39 -07:00
Ralf W. Grosse-Kunstleve
288442cd5c
Add more test_class_sh_* in tests/CMakeLists.txt
...
All unit tests pass ASAN and MSAN testing with the Google-internal toolchain.
2024-07-05 14:40:43 -07:00
Ralf W. Grosse-Kunstleve
4ce1524c61
Bring in tests/test_class_sh_shared_ptr_copy_move.cpp,py from smart_holder branch as-is (does not build).
2024-07-05 14:25:44 -07:00
Ralf W. Grosse-Kunstleve
d9d96118e6
Bring in all tests/test_class_*.cpp,py from smart_holder branch as-is that pass without any further changes.
...
All unit tests pass ASAN and MSAN testing with the Google-internal toolchain.
2024-07-05 12:56:41 -07:00
Ralf W. Grosse-Kunstleve
470a765804
Bring in tests/test_class_sh_factory_constructors.cpp,py from smart_holder branch as-is (tests pass without any further changes).
...
All unit tests pass ASAN and MSAN testing with the Google-internal toolchain.
2024-07-05 12:38:07 -07:00
Ralf W. Grosse-Kunstleve
c84dacc379
Factor out smart_holder_value_and_holder_support.h to avoid code duplication.
...
All unit tests pass ASAN and MSAN testing with the Google-internal toolchain.
2024-07-05 12:18:11 -07:00
Ralf W. Grosse-Kunstleve
0b7a628a04
Check for Python instance is uninitialized/disowned in type_caster_base.h. CRUDE intermediate state, needs refactoring.
...
All 4 remaining BAKEIN_BREAK removed from test_class_sh_basic.py. With that both test_class_sh_basic.cpp and test_class_sh_basic.py are identical to the smart_holder branch.
All unit tests pass ASAN and MSAN testing with the Google-internal toolchain.
2024-07-05 00:28:43 -07:00
Ralf W. Grosse-Kunstleve
874f69d898
Add cast(const std::unique_ptr<type, deleter> &, ...). Remove the last 3 remaining BAKEIN_BREAK in test_class_sh_basic.cpp
2024-07-04 16:09:01 -07:00
Ralf W. Grosse-Kunstleve
ebbe066841
Implement operator std::unique_ptr<type, deleter>(). Resolves all but 1 block of 4 BAKEIN_BREAK in test_class_sh_basic.py
2024-07-04 11:26:43 -07:00
Ralf W. Grosse-Kunstleve
0eb23f2ad1
Remove all but 3 BAKEIN_BREAK in test_class_sh_basic.cpp
2024-07-04 08:47:34 -07:00
Ralf W. Grosse-Kunstleve
d4fc392ebe
move_only_holder_caster<type, std::unique_ptr<T, D>>: inherit from type_caster_base<T>
...
CRUDE INTERMEDIATE STATE, just to see if this builds on all platforms.
2024-07-03 15:16:46 -07:00
Ralf W. Grosse-Kunstleve
224e9343d2
Implement operator std::shared_ptr<type> &(), remove 2 BAKEIN_BREAK: pass_shmp, pass_shcp
2024-07-03 13:51:50 -07:00
Ralf W. Grosse-Kunstleve
5957133b6e
Add smart_holder_from_unique_ptr() specialization for std::unique_ptr<T const, D>
...
Enables removing:
4 BAKEIN_BREAK in test_class_sh_basic.cpp
2 BAKEIN_BREAK in test_class_sh_basic.py
2024-07-03 07:38:18 -07:00
Ralf W. Grosse-Kunstleve
7a6d30ca58
Fix rtrn_shmp, rtrn_shmp by transferring smart_holder_from_shared_ptr() functionality from smart_holder branch.
2024-07-02 18:25:01 -07:00
Ralf W. Grosse-Kunstleve
a332fe8cf4
Fix oversights: Add pybind11/smart_holder.h in CMakeLists.txt, tests/extra_python_package/test_files.py
2024-07-02 15:15:19 -07:00
Ralf W. Grosse-Kunstleve
12b01305de
Add no-op pybind11/smart_holder.h, 21 BAKEIN_BREAK in test_class_sh_basic.cpp, 26 BAKEIN_BREAK in test_class_sh_basic.py
...
```
========================================================= short test summary info ==========================================================
SKIPPED [1] test_class_sh_basic.py:59: got empty parameter set ('pass_f', 'rtrn_f', 'expected'), function test_load_with_rtrn_f at /usr/local/google/home/rwgk/forked/pybind11/tests/test_class_sh_basic.py:58
SKIPPED [1] test_class_sh_basic.py:70: got empty parameter set ('pass_f', 'rtrn_f', 'regex_expected'), function test_deleter_roundtrip at /usr/local/google/home/rwgk/forked/pybind11/tests/test_class_sh_basic.py:69
SKIPPED [1] test_class_sh_basic.py:99: got empty parameter set ('pass_f', 'rtrn_f', 'expected'), function test_pass_unique_ptr_disowns at /usr/local/google/home/rwgk/forked/pybind11/tests/test_class_sh_basic.py:98
SKIPPED [1] test_class_sh_basic.py:120: got empty parameter set ('pass_f', 'rtrn_f'), function test_cannot_disown_use_count_ne_1 at /usr/local/google/home/rwgk/forked/pybind11/tests/test_class_sh_basic.py:119
SKIPPED [1] test_class_sh_basic.py:145: BAKEIN_BREAK: AttributeError unique_ptr_roundtrip
SKIPPED [1] test_class_sh_basic.py:157: unconditional skip
SKIPPED [1] test_class_sh_basic.py:169: got empty parameter set ('pass_f', 'rtrn_f', 'moved_out', 'moved_in'), function test_unique_ptr_consumer_roundtrip at /usr/local/google/home/rwgk/forked/pybind11/tests/test_class_sh_basic.py:168
SKIPPED [1] test_class_sh_basic.py:210: BAKEIN_BREAK: AttributeError args_unique_ptr
====================================================== 17 passed, 8 skipped in 0.04s =======================================================```
2024-07-02 14:43:23 -07:00
Ralf W. Grosse-Kunstleve
b6171bc7ad
Bring in tests/test_class_sh_basic.cpp,py from smart_holder branch as-is (does not build).
2024-07-02 13:40:16 -07:00
Ralf W. Grosse-Kunstleve
66a775eee9
Replace BAKEIN_BREAK with BAKEIN_EXPECTED in test_smart_ptr_from_default().
2024-07-02 11:24:40 -07:00
Ralf W. Grosse-Kunstleve
f84be2e15a
Remove all BAKEIN_BREAK in test_pickling.cpp,py (tests pass without any production code changes).
2024-07-02 11:03:26 -07:00
Ralf W. Grosse-Kunstleve
107bcf9cb4
Bring in tests/pure_cpp/smart_holder_poc_test.cpp from smart_holder branch as-is.
2024-07-02 10:20:51 -07:00
Ralf W. Grosse-Kunstleve
6b89ca002e
test_class.cpp: transfer CHECK_SMART_HOLDER from smart_holder branch (replaces BAKEIN_BREAK).
2024-07-01 22:57:33 -07:00
Ralf W. Grosse-Kunstleve
6c227c7a90
Remove pytest.skip("BAKEIN_BREAK: ...") in test_class.py (not needed anymore).
2024-07-01 22:52:30 -07:00
Ralf W. Grosse-Kunstleve
b0cfeec63c
Merge branch 'master' into bakein
2024-07-01 21:51:36 -07:00
Ralf W. Grosse-Kunstleve
7de474f956
Add new include files to CMakeLists.txt, tests/extra_python_package/test_files.py
2024-07-01 18:09:19 -07:00
Ralf W. Grosse-Kunstleve
8254d77d70
Add pytest.skip("BAKEIN_BREAK: ...") in test_smart_ptr.py (all non-skipped tests pass locally with C++17).
2024-07-01 15:59:59 -07:00
Ralf W. Grosse-Kunstleve
c6a917eeae
Add make_some_type() to test_wip (reproduces Segmentation fault in test_class).
2024-06-30 14:09:19 -07:00
Ralf W. Grosse-Kunstleve
8fe75ff85b
Remove all (3) BAKEIN_BREAK from test_factory_constructors.cpp and all (4) BAKEIN_BREAK from test_factory_constructors.py (test_factory_constructors builds and runs successfully).
2024-06-30 11:41:03 -07:00
Michael Carlstrom
d805e9967f
feat(types) Adds special Case for empty C++ tuple type annotation ( #5214 )
...
* add special case and unit test
* add newline
2024-06-30 09:52:37 -07:00
Ralf W. Grosse-Kunstleve
33b0b387f1
Minimal reproducer for one of the test_factory_constructors.cpp build errors.
2024-06-29 16:13:47 -07:00
Ralf W. Grosse-Kunstleve
bcc3b87b8d
Comment out or skip: with this test_factory_constructors passes.
...
skip-checks: true
2024-06-29 15:10:42 -07:00
Ralf W. Grosse-Kunstleve
a1e312e13c
Comment out or skip: with this test_pickling passes.
2024-06-29 14:43:01 -07:00
Ralf W. Grosse-Kunstleve
9a88c09a31
Comment out or skip: with this test_class passes.
2024-06-29 14:39:08 -07:00
Ralf W. Grosse-Kunstleve
e5907480f5
Add py::class_<SomeType> with default ctor.
2024-06-29 11:09:03 -07:00
Ralf W. Grosse-Kunstleve
ced85c95b1
Add tests/test_wip.cpp,py (empty)
2024-06-29 11:04:19 -07:00
Michael Carlstrom
08f946a431
fix: add guard for GCC <10.3 on C++20 ( #5205 )
...
* Update CI
* update define guard
* style: pre-commit fixes
* updated define guard
* style: pre-commit fixes
* update guard
* testing new guards
* update guards
* surely this time
* style: pre-commit fixes
* Define PYBIND11_TYPING_H_HAS_STRING_LITERAL to avoid repeating a complex expression.
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ralf W. Grosse-Kunstleve <rwgk@google.com>
2024-06-27 22:20:28 -07:00
Michael Carlstrom
4bd538a40a
feat(types): add support for Typing.Callable Special Case ( #5202 )
...
* Add special case
* linty
2024-06-26 16:34:06 -04:00
Michael Carlstrom
2be85c6041
feat(types): adds support for TypeGuard and TypeIs ( #5194 )
...
* Adds support for TypeGuard and TypeIs
* style: pre-commit fixes
---------
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-25 22:53:15 -04:00
Michael Carlstrom
26281c7986
feat(types): adds support for Never and NoReturn from python Typing ( #5193 )
...
* Adds support for Never and NoReturn
* lint
2024-06-25 21:10:25 -04:00
Michael Carlstrom
183059f9a4
feat(types): add support for typing.Literal type ( #5192 )
...
* typevar prototype
* style: pre-commit fixes
* change to NameT
* style: pre-commit fixes
* make string const
* add missing closing bracket
* style: pre-commit fixes
* clean up handle_type_name
* style: pre-commit fixes
* add back missing <
* style: pre-commit fixes
* add back NameT
* try fixed_string
* style: pre-commit fixes
* std::basic_fixed_string
* test c++20
* style: pre-commit fixes
* cleanup
* fix object to typevar conversion
* style: pre-commit fixes
* And CPP20 checks
* style: pre-commit fixes
* add missing cpp20++ check
* style: pre-commit fixes
* Add C++20 check to python
* Fix python if {
* style: pre-commit fixes
* update test name
* style: pre-commit fixes
* remove call on cpp_std
* make field const
* test nontype_template
* update feature check
* update name of guard
* fix try except in test
* fix pre commit
* remove extra semi colon
* except AttributeError
* fix try except in test
* remove const
* Clean up tests
* style: pre-commit fixes
* start string literal
* start int literal
* func declare
* commit clean
* use contextlib.suppres
* resolve stash
* more literal type
* fix annotation name
* stash
* request changes
* lint
* Add comments
* style: pre-commit fixes
* Add support for unions and optionals to be compatible with object
* lint
* remove comment
* Create Literal Type implementation
* clean up
* Update comment
* remove incorrect comment
* rerun CI
* rerun CI
* fix extra line
* lint
* move if defined block
* style: pre-commit fixes
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-25 17:57:34 -04:00
Michael Carlstrom
aebcd704d2
Add TypeVars / method generics typing ( #5167 )
...
* typevar prototype
* style: pre-commit fixes
* change to NameT
* style: pre-commit fixes
* make string const
* add missing closing bracket
* style: pre-commit fixes
* clean up handle_type_name
* style: pre-commit fixes
* add back missing <
* style: pre-commit fixes
* add back NameT
* try fixed_string
* style: pre-commit fixes
* std::basic_fixed_string
* test c++20
* style: pre-commit fixes
* cleanup
* fix object to typevar conversion
* style: pre-commit fixes
* And CPP20 checks
* style: pre-commit fixes
* add missing cpp20++ check
* style: pre-commit fixes
* Add C++20 check to python
* Fix python if {
* style: pre-commit fixes
* update test name
* style: pre-commit fixes
* remove call on cpp_std
* make field const
* test nontype_template
* update feature check
* update name of guard
* fix try except in test
* fix pre commit
* remove extra semi colon
* except AttributeError
* fix try except in test
* remove const
* Clean up tests
* style: pre-commit fixes
* use contextlib.suppres
* request changes
* lint
* Add comments
* style: pre-commit fixes
* Add support for unions and optionals to be compatible with object
* lint
* remove comment
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-25 16:25:40 -04:00
Ralf W. Grosse-Kunstleve
a406a62e5b
fix: use std::addressof in type_caster_base.h ( #5189 )
...
* Add tests only. Fails to build with this error message:
```
g++ -o pybind11/tests/test_copy_move.os -c -std=c++17 -fPIC -fvisibility=hidden -O0 -g -Wall -Wextra -Wconversion -Wcast-qual -Wdeprecated -Wundef -Wnon-virtual-dtor -Wunused-result -Werror -isystem /usr/include/python3.11 -isystem /usr/include/eigen3 -DPYBIND11_STRICT_ASSERTS_CLASS_HOLDER_VS_TYPE_CASTER_MIX -DPYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD_IF_AVAILABLE -DPYBIND11_TEST_BOOST -DPYBIND11_INTERNALS_VERSION=10000000 -Ipybind11/include -I/usr/local/google/home/rwgk/forked/pybind11/include -I/usr/local/google/home/rwgk/clone/pybind11/include /usr/local/google/home/rwgk/forked/pybind11/tests/test_copy_move.cpp
In file included from /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../cast.h:15,
from /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../attr.h:14,
from /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/class.h:12,
from /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/pybind11.h:13,
from /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/stl.h:12,
from /usr/local/google/home/rwgk/forked/pybind11/tests/test_copy_move.cpp:11:
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h: In instantiation of ‘static pybind11::handle pybind11::detail::type_caster_base<type>::cast(const itype&, pybind11::return_value_policy, pybind11::handle) [with type = UnusualOpRef; itype = UnusualOpRef]’:
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../cast.h:1230:37: required from ‘pybind11::object pybind11::cast(T&&, return_value_policy, handle) [with T = const UnusualOpRef&; typename std::enable_if<(! std::is_base_of<detail::pyobject_tag, typename std::remove_reference<_Tp>::type>::value), int>::type <anonymous> = 0]’
/usr/local/google/home/rwgk/forked/pybind11/tests/test_copy_move.cpp:162:80: required from here
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1110:20: error: no matching function for call to ‘pybind11::detail::type_caster_base<UnusualOpRef>::cast(const UnusualOpRef::NonTrivialType, pybind11::return_value_policy&, pybind11::handle&)’
1110 | return cast(&src, policy, parent);
| ~~~~^~~~~~~~~~~~~~~~~~~~~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1105:19: note: candidate: ‘static pybind11::handle pybind11::detail::type_caster_base<type>::cast(const itype&, pybind11::return_value_policy, pybind11::handle) [with type = UnusualOpRef; itype = UnusualOpRef]’
1105 | static handle cast(const itype &src, return_value_policy policy, handle parent) {
| ^~~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1105:37: note: no known conversion for argument 1 from ‘const UnusualOpRef::NonTrivialType’ {aka ‘const std::shared_ptr<int>’} to ‘const pybind11::detail::type_caster_base<UnusualOpRef>::itype&’ {aka ‘const UnusualOpRef&’}
1105 | static handle cast(const itype &src, return_value_policy policy, handle parent) {
| ~~~~~~~~~~~~~^~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1113:19: note: candidate: ‘static pybind11::handle pybind11::detail::type_caster_base<type>::cast(itype&&, pybind11::return_value_policy, pybind11::handle) [with type = UnusualOpRef; itype = UnusualOpRef]’
1113 | static handle cast(itype &&src, return_value_policy, handle parent) {
| ^~~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1113:32: note: no known conversion for argument 1 from ‘const UnusualOpRef::NonTrivialType’ {aka ‘const std::shared_ptr<int>’} to ‘pybind11::detail::type_caster_base<UnusualOpRef>::itype&&’ {aka ‘UnusualOpRef&&’}
1113 | static handle cast(itype &&src, return_value_policy, handle parent) {
| ~~~~~~~~^~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1142:19: note: candidate: ‘static pybind11::handle pybind11::detail::type_caster_base<type>::cast(const itype*, pybind11::return_value_policy, pybind11::handle) [with type = UnusualOpRef; itype = UnusualOpRef]’
1142 | static handle cast(const itype *src, return_value_policy policy, handle parent) {
| ^~~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1142:37: note: no known conversion for argument 1 from ‘const UnusualOpRef::NonTrivialType’ {aka ‘const std::shared_ptr<int>’} to ‘const pybind11::detail::type_caster_base<UnusualOpRef>::itype*’ {aka ‘const UnusualOpRef*’}
1142 | static handle cast(const itype *src, return_value_policy policy, handle parent) {
| ~~~~~~~~~~~~~^~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h: In instantiation of ‘static pybind11::handle pybind11::detail::type_caster_base<type>::cast(itype&&, pybind11::return_value_policy, pybind11::handle) [with type = UnusualOpRef; itype = UnusualOpRef]’:
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../cast.h:1230:37: required from ‘pybind11::object pybind11::cast(T&&, return_value_policy, handle) [with T = UnusualOpRef; typename std::enable_if<(! std::is_base_of<detail::pyobject_tag, typename std::remove_reference<_Tp>::type>::value), int>::type <anonymous> = 0]’
/usr/local/google/home/rwgk/forked/pybind11/tests/test_copy_move.cpp:163:74: required from here
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1114:20: error: no matching function for call to ‘pybind11::detail::type_caster_base<UnusualOpRef>::cast(UnusualOpRef::NonTrivialType, pybind11::return_value_policy, pybind11::handle&)’
1114 | return cast(&src, return_value_policy::move, parent);
| ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1105:19: note: candidate: ‘static pybind11::handle pybind11::detail::type_caster_base<type>::cast(const itype&, pybind11::return_value_policy, pybind11::handle) [with type = UnusualOpRef; itype = UnusualOpRef]’
1105 | static handle cast(const itype &src, return_value_policy policy, handle parent) {
| ^~~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1105:37: note: no known conversion for argument 1 from ‘UnusualOpRef::NonTrivialType’ {aka ‘std::shared_ptr<int>’} to ‘const pybind11::detail::type_caster_base<UnusualOpRef>::itype&’ {aka ‘const UnusualOpRef&’}
1105 | static handle cast(const itype &src, return_value_policy policy, handle parent) {
| ~~~~~~~~~~~~~^~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1113:19: note: candidate: ‘static pybind11::handle pybind11::detail::type_caster_base<type>::cast(itype&&, pybind11::return_value_policy, pybind11::handle) [with type = UnusualOpRef; itype = UnusualOpRef]’
1113 | static handle cast(itype &&src, return_value_policy, handle parent) {
| ^~~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1113:32: note: no known conversion for argument 1 from ‘UnusualOpRef::NonTrivialType’ {aka ‘std::shared_ptr<int>’} to ‘pybind11::detail::type_caster_base<UnusualOpRef>::itype&&’ {aka ‘UnusualOpRef&&’}
1113 | static handle cast(itype &&src, return_value_policy, handle parent) {
| ~~~~~~~~^~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1142:19: note: candidate: ‘static pybind11::handle pybind11::detail::type_caster_base<type>::cast(const itype*, pybind11::return_value_policy, pybind11::handle) [with type = UnusualOpRef; itype = UnusualOpRef]’
1142 | static handle cast(const itype *src, return_value_policy policy, handle parent) {
| ^~~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:1142:37: note: no known conversion for argument 1 from ‘UnusualOpRef::NonTrivialType’ {aka ‘std::shared_ptr<int>’} to ‘const pybind11::detail::type_caster_base<UnusualOpRef>::itype*’ {aka ‘const UnusualOpRef*’}
1142 | static handle cast(const itype *src, return_value_policy policy, handle parent) {
| ~~~~~~~~~~~~~^~~
```
* Replace `&src` with `std::addressof(src)` to fix the error building the added tests.
* Fix accident (not sure how the `const` slipped in here when transferring the diff from pybind11k).
2024-06-24 08:59:55 -07:00
