Aaron Gokaslan
f8d4aa47b6
Add clang-tidy readability checks for sus args ( #3611 )
2022-01-11 17:34:16 -08:00
Aaron Gokaslan
ae07d4c6c6
maint(Clang-Tidy): readability-const-return ( #3254 )
...
* Enable clang-tidy readability-const-return
* PyTest functional
* Fix regression
* Fix actual regression
* Remove one more NOLINT
* Update comment
2021-09-09 21:27:36 -07:00
Ralf W. Grosse-Kunstleve
6abf2baa62
CodeHealth: Enabling clang-tidy google-explicit-constructor ( #3250 )
...
* Adding google-explicit-constructor to .clang-tidy
* clang-tidy explicit attr.h (all automatic)
* clang-tidy explicit cast.h (all automatic)
* clang-tidy detail/init.h (1 NOLINT)
* clang-tidy detail/type_caster_base.h (2 NOLINT)
* clang-tidy pybind11.h (7 NOLINT)
* clang-tidy detail/common.h (3 NOLINT)
* clang-tidy detail/descr.h (2 NOLINT)
* clang-tidy pytypes.h (23 NOLINT, only 1 explicit)
* clang-tidy eigen.h (7 NOLINT, 0 explicit)
* Adding 2 explicit in functional.h
* Adding 4 explicit in iostream.h
* clang-tidy numpy.h (1 NOLINT, 1 explicit)
* clang-tidy embed.h (0 NOLINT, 1 explicit)
* clang-tidy tests/local_bindings.h (0 NOLINT, 4 explicit)
* clang-tidy tests/pybind11_cross_module_tests.cpp (0 NOLINT, 1 explicit)
* clang-tidy tests/pybind11_tests.h (0 NOLINT, 2 explicit)
* clang-tidy tests/test_buffers.cpp (0 NOLINT, 2 explicit)
* clang-tidy tests/test_builtin_casters.cpp (0 NOLINT, 4 explicit)
* clang-tidy tests/test_class.cpp (0 NOLINT, 6 explicit)
* clang-tidy tests/test_copy_move.cpp (0 NOLINT, 7 explicit)
* clang-tidy tests/test_embed/external_module.cpp (0 NOLINT, 1 explicit)
* clang-tidy tests/test_embed/test_interpreter.cpp (0 NOLINT, 1 explicit)
* clang-tidy tests/object.h (0 NOLINT, 2 explicit)
* clang-tidy batch of fully automatic fixes.
* Workaround for MSVC 19.16.27045.0 C++17 Python 2 C++ syntax error.
2021-09-08 18:53:38 -07:00
Aaron Gokaslan
6cbabc4b8c
maint(clang-tidy): Enable cpp-coreguideline slicing checks ( #3210 )
...
* maint(clang-tidy): add a clang-tidy slicing check
* Add self + touch up readme
* Fix typo
2021-08-23 18:42:19 -04:00
Aaron Gokaslan
3893f37bce
maint(clang-tidy): Bugprone enable checks ( #3166 )
...
* Enable bugprone checks
* Reset delta and massage config
* Start to apply bugprone fixes
* try to fix minor bug
* Fix later
* Fix perfect forwarding bugprone
* Remove nolint
* undo constructor delete
* Fix bugprone-perfect-forwarding again
* Remove TODO
* Add another nolint for bugprone-exception-escape in scoped interpreter
* Fix remaining bugprone errors
* Properly apply bugprone-macro-parantheses
* Redo formatting and remove bugprone nolint
* Add coment and revert more whitespace changes
* Fix typo
* Fix parsing bug
* Add back comma
* Fix clang-tidy issue
* Apply remaining clang-tidy fixes
2021-08-06 14:30:28 -04:00
Aaron Gokaslan
9beaa925db
maint(clang-tidy): Improve code readability with explicit boolean casts ( #3148 )
...
* maint(clang-tidy) Improve code readability
* Fix minor typos
* Revert optimization that removed test case
* Fix comment formatting
* Revert another optimization to repro an issue
* Remove make_unique since it C++14 and newer only
* eformat comments
* Fix unsignedness of comparison
* Update comment
2021-07-27 15:32:26 -07:00
Aaron Gokaslan
25e470c57d
fix(clang-tidy): Add cppcoreguidelines-init-vars,slicing, and throw-by-value-catch-by-reference checks ( #3094 )
...
* clang-tidy: guard against more UB behavior
* Remove slicing check for now
2021-07-13 09:54:32 -04:00
Aaron Gokaslan
b5357d1fa8
fix(clang-tidy): Enable clang-tidy else-after-return and redundant void checks ( #3080 )
...
* Enable clang-tidy else-after-return and redundant void checks
* Fix remaining else-after
* Address reviewer comments
* Fix indentation
* Rerun clang-tidy post merge
2021-07-09 06:45:53 -07:00
Aaron Gokaslan
dac74ebdf5
fix(clang-tidy): performance fixes applied in tests and CI ( #3051 )
...
* Initial fixes
* Whoops
* Finish clang-tidy manual fixes
* Add two missing fixes
* Revert
* Update clang-tidy
* Try to fix unreachable code error
* Move nolint comment
* Apply missing fix
* Don't override clang-tidy config
* Does this fix clang-tidy?
* Make all clang-tidy errors visible
* Add comments about NOLINTs and remove a few
* Fix typo
2021-06-22 12:11:54 -04:00
Aaron Gokaslan
3b30b0a51e
fix(clang-tidy): clang-tidy readability and misc fixes, like adding const ( #3052 )
...
* Enable and apply clang-tidy readability and misc fixes.
* Revert deprecated tester
* add space to tests/test_constants_and_functions.cpp
2021-06-21 10:37:48 -04:00
Aaron Gokaslan
e0b5cbd4c6
chore(clang-tidy): add more modernize clang-tidy checks ( #3049 )
...
* Add more modernize clang-tidy checks
* Enable a few more
2021-06-19 18:38:56 -04:00
Aaron Gokaslan
af6218ff78
fix(clang-tidy): Apply performance fixes from clang-tidy ( #3046 )
...
* Apply performance fixes from clang-tidy
* 2nd Round of Perf Optimizations
* 3rd round of fixes & handle false-positive
* Apply missing fix and clang-format
* Apply reviewer comment
2021-06-19 10:53:27 -07:00
Henry Schreiner
e7bafc8ec1
style: clang-tidy: default checks and fix bug in iostream deconstruction
...
```
/pybind11/include/pybind11/iostream.h:71:9: warning: Call to virtual method 'pythonbuf::sync' during destruction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]
sync();
^
/pybind11/tests/test_iostream.cpp:72:5: note: Calling '~scoped_ostream_redirect'
});
```
2020-09-15 09:56:59 -04:00
Henry Schreiner
4d78640830
style: clang-tidy: modernize-use-emplace
2020-09-15 09:56:59 -04:00
Henry Schreiner
ce88e940ce
style: clang-tidy: modernize-use-auto
2020-09-15 09:56:59 -04:00
Henry Schreiner
b491b465c7
style: clang-tidy: modernize-use-equals-default
2020-09-15 09:56:59 -04:00
Henry Schreiner
b342c37388
style: clang-tidy: modernize-use-using
2020-09-15 09:56:59 -04:00
Henry Schreiner
96e6a8d554
style: clang-tidy: readability-container-size-empty
2020-09-15 09:56:59 -04:00
Henry Schreiner
5dfbe6f903
style: clang-tidy: modernize-use-override
2020-09-15 09:56:59 -04:00
Henry Schreiner
8dc31c7b29
style: clang-tidy: llvm-namespace-comment
2020-09-15 09:56:59 -04:00
