Merge 20f37d8ff8 into 1f8b4a7f1a

fix(cmake): NO_EXTRAS in pybind11_add_module function partially working (#5378 )
fix docs build command on different global and venv python versions
2024-11-11 08:03:55 +00:00 · 2024-09-20 11:23:43 +09:00 · 2024-09-19 11:24:35 -04:00 · 2024-09-08 13:08:53 +01:00
2 changed files with 1 additions and 5 deletions
--- a/docs/basics.rst
+++ b/docs/basics.rst
@ -142,7 +142,7 @@ On Linux, the above example can be compiled using the following command:

 .. code-block:: bash

-    $ c++ -O3 -Wall -shared -std=c++11 -fPIC $(python3 -m pybind11 --includes) example.cpp -o example$(python3-config --extension-suffix)
+    $ c++ -O3 -Wall -shared -std=c++11 -fPIC $(python3 -m pybind11 --includes) example.cpp -o example$(python3 -c 'import sysconfig; print(sysconfig.get_config_var("EXT_SUFFIX"))')

 .. note::

--- a/tools/pybind11NewTools.cmake
+++ b/tools/pybind11NewTools.cmake
@ -274,10 +274,6 @@ function(pybind11_add_module target_name)
    target_link_libraries(${target_name} PRIVATE pybind11::embed)
  endif()

-  if(MSVC)
-    target_link_libraries(${target_name} PRIVATE pybind11::windows_extras)
-  endif()
-
  # -fvisibility=hidden is required to allow multiple modules compiled against
  # different pybind versions to work properly, and for some features (e.g.
  # py::module_local).  We force it on everything inside the `pybind11`
Author	SHA1	Message	Date
Nikul Patel	5674530160	Merge `20f37d8ff8` into `1f8b4a7f1a`	2024-09-20 11:23:43 +09:00
Hintay	1f8b4a7f1a	fix(cmake): `NO_EXTRAS` in `pybind11_add_module` function partially working (#5378 )	2024-09-19 11:24:35 -04:00
Nikul Patel	20f37d8ff8	fix docs build command on different global and venv python versions	2024-09-08 13:08:53 +01:00