Error if _GLIBCXX_USE_CXX11_ABI is not defined

Within the `__GXX_ABI_VERSION` block this should always be defined, guard against unexpected defines and make the error obvious.
Use gxx_abi_1xxx and simplify the Clang string
2024-11-22 05:05:11 +00:00 · 2024-11-20 20:10:08 -05:00 · 2024-11-20 19:47:52 -05:00 · 2024-11-20 21:39:53 +00:00 · 2024-11-20 16:37:16 -05:00
1 changed files with 6 additions and 3 deletions
--- a/include/pybind11/conduit/pybind11_platform_abi_id.h
+++ b/include/pybind11/conduit/pybind11_platform_abi_id.h
@ -73,11 +73,14 @@
 #    elif defined(__NVCOMPILER)        // NVHPC (PGI-based).
 #        define PYBIND11_BUILD_ABI ""  // TODO: What should be here, to prevent UB?
 #    elif defined(_LIBCPP_ABI_VERSION) // https://libcxx.llvm.org/DesignDocs/ABIVersioning.html
-#        define PYBIND11_BUILD_ABI "_libcpp" PYBIND11_PLATFORM_ABI_ID_TOSTRING(_LIBCPP_ABI_VERSION)
+#        define PYBIND11_BUILD_ABI "_abi" PYBIND11_PLATFORM_ABI_ID_TOSTRING(_LIBCPP_ABI_VERSION)
 #    elif defined(__GXX_ABI_VERSION)
-#        if __GXX_ABI_VERSION >= 1002 && defined(_GLIBCXX_USE_CXX11_ABI)
+#        if __GXX_ABI_VERSION >= 1002 && __GXX_ABI_VERSION < 2000
+#            if !defined(_GLIBCXX_USE_CXX11_ABI)
+#                error "UNEXPECTED: _GLIBCXX_USE_CXX11_ABI not defined"
+#            endif
 #            define PYBIND11_BUILD_ABI                                                            \
-                "_usecxx11" PYBIND11_PLATFORM_ABI_ID_TOSTRING(_GLIBCXX_USE_CXX11_ABI)
+                "_gxx_abi_1xxx_usecxx11_" PYBIND11_PLATFORM_ABI_ID_TOSTRING(_GLIBCXX_USE_CXX11_ABI)
 #        else
 #            error "Unknown platform or compiler (__GXX_ABI_VERSION): PLEASE REVISE THIS CODE."
 #        endif
Author	SHA1	Message	Date
Marcus D. Hanwell	271720fde9	Error if `_GLIBCXX_USE_CXX11_ABI` is not defined Within the `__GXX_ABI_VERSION` block this should always be defined, guard against unexpected defines and make the error obvious.	2024-11-20 20:10:08 -05:00
Marcus D. Hanwell	476c322fec	Use `gxx_abi_1xxx` and simplify the Clang string After discussions with Ralf Grosse-Kunstleve we think these would make good identifiers that are concise and clear.	2024-11-20 19:47:52 -05:00
pre-commit-ci[bot]	8369fdce4b	style: pre-commit fixes	2024-11-20 21:39:53 +00:00
Marcus D. Hanwell	b72c42d489	Include GXX_ABI and USE_CXX in the identifier Further constrain to GXX_ABI 1002 or greater and less than 2000, hopefully future proof by summarizing that as `1` along with CXX11 on or off.	2024-11-20 16:37:16 -05:00