mirror of
https://github.com/pybind/pybind11.git
synced 2025-03-25 18:07:43 +00:00
* Pure `git merge --squash smart_holder` (no manual interventions). * Remove ubench/ directory. * Remove include/pybind11/smart_holder.h * [ci skip] smart_ptrs.rst updates [WIP/unfinished] * [ci skip] smart_ptrs.rst updates continued; also updating classes.rst, advanced/classes.rst * Remove README_smart_holder.rst * Restore original README.rst from master * [ci skip] Minimal change to README.rst, to leave a hint that this is pybind11v3 * [ci skip] Work in ChatGPT suggestions. * Change macro name to PYBIND11_RUN_TESTING_WITH_SMART_HOLDER_AS_DEFAULT_BUT_NEVER_USE_IN_PRODUCTION_PLEASE * Add a note pointing to the holder reinterpret_cast. * Incorporate suggestion by @virtuald: https://github.com/pybind/pybind11/pull/5542#discussion_r1967000989 * Systematically change most py::class_ to py::classh under docs/ * Remove references to README_smart_holder.rst This should have been part of commiteb550d03d3
. * [ci skip] Fix minor oversight (``class_`` -> ``py::class_``) noticed by chance. * [ci skip] Resolve suggestion by @virtuald https://github.com/pybind/pybind11/pull/5542#discussion_r1969940605 * [ci skip] Apply suggestions by @timohl (thanks!) * https://github.com/pybind/pybind11/pull/5542#discussion_r1970714551 * https://github.com/pybind/pybind11/pull/5542#discussion_r1971315329 * https://github.com/pybind/pybind11/pull/5542#discussion_r1971322821 * Replace `classh : class_` inhertance with `using`, as suggested by @henryiii https://github.com/pybind/pybind11/pull/5542#issuecomment-2689034104 * Revert "Systematically change most py::class_ to py::classh under docs/" This reverts commitac9d31e13f
. * docs: focus on py::smart_holder instead of py::classh Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> * Restore minor general fixes that got lost whenac9d31e13f
was reverted. * Remove `- smart_holder` from list of branches in all .github/workflows * Extend classh note to explain whitespace noise motivation. * Suggest `py::smart_holder` for "most situations for safety" * Add back PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT This define was * introduced with https://github.com/pybind/pybind11/pull/5286 * removed with https://github.com/pybind/pybind11/pull/5531 It is has been in use here: *f02a2b7653/pybind11_protobuf/native_proto_caster.h (L89-L101)
Currently pybind11 unit tests for the two holder caster backwards compatibility traits * `copyable_holder_caster_shared_ptr_with_smart_holder_support_enabled` * `move_only_holder_caster_unique_ptr_with_smart_holder_support_enabled` are missing. * Add py::trampoline_self_life_support to all trampoline examples under docs/. Address suggestion by @timohl: * https://github.com/pybind/pybind11/pull/5542#issuecomment-2686452062 Add to the "please think twice" note: the overhead for safety is likely in the noise. Also fix a two-fold inconsistency introduced by revert-commit1e646c91b4
: 1. py::trampoline_self_life_support is mentioned in a note, but is missing in the example right before. 2. The section starting with To enable safely passing a ``std::unique_ptr`` to a trampoline object between is obsolete. * Fix whitespace accident (indentation) introduced with1e646c91b4
Apparently the mis-indentation was introduced when resolving merge conflicts for what became1e646c91b4
* WHITESPACE CHANGES ONLY in README.rst (list of people that made significant contributions) * Add Ethan Steinberg to list of people that made significant contributions (for completeness, unrelated to smart_holder work). * [ci skip] Add to list of people that made significant contributions: major and/or influential contributors to smart_holder branch * #2904 by @rhaschke was merged on Mar 16, 2021 * #3012 by @rhaschke was merged on May 28, 2021 * #3039 by @jakobandersen was merged on Jun 29, 2021 * #3048 by @Skylion007 was merged on Jun 18, 2021 * #3588 by @virtuald was merged on Jan 3, 2022 * #3633 by @wangxf123456 was merged on Jan 25, 2022 * #3635 by @virtuald was merged on Jan 26, 2022 * #3645 by @wangxf123456 was merged on Jan 25, 2022 * #3796 by @wangxf123456 was merged on Mar 10, 2022 * #3807 by @wangxf123456 was merged on Mar 18, 2022 * #3838 by @wangxf123456 was merged on Apr 15, 2022 * #3929 by @tomba was merged on May 7, 2022 * #4031 by @wangxf123456 was merged on Jun 27, 2022 * #4343 by @wangxf123456 was merged on Nov 18, 2022 * #4381 by @wangxf123456 was merged on Dec 5, 2022 * #4539 by @wangxf123456 was merged on Feb 28, 2023 * #4609 by @wangxf123456 was merged on Apr 6, 2023 * #4775 by @wangxf123456 was merged on Aug 3, 2023 * #4921 by @iwanders was merged on Nov 7, 2023 * #4924 by @iwanders was merged on Nov 6, 2023 * #5401 by @msimacek was merged on Oct 8, 2024 Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> Co-authored-by: Dustin Spicuzza <dustin@virtualroadside.com> Co-authored-by: Ivor Wanders <iwanders@users.noreply.github.com> Co-authored-by: Jakob Lykke Andersen <Jakob@caput.dk> Co-authored-by: Michael Šimáček <michael.simacek@oracle.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> Co-authored-by: Tomi Valkeinen <tomi.valkeinen@iki.fi> Co-authored-by: Xiaofei Wang <6218006+wangxf123456@users.noreply.github.com> --------- Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> Co-authored-by: Henry Schreiner <henryschreineriii@gmail.com> Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> Co-authored-by: Dustin Spicuzza <dustin@virtualroadside.com> Co-authored-by: Ivor Wanders <iwanders@users.noreply.github.com> Co-authored-by: Jakob Lykke Andersen <Jakob@caput.dk> Co-authored-by: Michael Šimáček <michael.simacek@oracle.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> Co-authored-by: Tomi Valkeinen <tomi.valkeinen@iki.fi> Co-authored-by: Xiaofei Wang <6218006+wangxf123456@users.noreply.github.com>
91 lines
3.2 KiB
C++
91 lines
3.2 KiB
C++
#include "pybind11_tests.h"
|
|
|
|
#include <memory>
|
|
|
|
namespace pybind11_tests {
|
|
namespace class_sh_inheritance {
|
|
|
|
template <int Id>
|
|
struct base_template {
|
|
base_template() : base_id(Id) {}
|
|
virtual ~base_template() = default;
|
|
virtual int id() const { return base_id; }
|
|
int base_id;
|
|
|
|
// Some compilers complain about implicitly defined versions of some of the following:
|
|
base_template(const base_template &) = default;
|
|
base_template(base_template &&) noexcept = default;
|
|
base_template &operator=(const base_template &) = default;
|
|
base_template &operator=(base_template &&) noexcept = default;
|
|
};
|
|
|
|
using base = base_template<100>;
|
|
|
|
struct drvd : base {
|
|
int id() const override { return 2 * base_id; }
|
|
};
|
|
|
|
// clang-format off
|
|
inline drvd *rtrn_mptr_drvd() { return new drvd; }
|
|
inline base *rtrn_mptr_drvd_up_cast() { return new drvd; }
|
|
|
|
inline int pass_cptr_base(base const *b) { return b->id() + 11; }
|
|
inline int pass_cptr_drvd(drvd const *d) { return d->id() + 12; }
|
|
|
|
inline std::shared_ptr<drvd> rtrn_shmp_drvd() { return std::make_shared<drvd>(); }
|
|
inline std::shared_ptr<base> rtrn_shmp_drvd_up_cast() { return std::make_shared<drvd>(); }
|
|
|
|
inline int pass_shcp_base(const std::shared_ptr<base const>& b) { return b->id() + 21; }
|
|
inline int pass_shcp_drvd(const std::shared_ptr<drvd const>& d) { return d->id() + 22; }
|
|
// clang-format on
|
|
|
|
using base1 = base_template<110>;
|
|
using base2 = base_template<120>;
|
|
|
|
// Not reusing base here because it would interfere with the single-inheritance test.
|
|
struct drvd2 : base1, base2 {
|
|
int id() const override { return 3 * base1::base_id + 4 * base2::base_id; }
|
|
};
|
|
|
|
// clang-format off
|
|
inline drvd2 *rtrn_mptr_drvd2() { return new drvd2; }
|
|
inline base1 *rtrn_mptr_drvd2_up_cast1() { return new drvd2; }
|
|
inline base2 *rtrn_mptr_drvd2_up_cast2() { return new drvd2; }
|
|
|
|
inline int pass_cptr_base1(base1 const *b) { return b->id() + 21; }
|
|
inline int pass_cptr_base2(base2 const *b) { return b->id() + 22; }
|
|
inline int pass_cptr_drvd2(drvd2 const *d) { return d->id() + 23; }
|
|
// clang-format on
|
|
|
|
TEST_SUBMODULE(class_sh_inheritance, m) {
|
|
py::classh<base>(m, "base");
|
|
py::classh<drvd, base>(m, "drvd");
|
|
|
|
auto rvto = py::return_value_policy::take_ownership;
|
|
|
|
m.def("rtrn_mptr_drvd", rtrn_mptr_drvd, rvto);
|
|
m.def("rtrn_mptr_drvd_up_cast", rtrn_mptr_drvd_up_cast, rvto);
|
|
m.def("pass_cptr_base", pass_cptr_base);
|
|
m.def("pass_cptr_drvd", pass_cptr_drvd);
|
|
|
|
m.def("rtrn_shmp_drvd", rtrn_shmp_drvd);
|
|
m.def("rtrn_shmp_drvd_up_cast", rtrn_shmp_drvd_up_cast);
|
|
m.def("pass_shcp_base", pass_shcp_base);
|
|
m.def("pass_shcp_drvd", pass_shcp_drvd);
|
|
|
|
// __init__ needed for Python inheritance.
|
|
py::classh<base1>(m, "base1").def(py::init<>());
|
|
py::classh<base2>(m, "base2").def(py::init<>());
|
|
py::classh<drvd2, base1, base2>(m, "drvd2");
|
|
|
|
m.def("rtrn_mptr_drvd2", rtrn_mptr_drvd2, rvto);
|
|
m.def("rtrn_mptr_drvd2_up_cast1", rtrn_mptr_drvd2_up_cast1, rvto);
|
|
m.def("rtrn_mptr_drvd2_up_cast2", rtrn_mptr_drvd2_up_cast2, rvto);
|
|
m.def("pass_cptr_base1", pass_cptr_base1);
|
|
m.def("pass_cptr_base2", pass_cptr_base2);
|
|
m.def("pass_cptr_drvd2", pass_cptr_drvd2);
|
|
}
|
|
|
|
} // namespace class_sh_inheritance
|
|
} // namespace pybind11_tests
|