mirror of
https://github.com/pybind/pybind11.git
synced 2025-01-30 23:02:37 +00:00
15d9dae14b
* Fix data race when using shared variables (free threading)
In the free threading build, there's a race between wrapper re-use and
wrapper deallocation. This can happen with a static variable accessed by
multiple threads.
Fixing this requires using some private CPython APIs: _Py_TryIncref and
_PyObject_SetMaybeWeakref. The implementations of these functions are
included until they're made available as public ("unstable") APIs.
Fixes #5489
* style: pre-commit fixes
* Avoid unused parameter
* Add missing return for default build
* Changes from review
* Assign result to local variable
* s/clang-tidy/ruff
* clang-tidy: static is redundant
* Use 'noqa: B018'
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
73 lines
2.0 KiB
C++
73 lines
2.0 KiB
C++
/*
|
|
tests/test_thread.cpp -- call pybind11 bound methods in threads
|
|
|
|
Copyright (c) 2021 Laramie Leavitt (Google LLC) <lar@google.com>
|
|
|
|
All rights reserved. Use of this source code is governed by a
|
|
BSD-style license that can be found in the LICENSE file.
|
|
*/
|
|
|
|
#include <pybind11/cast.h>
|
|
#include <pybind11/pybind11.h>
|
|
|
|
#include "pybind11_tests.h"
|
|
|
|
#include <chrono>
|
|
#include <thread>
|
|
|
|
namespace py = pybind11;
|
|
|
|
namespace {
|
|
|
|
struct IntStruct {
|
|
explicit IntStruct(int v) : value(v) {};
|
|
~IntStruct() { value = -value; }
|
|
IntStruct(const IntStruct &) = default;
|
|
IntStruct &operator=(const IntStruct &) = default;
|
|
|
|
int value;
|
|
};
|
|
|
|
struct EmptyStruct {};
|
|
EmptyStruct SharedInstance;
|
|
|
|
} // namespace
|
|
|
|
TEST_SUBMODULE(thread, m) {
|
|
|
|
py::class_<IntStruct>(m, "IntStruct").def(py::init([](const int i) { return IntStruct(i); }));
|
|
|
|
// implicitly_convertible uses loader_life_support when an implicit
|
|
// conversion is required in order to lifetime extend the reference.
|
|
//
|
|
// This test should be run with ASAN for better effectiveness.
|
|
py::implicitly_convertible<int, IntStruct>();
|
|
|
|
m.def("test", [](int expected, const IntStruct &in) {
|
|
{
|
|
py::gil_scoped_release release;
|
|
std::this_thread::sleep_for(std::chrono::milliseconds(5));
|
|
}
|
|
|
|
if (in.value != expected) {
|
|
throw std::runtime_error("Value changed!!");
|
|
}
|
|
});
|
|
|
|
m.def(
|
|
"test_no_gil",
|
|
[](int expected, const IntStruct &in) {
|
|
std::this_thread::sleep_for(std::chrono::milliseconds(5));
|
|
if (in.value != expected) {
|
|
throw std::runtime_error("Value changed!!");
|
|
}
|
|
},
|
|
py::call_guard<py::gil_scoped_release>());
|
|
|
|
py::class_<EmptyStruct>(m, "EmptyStruct")
|
|
.def_readonly_static("SharedInstance", &SharedInstance);
|
|
|
|
// NOTE: std::string_view also uses loader_life_support to ensure that
|
|
// the string contents remain alive, but that's a C++ 17 feature.
|
|
}
|