mirror of https://github.com/pybind/pybind11.git
e9b961d9b9
* Reproducer for property setter with return type that is not wrapped.
* Use `py::class_<OptionsBase>()` to work around the return value conversion issue.
* WIP drop_return_value
* Remove struct drop_return_value
* Introduce `return_value_policy::return_none` for use by setters.
* Add `is_setter` to attr.h and use from `.def_property()`
* Merge the new test into test_methods_and_attributes
* Remove return_none return_value_policy again.
* Fix oversight (NOLINTNEXTLINE placement).
* Simplification (for the better) found while searching for a way to resolve GCC build failures.
Example of failure resolved by this change:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
```
cd /build/tests && /usr/bin/c++ -DPYBIND11_TEST_EIGEN -Dpybind11_tests_EXPORTS -I/mounted_pybind11/include -isystem /usr/include/python3.8 -isystem /build/_deps/eigen-src -g -std=c++17 -fPIC -fvisibility=hidden -Wall -Wextra -Wconversion -Wcast-qual -Wdeprecated -Wundef -Wnon-virtual-dtor -MD -MT tests/CMakeFiles/pybind11_tests.dir/test_buffers.cpp.o -MF CMakeFiles/pybind11_tests.dir/test_buffers.cpp.o.d -o CMakeFiles/pybind11_tests.dir/test_buffers.cpp.o -c /mounted_pybind11/tests/test_buffers.cpp
In file included from /mounted_pybind11/include/pybind11/stl.h:12,
from /mounted_pybind11/tests/test_buffers.cpp:10:
/mounted_pybind11/include/pybind11/pybind11.h: In instantiation of ‘pybind11::class_<type_, options>& pybind11::class_<type_, options>::def_property(const char*, const Getter&, const Setter&, const Extra& ...) [with Getter = pybind11::cpp_function; Setter = std::nullptr_t; Extra = {pybind11::return_value_policy}; type_ = pybind11::buffer_info; options = {}]’:
/mounted_pybind11/include/pybind11/pybind11.h:1716:58: required from ‘pybind11::class_<type_, options>& pybind11::class_<type_, options>::def_property_readonly(const char*, const pybind11::cpp_function&, const Extra& ...) [with Extra = {pybind11::return_value_policy}; type_ = pybind11::buffer_info; options = {}]’
/mounted_pybind11/include/pybind11/pybind11.h:1684:9: required from ‘pybind11::class_<type_, options>& pybind11::class_<type_, options>::def_readonly(const char*, const D C::*, const Extra& ...) [with C = pybind11::buffer_info; D = long int; Extra = {}; type_ = pybind11::buffer_info; options = {}]’
/mounted_pybind11/tests/test_buffers.cpp:209:61: required from here
/mounted_pybind11/include/pybind11/pybind11.h:1740:25: error: call of overloaded ‘cpp_function(std::nullptr_t&, pybind11::is_setter)’ is ambiguous
1740 | name, fget, cpp_function(method_adaptor<type>(fset), is_setter()), extra...);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/mounted_pybind11/include/pybind11/pybind11.h:101:5: note: candidate: ‘pybind11::cpp_function::cpp_function(Func&&, const Extra& ...) [with Func = std::nullptr_t&; Extra = {pybind11::is_setter}; <template-parameter-1-3> = void]’
101 | cpp_function(Func &&f, const Extra &...extra) {
| ^~~~~~~~~~~~
In file included from /mounted_pybind11/include/pybind11/stl.h:12,
from /mounted_pybind11/tests/test_buffers.cpp:10:
/mounted_pybind11/include/pybind11/pybind11.h:87:5: note: candidate: ‘pybind11::cpp_function::cpp_function(std::nullptr_t, const Extra& ...) [with Extra = {pybind11::is_setter}; std::nullptr_t = std::nullptr_t]’
87 | cpp_function(std::nullptr_t, const Extra &...) {}
| ^~~~~~~~~~~~
```
* Bug fix: obvious in hindsight. I thought the original version was incrementing the reference count for None, but no.
Discovered via many failing tests in the wild (10s of thousands).
It is very tricky to construct a meaningful unit test for this bug specifically. It's unlikely to come back, because 10s of thousands of tests will fail again.
|
||
|---|---|---|
| .. | ||
| extra_python_package | ||
| extra_setuptools | ||
| test_cmake_build | ||
| test_embed | ||
| CMakeLists.txt | ||
| conftest.py | ||
| constructor_stats.h | ||
| cross_module_gil_utils.cpp | ||
| cross_module_interleaved_error_already_set.cpp | ||
| eigen_tensor_avoid_stl_array.cpp | ||
| env.py | ||
| local_bindings.h | ||
| object.h | ||
| pybind11_cross_module_tests.cpp | ||
| pybind11_tests.cpp | ||
| pybind11_tests.h | ||
| pytest.ini | ||
| requirements.txt | ||
| test_async.cpp | ||
| test_async.py | ||
| test_buffers.cpp | ||
| test_buffers.py | ||
| test_builtin_casters.cpp | ||
| test_builtin_casters.py | ||
| test_call_policies.cpp | ||
| test_call_policies.py | ||
| test_callbacks.cpp | ||
| test_callbacks.py | ||
| test_chrono.cpp | ||
| test_chrono.py | ||
| test_class.cpp | ||
| test_class.py | ||
| test_const_name.cpp | ||
| test_const_name.py | ||
| test_constants_and_functions.cpp | ||
| test_constants_and_functions.py | ||
| test_copy_move.cpp | ||
| test_copy_move.py | ||
| test_custom_type_casters.cpp | ||
| test_custom_type_casters.py | ||
| test_custom_type_setup.cpp | ||
| test_custom_type_setup.py | ||
| test_docstring_options.cpp | ||
| test_docstring_options.py | ||
| test_eigen_matrix.cpp | ||
| test_eigen_matrix.py | ||
| test_eigen_tensor.cpp | ||
| test_eigen_tensor.inl | ||
| test_eigen_tensor.py | ||
| test_enum.cpp | ||
| test_enum.py | ||
| test_eval.cpp | ||
| test_eval.py | ||
| test_eval_call.py | ||
| test_exceptions.cpp | ||
| test_exceptions.h | ||
| test_exceptions.py | ||
| test_factory_constructors.cpp | ||
| test_factory_constructors.py | ||
| test_gil_scoped.cpp | ||
| test_gil_scoped.py | ||
| test_iostream.cpp | ||
| test_iostream.py | ||
| test_kwargs_and_defaults.cpp | ||
| test_kwargs_and_defaults.py | ||
| test_local_bindings.cpp | ||
| test_local_bindings.py | ||
| test_methods_and_attributes.cpp | ||
| test_methods_and_attributes.py | ||
| test_modules.cpp | ||
| test_modules.py | ||
| test_multiple_inheritance.cpp | ||
| test_multiple_inheritance.py | ||
| test_numpy_array.cpp | ||
| test_numpy_array.py | ||
| test_numpy_dtypes.cpp | ||
| test_numpy_dtypes.py | ||
| test_numpy_vectorize.cpp | ||
| test_numpy_vectorize.py | ||
| test_opaque_types.cpp | ||
| test_opaque_types.py | ||
| test_operator_overloading.cpp | ||
| test_operator_overloading.py | ||
| test_pickling.cpp | ||
| test_pickling.py | ||
| test_pytypes.cpp | ||
| test_pytypes.py | ||
| test_sequences_and_iterators.cpp | ||
| test_sequences_and_iterators.py | ||
| test_smart_ptr.cpp | ||
| test_smart_ptr.py | ||
| test_stl.cpp | ||
| test_stl.py | ||
| test_stl_binders.cpp | ||
| test_stl_binders.py | ||
| test_tagbased_polymorphic.cpp | ||
| test_tagbased_polymorphic.py | ||
| test_thread.cpp | ||
| test_thread.py | ||
| test_type_caster_pyobject_ptr.cpp | ||
| test_type_caster_pyobject_ptr.py | ||
| test_union.cpp | ||
| test_union.py | ||
| test_unnamed_namespace_a.cpp | ||
| test_unnamed_namespace_a.py | ||
| test_unnamed_namespace_b.cpp | ||
| test_unnamed_namespace_b.py | ||
| test_vector_unique_ptr_member.cpp | ||
| test_vector_unique_ptr_member.py | ||
| test_virtual_functions.cpp | ||
| test_virtual_functions.py | ||
| valgrind-numpy-scipy.supp | ||
| valgrind-python.supp | ||