Ralf W. Grosse-Kunstleve 79fd12b8cc Add NOLINTNEXTLINE(bugprone-unused-return-value) in smart_holder_poc_test.cpp ... Follow-on to https://github.com/pybind/pybind11/pull/5272 — clang-tidy upgrade (to version 18) Fixes this error: ``` /__w/pybind11/pybind11/tests/pure_cpp/smart_holder_poc_test.cpp:167:12: error: the value returned by this function should not be disregarded; neglecting it may lead to errors [bugprone-unused-return-value,-warnings-as-errors] 167 | (void) new_owner.release(); // Manually verified: without this, clang++ -fsanitize=address | ^~~~~~~~~~~~~~~~~~~ ``` See also: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/unused-return-value.html Specifically there: > std::unique_ptr::release(). Not using the return value can lead to resource leaks if the same pointer isn’t stored anywhere else. Often, ignoring the release() return value indicates that the programmer confused the function with reset(). I.e. the only way to tell clang-tidy that the smart_holder_poc_test.cpp is correct is to add the `NOLINT`.		2024-07-29 19:31:30 -07:00
..
CMakeLists.txt	Revert "Updating Catch version to latest, in hopes of resolving the GHA download issue affecting all MSVC builds."	2021-06-30 07:04:31 -07:00
smart_holder_poc_test.cpp	Add NOLINTNEXTLINE(bugprone-unused-return-value) in smart_holder_poc_test.cpp	2024-07-29 19:31:30 -07:00