mirror of
https://github.com/pybind/pybind11.git
synced 2024-11-13 09:03:54 +00:00
48f25275c4
* Put bakein branch @ 18b72c0ffa on top of smart_holder branch:
Commands used:
```
git checkout bakein
git diff smart_holder > ~/zd
git checkout smart_holder
git checkout -b bakein_sh
patch -p 1 < ~/zd
git checkout smart_holder \
MANIFEST.in \
README.rst \
README_smart_holder.rst \
docs/advanced/smart_ptrs.rst \
ubench/holder_comparison.cpp \
ubench/holder_comparison.py \
ubench/holder_comparison_extract_sheet_data.py \
ubench/number_bucket.h \
ubench/python/number_bucket.clif
git add -A
```
* Add back README_smart_holder.rst in tests/extra_python_package/test_files.py
* Restore smart_holder_poc.h as-is on smart_holder branch (i.e. undo `PYBIND11_SMART_HOLDER_PADDING`, which was meant for stress-testing only).
* Insert `std::move()` as suggested by @laramiel
* `property_cpp_function_sh_*` named specializations, as suggested by @laramiel (https://github.com/pybind/pybind11/pull/5257#discussion_r1688346807)
* Call `property_cpp_function_classic` member functions, rather than inlining the implementations.
* Use `PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT` in holder_comparison.cpp (holder_comparison.py is NOT changed accordingly in this commit, i.e. can still only be run if the smart_holder functionality is available).
* Systematically rename `loaded_as` to `load_as` (`shared_ptr`, `unique_ptr`) as suggested by @laramiel
* Make change as suggested by @laramiel. This makes it much more obvious that the latest implementation of `smart_holder_from_unique_ptr()` accepts all existing `return_value_policy` enum values except `copy`.
* Resolve `BAKEIN_WIP: Rewrite comment.` for `property_cpp_function_*` specializations.
* Resolve `BAKEIN_WIP: Add comment to explain: This is meant for stress-testing only.`
* Resolve all remaining BAKEIN_WIP (in pybind11/cast.h).
Leave only two pairs of SMART_HOLDER_BAKEIN_FOLLOW_ON comments: refactoring of copyable_holder_caster, move_only_holder_caster. This is best left until after the smart_holder branch is merged into the master branch.
* Remove obsolete `using holder_type = smart_holder;` in `load_helper`
* Add SMART_HOLDER_BAKEIN_FOLLOW_ON comment for `internals::default_holder`
* README_smart_holder.rst update (line count reduced from 356 to 123).
76 lines
2.2 KiB
C++
76 lines
2.2 KiB
C++
// Copyright (c) 2021 The Pybind Development Team.
|
|
// All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "pybind11/smart_holder.h"
|
|
#include "pybind11/trampoline_self_life_support.h"
|
|
#include "pybind11_tests.h"
|
|
|
|
#include <cstdint>
|
|
|
|
namespace pybind11_tests {
|
|
namespace class_sh_trampoline_unique_ptr {
|
|
|
|
class Class {
|
|
public:
|
|
virtual ~Class() = default;
|
|
|
|
void setVal(std::uint64_t val) { val_ = val; }
|
|
std::uint64_t getVal() const { return val_; }
|
|
|
|
virtual std::unique_ptr<Class> clone() const = 0;
|
|
virtual int foo() const = 0;
|
|
|
|
protected:
|
|
Class() = default;
|
|
|
|
// Some compilers complain about implicitly defined versions of some of the following:
|
|
Class(const Class &) = default;
|
|
|
|
private:
|
|
std::uint64_t val_ = 0;
|
|
};
|
|
|
|
} // namespace class_sh_trampoline_unique_ptr
|
|
} // namespace pybind11_tests
|
|
|
|
PYBIND11_SMART_HOLDER_TYPE_CASTERS(pybind11_tests::class_sh_trampoline_unique_ptr::Class)
|
|
|
|
namespace pybind11_tests {
|
|
namespace class_sh_trampoline_unique_ptr {
|
|
|
|
#ifdef PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT
|
|
class PyClass : public Class, public py::trampoline_self_life_support {
|
|
public:
|
|
std::unique_ptr<Class> clone() const override {
|
|
PYBIND11_OVERRIDE_PURE(std::unique_ptr<Class>, Class, clone);
|
|
}
|
|
|
|
int foo() const override { PYBIND11_OVERRIDE_PURE(int, Class, foo); }
|
|
};
|
|
#endif
|
|
|
|
} // namespace class_sh_trampoline_unique_ptr
|
|
} // namespace pybind11_tests
|
|
|
|
TEST_SUBMODULE(class_sh_trampoline_unique_ptr, m) {
|
|
m.attr("defined_PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT") =
|
|
#ifndef PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT
|
|
false;
|
|
#else
|
|
true;
|
|
|
|
using namespace pybind11_tests::class_sh_trampoline_unique_ptr;
|
|
|
|
py::classh<Class, PyClass>(m, "Class")
|
|
.def(py::init<>())
|
|
.def("set_val", &Class::setVal)
|
|
.def("get_val", &Class::getVal)
|
|
.def("clone", &Class::clone)
|
|
.def("foo", &Class::foo);
|
|
|
|
m.def("clone", [](const Class &obj) { return obj.clone(); });
|
|
m.def("clone_and_foo", [](const Class &obj) { return obj.clone()->foo(); });
|
|
#endif // PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT
|
|
}
|