mirror of
https://github.com/pybind/pybind11.git
synced 2024-11-26 15:12:01 +00:00
55105fbeaf
* Store `std::function<void (void *)>` del_fun; in `guarded_delete`
* Specialize the simple common case.
Using a `union` is complicated: https://en.cppreference.com/w/cpp/language/union
> If members of a union are classes with user-defined constructors and destructors, to switch the active member, explicit destructor and placement new are generally needed:
Using `std::variant` increases compile-time overhead.
It is currently unclear how much these effects matter in practice: optimization left for later.
* Add one test case (more later).
* Add `const` to resolve clang-tidy error.
```
-- The CXX compiler identification is Clang 15.0.7
/usr/bin/cmake -E __run_co_compile --tidy="/usr/bin/clang-tidy;--use-color;--warnings-as-errors=*;--extra-arg-before=--driver-mode=g++" --source=/__w/pybind11/pybind11/tests/test_class_sh_inheritance.cpp -- /usr/bin/c++ -DPYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD_IF_AVAILABLE -DPYBIND11_TEST_EIGEN -Dpybind11_tests_EXPORTS -I/__w/pybind11/pybind11/include -isystem /usr/include/python3.9 -isystem /__w/pybind11/pybind11/build/_deps/eigen-src -Os -DNDEBUG -fPIC -fvisibility=hidden -Wall -Wextra -Wconversion -Wcast-qual -Wdeprecated -Wundef -Wnon-virtual-dtor -flto=thin -std=c++17 -o CMakeFiles/pybind11_tests.dir/test_class_sh_inheritance.cpp.o -c /__w/pybind11/pybind11/tests/test_class_sh_inheritance.cpp
/__w/pybind11/pybind11/tests/pure_cpp/smart_holder_poc_test.cpp:264:30: error: pointer parameter 'raw_ptr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
new int(19), [](int *raw_ptr) { delete raw_ptr; });
^
const
```
* Introduce `struct custom_deleter` to ensure the deleter is moved as desired (the lambda function only captures a reference, which can become dangling).
* Resolve helpful clang-tidy errors.
```
/usr/bin/cmake -E __run_co_compile --tidy="/usr/bin/clang-tidy;--use-color;--warnings-as-errors=*;--extra-arg-before=--driver-mode=g++" --source=/__w/pybind11/pybind11/tests/test_class.cpp -- /usr/bin/c++ -DPYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD_IF_AVAILABLE -DPYBIND11_TEST_EIGEN -Dpybind11_tests_EXPORTS -I/__w/pybind11/pybind11/include -isystem /usr/include/python3.9 -isystem /__w/pybind11/pybind11/build/_deps/eigen-src -Os -DNDEBUG -fPIC -fvisibility=hidden -Wall -Wextra -Wconversion -Wcast-qual -Wdeprecated -Wundef -Wnon-virtual-dtor -flto=thin -std=c++17 -o CMakeFiles/pybind11_tests.dir/test_class.cpp.o -c /__w/pybind11/pybind11/tests/test_class.cpp
/__w/pybind11/pybind11/include/pybind11/detail/smart_holder_poc.h:114:5: error: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor,-warnings-as-errors]
custom_deleter(D &&deleter) : deleter{std::move(deleter)} {}
^
explicit
/__w/pybind11/pybind11/include/pybind11/detail/smart_holder_poc.h:120:76: error: forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference,-warnings-as-errors]
return guarded_delete(std::function<void(void *)>(custom_deleter<T, D>(std::move(uqp_del))),
^~~~~~~~~
std::forward<D>
```
* Workaround for gcc 4.8.5, clang 3.6
* Transfer reduced test here.
Reduced from a PyCLIF use case in the wild by @wangxf123456 (internal change cl/565476030).
* Add missing include (clangd Include Cleaner)
* Change `std::move` to `std::forward` as suggested by @iwanders.
* Add missing includes (clangd Include Cleaner)
* Use new `PYBIND11_TESTS_PURE_CPP_SMART_HOLDER_POC_TEST_CPP` to exclude `smart_holder::as_unique_ptr` method from production code.
* Systematically add `PYBIND11_TESTS_PURE_CPP_SMART_HOLDER_POC_TEST_CPP` to mark code that is not used from production code. Add comment to explain.
* Very simple experiment related to https://github.com/pybind/pybind11/pull/4850#issuecomment-1789780676
Does the `PYBIND11_TESTS_PURE_CPP_SMART_HOLDER_POC_TEST_CPP` define have anything to do with it?
* Revert "Very simple experiment related to https://github.com/pybind/pybind11/pull/4850#issuecomment-1789780676"
This reverts commit fe59369f40
.
414 lines
16 KiB
C++
414 lines
16 KiB
C++
#define PYBIND11_TESTS_PURE_CPP_SMART_HOLDER_POC_TEST_CPP
|
|
|
|
#include "pybind11/detail/smart_holder_poc.h"
|
|
|
|
#include <functional>
|
|
#include <memory>
|
|
#include <type_traits>
|
|
#include <utility>
|
|
|
|
// Catch uses _ internally, which breaks gettext style defines
|
|
#ifdef _
|
|
# undef _
|
|
#endif
|
|
|
|
#define CATCH_CONFIG_MAIN
|
|
#include "catch.hpp"
|
|
|
|
using pybindit::memory::smart_holder;
|
|
|
|
namespace helpers {
|
|
|
|
struct movable_int {
|
|
int valu;
|
|
explicit movable_int(int v) : valu{v} {}
|
|
movable_int(movable_int &&other) noexcept : valu(other.valu) { other.valu = 91; }
|
|
};
|
|
|
|
template <typename T>
|
|
struct functor_builtin_delete {
|
|
void operator()(T *ptr) { delete ptr; }
|
|
#if (defined(__GNUC__) && __GNUC__ == 4 && __GNUC_MINOR__ == 8) \
|
|
|| (defined(__clang_major__) && __clang_major__ == 3 && __clang_minor__ == 6)
|
|
// Workaround for these errors:
|
|
// gcc 4.8.5: too many initializers for 'helpers::functor_builtin_delete<int>'
|
|
// clang 3.6: excess elements in struct initializer
|
|
functor_builtin_delete() = default;
|
|
functor_builtin_delete(const functor_builtin_delete &) {}
|
|
functor_builtin_delete(functor_builtin_delete &&) {}
|
|
#endif
|
|
};
|
|
|
|
template <typename T>
|
|
struct functor_other_delete : functor_builtin_delete<T> {};
|
|
|
|
struct indestructible_int {
|
|
int valu;
|
|
explicit indestructible_int(int v) : valu{v} {}
|
|
|
|
private:
|
|
~indestructible_int() = default;
|
|
};
|
|
|
|
struct base {
|
|
virtual int get() { return 10; }
|
|
virtual ~base() = default;
|
|
};
|
|
|
|
struct derived : public base {
|
|
int get() override { return 100; }
|
|
};
|
|
|
|
} // namespace helpers
|
|
|
|
TEST_CASE("from_raw_ptr_unowned+as_raw_ptr_unowned", "[S]") {
|
|
static int value = 19;
|
|
auto hld = smart_holder::from_raw_ptr_unowned(&value);
|
|
REQUIRE(*hld.as_raw_ptr_unowned<int>() == 19);
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_unowned+as_lvalue_ref", "[S]") {
|
|
static int value = 19;
|
|
auto hld = smart_holder::from_raw_ptr_unowned(&value);
|
|
REQUIRE(hld.as_lvalue_ref<int>() == 19);
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_unowned+as_rvalue_ref", "[S]") {
|
|
helpers::movable_int orig(19);
|
|
{
|
|
auto hld = smart_holder::from_raw_ptr_unowned(&orig);
|
|
helpers::movable_int othr(hld.as_rvalue_ref<helpers::movable_int>());
|
|
REQUIRE(othr.valu == 19);
|
|
REQUIRE(orig.valu == 91);
|
|
}
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_unowned+as_raw_ptr_release_ownership", "[E]") {
|
|
static int value = 19;
|
|
auto hld = smart_holder::from_raw_ptr_unowned(&value);
|
|
REQUIRE_THROWS_WITH(hld.as_raw_ptr_release_ownership<int>(),
|
|
"Cannot disown non-owning holder (as_raw_ptr_release_ownership).");
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_unowned+as_unique_ptr", "[E]") {
|
|
static int value = 19;
|
|
auto hld = smart_holder::from_raw_ptr_unowned(&value);
|
|
REQUIRE_THROWS_WITH(hld.as_unique_ptr<int>(),
|
|
"Cannot disown non-owning holder (as_unique_ptr).");
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_unowned+as_unique_ptr_with_deleter", "[E]") {
|
|
static int value = 19;
|
|
auto hld = smart_holder::from_raw_ptr_unowned(&value);
|
|
REQUIRE_THROWS_WITH((hld.as_unique_ptr<int, helpers::functor_builtin_delete<int>>()),
|
|
"Missing unique_ptr deleter (as_unique_ptr).");
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_unowned+as_shared_ptr", "[S]") {
|
|
static int value = 19;
|
|
auto hld = smart_holder::from_raw_ptr_unowned(&value);
|
|
REQUIRE(*hld.as_shared_ptr<int>() == 19);
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_take_ownership+as_lvalue_ref", "[S]") {
|
|
auto hld = smart_holder::from_raw_ptr_take_ownership(new int(19));
|
|
REQUIRE(hld.has_pointee());
|
|
REQUIRE(hld.as_lvalue_ref<int>() == 19);
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_take_ownership+as_raw_ptr_release_ownership1", "[S]") {
|
|
auto hld = smart_holder::from_raw_ptr_take_ownership(new int(19));
|
|
auto new_owner = std::unique_ptr<int>(hld.as_raw_ptr_release_ownership<int>());
|
|
REQUIRE(!hld.has_pointee());
|
|
REQUIRE(*new_owner == 19);
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_take_ownership+as_raw_ptr_release_ownership2", "[E]") {
|
|
auto hld = smart_holder::from_raw_ptr_take_ownership(new int(19));
|
|
auto shd_ptr = hld.as_shared_ptr<int>();
|
|
REQUIRE_THROWS_WITH(hld.as_raw_ptr_release_ownership<int>(),
|
|
"Cannot disown use_count != 1 (as_raw_ptr_release_ownership).");
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_take_ownership+as_unique_ptr1", "[S]") {
|
|
auto hld = smart_holder::from_raw_ptr_take_ownership(new int(19));
|
|
std::unique_ptr<int> new_owner = hld.as_unique_ptr<int>();
|
|
REQUIRE(!hld.has_pointee());
|
|
REQUIRE(*new_owner == 19);
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_take_ownership+as_unique_ptr2", "[E]") {
|
|
auto hld = smart_holder::from_raw_ptr_take_ownership(new int(19));
|
|
auto shd_ptr = hld.as_shared_ptr<int>();
|
|
REQUIRE_THROWS_WITH(hld.as_unique_ptr<int>(), "Cannot disown use_count != 1 (as_unique_ptr).");
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_take_ownership+as_unique_ptr_with_deleter", "[E]") {
|
|
auto hld = smart_holder::from_raw_ptr_take_ownership(new int(19));
|
|
REQUIRE_THROWS_WITH((hld.as_unique_ptr<int, helpers::functor_builtin_delete<int>>()),
|
|
"Missing unique_ptr deleter (as_unique_ptr).");
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_take_ownership+as_shared_ptr", "[S]") {
|
|
auto hld = smart_holder::from_raw_ptr_take_ownership(new int(19));
|
|
std::shared_ptr<int> new_owner = hld.as_shared_ptr<int>();
|
|
REQUIRE(hld.has_pointee());
|
|
REQUIRE(*new_owner == 19);
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_take_ownership+disown+reclaim_disowned", "[S]") {
|
|
auto hld = smart_holder::from_raw_ptr_take_ownership(new int(19));
|
|
std::unique_ptr<int> new_owner(hld.as_raw_ptr_unowned<int>());
|
|
hld.disown();
|
|
REQUIRE(hld.as_lvalue_ref<int>() == 19);
|
|
REQUIRE(*new_owner == 19);
|
|
hld.reclaim_disowned(); // Manually veriified: without this, clang++ -fsanitize=address reports
|
|
// "detected memory leaks".
|
|
(void) new_owner.release(); // Manually verified: without this, clang++ -fsanitize=address
|
|
// reports "attempting double-free".
|
|
REQUIRE(hld.as_lvalue_ref<int>() == 19);
|
|
REQUIRE(new_owner.get() == nullptr);
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_take_ownership+disown+release_disowned", "[S]") {
|
|
auto hld = smart_holder::from_raw_ptr_take_ownership(new int(19));
|
|
std::unique_ptr<int> new_owner(hld.as_raw_ptr_unowned<int>());
|
|
hld.disown();
|
|
REQUIRE(hld.as_lvalue_ref<int>() == 19);
|
|
REQUIRE(*new_owner == 19);
|
|
hld.release_disowned();
|
|
REQUIRE(!hld.has_pointee());
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_take_ownership+disown+ensure_is_not_disowned", "[E]") {
|
|
const char *context = "test_case";
|
|
auto hld = smart_holder::from_raw_ptr_take_ownership(new int(19));
|
|
hld.ensure_is_not_disowned(context); // Does not throw.
|
|
std::unique_ptr<int> new_owner(hld.as_raw_ptr_unowned<int>());
|
|
hld.disown();
|
|
REQUIRE_THROWS_WITH(hld.ensure_is_not_disowned(context),
|
|
"Holder was disowned already (test_case).");
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr+as_lvalue_ref", "[S]") {
|
|
std::unique_ptr<int> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
REQUIRE(hld.as_lvalue_ref<int>() == 19);
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr+as_raw_ptr_release_ownership1", "[S]") {
|
|
std::unique_ptr<int> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
auto new_owner = std::unique_ptr<int>(hld.as_raw_ptr_release_ownership<int>());
|
|
REQUIRE(!hld.has_pointee());
|
|
REQUIRE(*new_owner == 19);
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr+as_raw_ptr_release_ownership2", "[E]") {
|
|
std::unique_ptr<int> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
auto shd_ptr = hld.as_shared_ptr<int>();
|
|
REQUIRE_THROWS_WITH(hld.as_raw_ptr_release_ownership<int>(),
|
|
"Cannot disown use_count != 1 (as_raw_ptr_release_ownership).");
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr+as_unique_ptr1", "[S]") {
|
|
std::unique_ptr<int> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
std::unique_ptr<int> new_owner = hld.as_unique_ptr<int>();
|
|
REQUIRE(!hld.has_pointee());
|
|
REQUIRE(*new_owner == 19);
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr+as_unique_ptr2", "[E]") {
|
|
std::unique_ptr<int> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
auto shd_ptr = hld.as_shared_ptr<int>();
|
|
REQUIRE_THROWS_WITH(hld.as_unique_ptr<int>(), "Cannot disown use_count != 1 (as_unique_ptr).");
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr+as_unique_ptr_with_deleter", "[E]") {
|
|
std::unique_ptr<int> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
REQUIRE_THROWS_WITH((hld.as_unique_ptr<int, helpers::functor_builtin_delete<int>>()),
|
|
"Incompatible unique_ptr deleter (as_unique_ptr).");
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr+as_shared_ptr", "[S]") {
|
|
std::unique_ptr<int> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
std::shared_ptr<int> new_owner = hld.as_shared_ptr<int>();
|
|
REQUIRE(hld.has_pointee());
|
|
REQUIRE(*new_owner == 19);
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr_derived+as_unique_ptr_base", "[S]") {
|
|
std::unique_ptr<helpers::derived> orig_owner(new helpers::derived());
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
std::unique_ptr<helpers::base> new_owner = hld.as_unique_ptr<helpers::base>();
|
|
REQUIRE(!hld.has_pointee());
|
|
REQUIRE(new_owner->get() == 100);
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr_derived+as_unique_ptr_base2", "[E]") {
|
|
std::unique_ptr<helpers::derived, helpers::functor_other_delete<helpers::derived>> orig_owner(
|
|
new helpers::derived());
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
REQUIRE_THROWS_WITH(
|
|
(hld.as_unique_ptr<helpers::base, helpers::functor_builtin_delete<helpers::base>>()),
|
|
"Incompatible unique_ptr deleter (as_unique_ptr).");
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr_with_deleter+as_lvalue_ref", "[S]") {
|
|
std::unique_ptr<int, helpers::functor_builtin_delete<int>> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
REQUIRE(hld.as_lvalue_ref<int>() == 19);
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr_with_std_function_deleter+as_lvalue_ref", "[S]") {
|
|
std::unique_ptr<int, std::function<void(const int *)>> orig_owner(
|
|
new int(19), [](const int *raw_ptr) { delete raw_ptr; });
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
REQUIRE(hld.as_lvalue_ref<int>() == 19);
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr_with_deleter+as_raw_ptr_release_ownership", "[E]") {
|
|
std::unique_ptr<int, helpers::functor_builtin_delete<int>> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
REQUIRE_THROWS_WITH(hld.as_raw_ptr_release_ownership<int>(),
|
|
"Cannot disown custom deleter (as_raw_ptr_release_ownership).");
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr_with_deleter+as_unique_ptr", "[E]") {
|
|
std::unique_ptr<int, helpers::functor_builtin_delete<int>> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
REQUIRE_THROWS_WITH(hld.as_unique_ptr<int>(),
|
|
"Incompatible unique_ptr deleter (as_unique_ptr).");
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr_with_deleter+as_unique_ptr_with_deleter1", "[S]") {
|
|
std::unique_ptr<int, helpers::functor_builtin_delete<int>> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
std::unique_ptr<int, helpers::functor_builtin_delete<int>> new_owner
|
|
= hld.as_unique_ptr<int, helpers::functor_builtin_delete<int>>();
|
|
REQUIRE(!hld.has_pointee());
|
|
REQUIRE(*new_owner == 19);
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr_with_deleter+as_unique_ptr_with_deleter2", "[E]") {
|
|
std::unique_ptr<int, helpers::functor_builtin_delete<int>> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
REQUIRE_THROWS_WITH((hld.as_unique_ptr<int, helpers::functor_other_delete<int>>()),
|
|
"Incompatible unique_ptr deleter (as_unique_ptr).");
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr_with_deleter+as_shared_ptr", "[S]") {
|
|
std::unique_ptr<int, helpers::functor_builtin_delete<int>> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
REQUIRE(orig_owner.get() == nullptr);
|
|
std::shared_ptr<int> new_owner = hld.as_shared_ptr<int>();
|
|
REQUIRE(hld.has_pointee());
|
|
REQUIRE(*new_owner == 19);
|
|
}
|
|
|
|
TEST_CASE("from_shared_ptr+as_lvalue_ref", "[S]") {
|
|
std::shared_ptr<int> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_shared_ptr(orig_owner);
|
|
REQUIRE(hld.as_lvalue_ref<int>() == 19);
|
|
}
|
|
|
|
TEST_CASE("from_shared_ptr+as_raw_ptr_release_ownership", "[E]") {
|
|
std::shared_ptr<int> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_shared_ptr(orig_owner);
|
|
REQUIRE_THROWS_WITH(hld.as_raw_ptr_release_ownership<int>(),
|
|
"Cannot disown external shared_ptr (as_raw_ptr_release_ownership).");
|
|
}
|
|
|
|
TEST_CASE("from_shared_ptr+as_unique_ptr", "[E]") {
|
|
std::shared_ptr<int> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_shared_ptr(orig_owner);
|
|
REQUIRE_THROWS_WITH(hld.as_unique_ptr<int>(),
|
|
"Cannot disown external shared_ptr (as_unique_ptr).");
|
|
}
|
|
|
|
TEST_CASE("from_shared_ptr+as_unique_ptr_with_deleter", "[E]") {
|
|
std::shared_ptr<int> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_shared_ptr(orig_owner);
|
|
REQUIRE_THROWS_WITH((hld.as_unique_ptr<int, helpers::functor_builtin_delete<int>>()),
|
|
"Missing unique_ptr deleter (as_unique_ptr).");
|
|
}
|
|
|
|
TEST_CASE("from_shared_ptr+as_shared_ptr", "[S]") {
|
|
std::shared_ptr<int> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_shared_ptr(orig_owner);
|
|
REQUIRE(*hld.as_shared_ptr<int>() == 19);
|
|
}
|
|
|
|
TEST_CASE("error_unpopulated_holder", "[E]") {
|
|
smart_holder hld;
|
|
REQUIRE_THROWS_WITH(hld.as_lvalue_ref<int>(), "Unpopulated holder (as_lvalue_ref).");
|
|
}
|
|
|
|
TEST_CASE("error_disowned_holder", "[E]") {
|
|
auto hld = smart_holder::from_raw_ptr_take_ownership(new int(19));
|
|
hld.as_unique_ptr<int>();
|
|
REQUIRE_THROWS_WITH(hld.as_lvalue_ref<int>(), "Disowned holder (as_lvalue_ref).");
|
|
}
|
|
|
|
TEST_CASE("error_cannot_disown_nullptr", "[E]") {
|
|
auto hld = smart_holder::from_raw_ptr_take_ownership(new int(19));
|
|
hld.as_unique_ptr<int>();
|
|
REQUIRE_THROWS_WITH(hld.as_unique_ptr<int>(), "Cannot disown nullptr (as_unique_ptr).");
|
|
}
|
|
|
|
TEST_CASE("indestructible_int-from_raw_ptr_unowned+as_raw_ptr_unowned", "[S]") {
|
|
using zombie = helpers::indestructible_int;
|
|
// Using placement new instead of plain new, to not trigger leak sanitizer errors.
|
|
static std::aligned_storage<sizeof(zombie), alignof(zombie)>::type memory_block[1];
|
|
auto *value = new (memory_block) zombie(19);
|
|
auto hld = smart_holder::from_raw_ptr_unowned(value);
|
|
REQUIRE(hld.as_raw_ptr_unowned<zombie>()->valu == 19);
|
|
}
|
|
|
|
TEST_CASE("indestructible_int-from_raw_ptr_take_ownership", "[E]") {
|
|
helpers::indestructible_int *value = nullptr;
|
|
REQUIRE_THROWS_WITH(smart_holder::from_raw_ptr_take_ownership(value),
|
|
"Pointee is not destructible (from_raw_ptr_take_ownership).");
|
|
}
|
|
|
|
TEST_CASE("from_raw_ptr_take_ownership+as_shared_ptr-outliving_smart_holder", "[S]") {
|
|
// Exercises guarded_builtin_delete flag_ptr validity past destruction of smart_holder.
|
|
std::shared_ptr<int> longer_living;
|
|
{
|
|
auto hld = smart_holder::from_raw_ptr_take_ownership(new int(19));
|
|
longer_living = hld.as_shared_ptr<int>();
|
|
}
|
|
REQUIRE(*longer_living == 19);
|
|
}
|
|
|
|
TEST_CASE("from_unique_ptr_with_deleter+as_shared_ptr-outliving_smart_holder", "[S]") {
|
|
// Exercises guarded_custom_deleter flag_ptr validity past destruction of smart_holder.
|
|
std::shared_ptr<int> longer_living;
|
|
{
|
|
std::unique_ptr<int, helpers::functor_builtin_delete<int>> orig_owner(new int(19));
|
|
auto hld = smart_holder::from_unique_ptr(std::move(orig_owner));
|
|
longer_living = hld.as_shared_ptr<int>();
|
|
}
|
|
REQUIRE(*longer_living == 19);
|
|
}
|