mirror of
https://github.com/pybind/pybind11.git
synced 2024-11-21 20:55:11 +00:00
90312a6ee8
* Add `type_caster<PyObject>` (tests are still incomplete).
* Fix oversight (`const PyObject *`).
* Ensure `type_caster<PyObject>` only works for `PyObject *`
* Move `is_same_ignoring_cvref` into `detail` namespace.
* Add test_cast_nullptr
* Change is_same_ignoring_cvref from variable template to using.
```
test_type_caster_pyobject_ptr.cpp:8:23: error: variable templates only available with ‘-std=c++14’ or ‘-std=gnu++14’ [-Werror]
8 | static constexpr bool is_same_ignoring_cvref = std::is_same<detail::remove_cvref_t<T>, U>::value;
| ^~~~~~~~~~~~~~~~~~~~~~
```
* Remove `return_value_policy::reference_internal` `keep_alive` feature (because of doubts about it actually being useful).
* Add missing test, fix bug (missing `throw error_already_set();`), various cosmetic changes.
* Move `type_caster<PyObject>` from test to new include (pybind11/type_caster_pyobject_ptr.h)
* Add new header file to CMakeLists.txt and tests/extra_python_package/test_files.py
* Backport changes from https://github.com/google/pywrapcc/pull/30021 to https://github.com/pybind/pybind11/pull/4601
* Fix oversight in test (to resolve a valgrind leak detection error) and add a related comment in cast.h.
No production code changes.
Make tests more sensitive by using `ValueHolder` instead of empty tuples and dicts.
Manual leak checks with `while True:` & top command repeated for all tests.
* Add tests for interop with stl.h `list_caster`
(No production code changes.)
* Bug fix in test. Minor comment enhancements.
* Change `type_caster<PyObject>::name` to `object`, as suggested by @Skylion007
* Expand comment for the new `T cast(const handle &handle)` [`T` = `PyObject *`]
* Add `T cast(object &&obj)` overload as suggested by @Skylion007
The original suggestion leads to `error: call to 'cast' is ambiguous` (full error message below), therefore SFINAE guarding is needed.
```
clang++ -o pybind11/tests/test_type_caster_pyobject_ptr.os -c -std=c++17 -fPIC -fvisibility=hidden -O0 -g -Wall -Wextra -Wconversion -Wcast-qual -Wdeprecated -Wundef -Wnon-virtual-dtor -Wunused-result -Werror -isystem /usr/include/python3.10 -isystem /usr/include/eigen3 -DPYBIND11_STRICT_ASSERTS_CLASS_HOLDER_VS_TYPE_CASTER_MIX -DPYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD_IF_AVAILABLE -DPYBIND11_TEST_BOOST -Ipybind11/include -I/usr/local/google/home/rwgk/forked/pybind11/include -I/usr/local/google/home/rwgk/clone/pybind11/include /usr/local/google/home/rwgk/forked/pybind11/tests/test_type_caster_pyobject_ptr.cpp
In file included from /usr/local/google/home/rwgk/forked/pybind11/tests/test_type_caster_pyobject_ptr.cpp:1:
In file included from /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/functional.h:12:
In file included from /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/pybind11.h:13:
In file included from /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/class.h:12:
In file included from /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/attr.h:14:
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/cast.h:1165:12: error: call to 'cast' is ambiguous
return pybind11::cast<T>(std::move(*this));
^~~~~~~~~~~~~~~~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/functional.h:109:70: note: in instantiation of function template specialization 'pybind11::object::cast<_object *>' requested here
return hfunc.f(std::forward<Args>(args)...).template cast<Return>();
^
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/functional.h:103:16: note: in instantiation of member function 'pybind11::detail::type_caster<std::function<_object *(int)>>::load(pybind11::handle, bool)::func_wrapper::operator()' requested here
struct func_wrapper {
^
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/cast.h:1456:47: note: in instantiation of member function 'pybind11::detail::type_caster<std::function<_object *(int)>>::load' requested here
if ((... || !std::get<Is>(argcasters).load(call.args[Is], call.args_convert[Is]))) {
^
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/cast.h:1434:50: note: in instantiation of function template specialization 'pybind11::detail::argument_loader<const std::function<_object *(int)> &, int>::load_impl_sequence<0UL, 1UL>' requested here
bool load_args(function_call &call) { return load_impl_sequence(call, indices{}); }
^
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/pybind11.h:227:33: note: in instantiation of member function 'pybind11::detail::argument_loader<const std::function<_object *(int)> &, int>::load_args' requested here
if (!args_converter.load_args(call)) {
^
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/pybind11.h:101:9: note: in instantiation of function template specialization 'pybind11::cpp_function::initialize<(lambda at /usr/local/google/home/rwgk/forked/pybind11/tests/test_type_caster_pyobject_ptr.cpp:50:9), _object *, const std::function<_object *(int)> &, int, pybind11::name, pybind11::scope, pybind11::sibling, pybind11::return_value_policy>' requested here
initialize(
^
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/pybind11.h:1163:22: note: in instantiation of function template specialization 'pybind11::cpp_function::cpp_function<(lambda at /usr/local/google/home/rwgk/forked/pybind11/tests/test_type_caster_pyobject_ptr.cpp:50:9), pybind11::name, pybind11::scope, pybind11::sibling, pybind11::return_value_policy, void>' requested here
cpp_function func(std::forward<Func>(f),
^
/usr/local/google/home/rwgk/forked/pybind11/tests/test_type_caster_pyobject_ptr.cpp:48:7: note: in instantiation of function template specialization 'pybind11::module_::def<(lambda at /usr/local/google/home/rwgk/forked/pybind11/tests/test_type_caster_pyobject_ptr.cpp:50:9), pybind11::return_value_policy>' requested here
m.def(
^
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/cast.h:1077:3: note: candidate function [with T = _object *, $1 = 0]
T cast(object &&obj) {
^
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/cast.h:1149:1: note: candidate function [with T = _object *]
cast(object &&object) {
^
1 error generated.
```
|
||
|---|---|---|
| .. | ||
| extra_python_package | ||
| extra_setuptools | ||
| test_cmake_build | ||
| test_embed | ||
| CMakeLists.txt | ||
| conftest.py | ||
| constructor_stats.h | ||
| cross_module_gil_utils.cpp | ||
| cross_module_interleaved_error_already_set.cpp | ||
| eigen_tensor_avoid_stl_array.cpp | ||
| env.py | ||
| local_bindings.h | ||
| object.h | ||
| pybind11_cross_module_tests.cpp | ||
| pybind11_tests.cpp | ||
| pybind11_tests.h | ||
| pytest.ini | ||
| requirements.txt | ||
| test_async.cpp | ||
| test_async.py | ||
| test_buffers.cpp | ||
| test_buffers.py | ||
| test_builtin_casters.cpp | ||
| test_builtin_casters.py | ||
| test_call_policies.cpp | ||
| test_call_policies.py | ||
| test_callbacks.cpp | ||
| test_callbacks.py | ||
| test_chrono.cpp | ||
| test_chrono.py | ||
| test_class.cpp | ||
| test_class.py | ||
| test_const_name.cpp | ||
| test_const_name.py | ||
| test_constants_and_functions.cpp | ||
| test_constants_and_functions.py | ||
| test_copy_move.cpp | ||
| test_copy_move.py | ||
| test_custom_type_casters.cpp | ||
| test_custom_type_casters.py | ||
| test_custom_type_setup.cpp | ||
| test_custom_type_setup.py | ||
| test_docstring_options.cpp | ||
| test_docstring_options.py | ||
| test_eigen_matrix.cpp | ||
| test_eigen_matrix.py | ||
| test_eigen_tensor.cpp | ||
| test_eigen_tensor.inl | ||
| test_eigen_tensor.py | ||
| test_enum.cpp | ||
| test_enum.py | ||
| test_eval_call.py | ||
| test_eval.cpp | ||
| test_eval.py | ||
| test_exceptions.cpp | ||
| test_exceptions.h | ||
| test_exceptions.py | ||
| test_factory_constructors.cpp | ||
| test_factory_constructors.py | ||
| test_gil_scoped.cpp | ||
| test_gil_scoped.py | ||
| test_iostream.cpp | ||
| test_iostream.py | ||
| test_kwargs_and_defaults.cpp | ||
| test_kwargs_and_defaults.py | ||
| test_local_bindings.cpp | ||
| test_local_bindings.py | ||
| test_methods_and_attributes.cpp | ||
| test_methods_and_attributes.py | ||
| test_modules.cpp | ||
| test_modules.py | ||
| test_multiple_inheritance.cpp | ||
| test_multiple_inheritance.py | ||
| test_numpy_array.cpp | ||
| test_numpy_array.py | ||
| test_numpy_dtypes.cpp | ||
| test_numpy_dtypes.py | ||
| test_numpy_vectorize.cpp | ||
| test_numpy_vectorize.py | ||
| test_opaque_types.cpp | ||
| test_opaque_types.py | ||
| test_operator_overloading.cpp | ||
| test_operator_overloading.py | ||
| test_pickling.cpp | ||
| test_pickling.py | ||
| test_pytypes.cpp | ||
| test_pytypes.py | ||
| test_sequences_and_iterators.cpp | ||
| test_sequences_and_iterators.py | ||
| test_smart_ptr.cpp | ||
| test_smart_ptr.py | ||
| test_stl_binders.cpp | ||
| test_stl_binders.py | ||
| test_stl.cpp | ||
| test_stl.py | ||
| test_tagbased_polymorphic.cpp | ||
| test_tagbased_polymorphic.py | ||
| test_thread.cpp | ||
| test_thread.py | ||
| test_type_caster_pyobject_ptr.cpp | ||
| test_type_caster_pyobject_ptr.py | ||
| test_union.cpp | ||
| test_union.py | ||
| test_unnamed_namespace_a.cpp | ||
| test_unnamed_namespace_a.py | ||
| test_unnamed_namespace_b.cpp | ||
| test_unnamed_namespace_b.py | ||
| test_vector_unique_ptr_member.cpp | ||
| test_vector_unique_ptr_member.py | ||
| test_virtual_functions.cpp | ||
| test_virtual_functions.py | ||
| valgrind-numpy-scipy.supp | ||
| valgrind-python.supp | ||