mirror of
https://github.com/pybind/pybind11.git
synced 2024-11-25 14:45:12 +00:00
bd8985aa0f
* Step 1: Establish new `PYBIND11_SMART_HOLDER_ENABLED` macro, but only under include/pybind11/
At the stage `PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT` and `PYBIND11_SMART_HOLDER_ENABLED` are still equivalent.
* Systematically replace all `PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT` with `PYBIND11_SMART_HOLDER_ENABLED` under tests/ and ubench/
As at the previous stage, `PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT` and `PYBIND11_SMART_HOLDER_ENABLED` are still equivalent.
* Introduce `PYBIND11_SMART_HOLDER_DISABLE` option.
* `#ifdef` out entire `wrap()` function to avoid `unused-parameter` warning-as-error under macos-13
```
/Users/runner/work/pybind11/pybind11/tests/test_class_sh_trampoline_basic.cpp:67:23: error: unused parameter 'm' [-Werror,-Wunused-parameter]
void wrap(py::module_ m, const char *py_class_name) {
^
/Users/runner/work/pybind11/pybind11/tests/test_class_sh_trampoline_basic.cpp:67:38: error: unused parameter 'py_class_name' [-Werror,-Wunused-parameter]
void wrap(py::module_ m, const char *py_class_name) {
^
2 errors generated.
```
48 lines
1.1 KiB
C++
48 lines
1.1 KiB
C++
#include <pybind11/smart_holder.h>
|
|
|
|
#include "pybind11_tests.h"
|
|
|
|
#include <memory>
|
|
|
|
namespace pybind11_tests {
|
|
namespace class_sh_unique_ptr_custom_deleter {
|
|
|
|
// Reduced from a PyCLIF use case in the wild by @wangxf123456.
|
|
class Pet {
|
|
public:
|
|
using Ptr = std::unique_ptr<Pet, std::function<void(Pet *)>>;
|
|
|
|
std::string name;
|
|
|
|
static Ptr New(const std::string &name) {
|
|
return Ptr(new Pet(name), std::default_delete<Pet>());
|
|
}
|
|
|
|
private:
|
|
explicit Pet(const std::string &name) : name(name) {}
|
|
};
|
|
|
|
} // namespace class_sh_unique_ptr_custom_deleter
|
|
} // namespace pybind11_tests
|
|
|
|
PYBIND11_SMART_HOLDER_TYPE_CASTERS(pybind11_tests::class_sh_unique_ptr_custom_deleter::Pet)
|
|
|
|
namespace pybind11_tests {
|
|
namespace class_sh_unique_ptr_custom_deleter {
|
|
|
|
TEST_SUBMODULE(class_sh_unique_ptr_custom_deleter, m) {
|
|
m.attr("defined_PYBIND11_SMART_HOLDER_ENABLED") =
|
|
#ifndef PYBIND11_SMART_HOLDER_ENABLED
|
|
false;
|
|
#else
|
|
true;
|
|
|
|
py::classh<Pet>(m, "Pet").def_readwrite("name", &Pet::name);
|
|
|
|
m.def("create", &Pet::New);
|
|
#endif // PYBIND11_SMART_HOLDER_ENABLED
|
|
}
|
|
|
|
} // namespace class_sh_unique_ptr_custom_deleter
|
|
} // namespace pybind11_tests
|