mirror of
https://github.com/pybind/pybind11.git
synced 2024-11-14 09:34:46 +00:00
PR merging guidelines
parent
648271271d
commit
bdad477f68
12
Guideline-for-merging-PRs.md
Normal file
12
Guideline-for-merging-PRs.md
Normal file
@ -0,0 +1,12 @@
|
|||||||
|
To merge a PR, the procedure depends on the size of the PR.
|
||||||
|
|
||||||
|
* Large feature in branch
|
||||||
|
* PRs must have [branch name] prefix
|
||||||
|
* To-branch PRs can be merged quickly
|
||||||
|
* Merging a large branch = 3 maintainers
|
||||||
|
* Focused new feature
|
||||||
|
* 2 maintainers + 1 week from LGTM or 3 maintainers
|
||||||
|
* Work already agreed upon on the roadmap
|
||||||
|
* 1 (other) maintainer
|
||||||
|
* Maintenance
|
||||||
|
* "Code owner" approval or 1 week
|
Loading…
Reference in New Issue
Block a user