Zengtudor/Nuxt
1
0
Fork 0
mirror of https://github.com/nuxt/nuxt.git synced 2024-11-25 07:05:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: update fixtures to node 18 (#23122)

Browse Source
This commit is contained in:
Daniel Roe 2023-09-11 14:05:14 +01:00 committed by GitHub
parent df6a992cd6
commit 63d189a0c7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/ci.yml vendored
View File

@ -170,7 +170,7 @@ jobs:
env: ['dev', 'built'] env: ['dev', 'built']
builder: ['vite', 'webpack'] builder: ['vite', 'webpack']
context: ['async', 'default'] context: ['async', 'default']
node: [16] node: [18]
exclude: exclude:
- env: 'dev' - env: 'dev'
builder: 'webpack' builder: 'webpack'

7
test/basic.test.ts
View File

@ -751,12 +751,7 @@ describe('errors', () => {
it('should render a HTML error page', async () => { it('should render a HTML error page', async () => {
const res = await fetch('/error') const res = await fetch('/error')
// TODO: remove when we update CI to node v18 expect(res.headers.get('Set-Cookie')).toBe('set-in-plugin=true; Path=/, some-error=was%20set; Path=/')
if (process.version.startsWith('v16')) {
expect(res.headers.get('Set-Cookie')).toBe('set-in-plugin=true; Path=/')
} else {
expect(res.headers.get('Set-Cookie')).toBe('set-in-plugin=true; Path=/, some-error=was%20set; Path=/')
}
expect(await res.text()).toContain('This is a custom error') expect(await res.text()).toContain('This is a custom error')
}) })