mirror of
https://github.com/nuxt/nuxt.git
synced 2024-11-23 06:05:11 +00:00
82dab419a4
Co-authored-by: Anthony Fu <hi@antfu.me>
197 lines
12 KiB
Markdown
197 lines
12 KiB
Markdown
# Contribution
|
|
|
|
Nuxt is a community project - and so we love contributions of all kinds! ❤️
|
|
|
|
There is a range of different ways you might be able to contribute to the Nuxt ecosystem.
|
|
|
|
## Ecosystem
|
|
|
|
The Nuxt ecosystem includes many different projects and organizations. For example:
|
|
|
|
* [nuxt/](https://github.com/nuxt) - core repositories for the Nuxt framework itself. Currently [**nuxt/framework**](https://github.com/nuxt/framework) contains Nuxt 3 and [**nuxt/nuxt.js**](https://github.com/nuxt/nuxt.js) contains Nuxt 2.
|
|
* [nuxt-community/](https://github.com/nuxt-community) - community-contributed and maintained modules and libraries. There is a [process to migrate a module](/gduide/going-further/modules/#joining-nuxt-community) to `nuxt-community`. While these modules have individual maintainers, they are not dependent on a single person.
|
|
* [nuxt-contrib/](https://github.com/nuxt-contrib) - the previous home for libraries that are not specific to Nuxt but produced and used by the Nuxt team.
|
|
* [unjs/](https://github.com/unjs) - many of these libraries are used throughout the Nuxt ecosystem. They are designed to be universal libraries that are framework- and environment-agnostic. We welcome contributions and usage by other frameworks and projects.
|
|
|
|
## How to contribute
|
|
|
|
### Triage issues and help out in discussions
|
|
|
|
Check out the issues and discussions for the project you want to help. For example, here are [the issues board](https://github.com/nuxt/framework/issues) and [discussions](https://github.com/nuxt/framework/discussions) for Nuxt 3. Helping other users, sharing workarounds, creating reproductions, or even poking into a bug a little bit and sharing your findings makes a huge difference.
|
|
|
|
### Creating an issue
|
|
|
|
See [issue decision making flowchart](https://kroki.io/mermaid/svg/eNp9Uktv2kAQvudXzM32IZEK5GJFqUgIhYagqOqlx7V3bLasd1f7SIKg_72ztrFpDuVgiZ35HvPNVFK_lztmPfxcXAH95sellvSIHIRzAcFjYyTz-PVPV7--vj_9QneCh-PaAQ9GivJTeatP8Jg-Su0QmOLA3B68hqolHgizqxbxMBA-XUCMFspH0CCQjd2Rf3FcMQeNUKJhEiwaq3kovdCKnLSti4F4GZ2y0gcm5QEYFKHu7S7OdN_SDStQ5pAoRO7-IUzuCnvfiHrnoWwNigqUhmA42YI7mAJnB9ePsxxUV-mXG_iBjX5DSAwqLlQN3gpWYwIyqkXeyQ3MOYeEPF28TrtXizEoSoOVe4J19SjPTJtKITF2z7puY4W2wh-6tmy0Ewdcxwz8DqHAHXujRqCAyRTyc17rwfn39OmDViRUu4p25igz7kSXrg2BokKejego9Jw-IxrQNDFt3AIXrgzOUY6Rw_4vj-5YYhojKOlzXRH_5rjQ-GmKhu0RtuHDQ1DBxUT61W6GcV4uYKEGVlVY-vZvw353iekKgkPrLrFxmO1xbjG20vdd2z2zOig6jzhYz3eO72XQe71NzW0OwdaofDYWI-HrLDWzHERjtPXsXN6O2ElqJjns6LZHvYumlmOammkeb59ckIPsL5zkNv8).
|
|
|
|
### Send a pull request
|
|
|
|
We always welcome pull requests! ❤️
|
|
|
|
#### Before you start
|
|
|
|
Before you fix a bug, we recommend that you check whether **there's an issue that describes it**, as it's possible it's a documentation issue or that there is some context that would be helpful to know.
|
|
|
|
If you're working on a feature, then we ask that you **open a feature request issue first** to discuss with the maintainers whether the feature is desired - and the design of those features. This helps save time for both the maintainers and the contributors and means that features can be shipped faster. The issue **should be confirmed** by a framework team member before building out a feature in a pull request.
|
|
|
|
For typo fixes, it's recommended to batch multiple typo fixes into one pull request to maintain a cleaner commit history.
|
|
|
|
For bigger changes to Nuxt itself, we recommend that you first [create a Nuxt module](#create-a-module) and implement the feature there. This allows for quick proof-of-concept. You can then [create an RFC](#make-an-rfc) in the form of a discussion. As users adopt it and you gather feedback, it can then be refined and either added to Nuxt core or continue as a standalone module.
|
|
|
|
#### Commit conventions
|
|
|
|
We use [Conventional Commits](https://www.conventionalcommits.org/) for commit messages, which [allows a changelog to be auto-generated](https://github.com/unjs/changelogen) based on the commits. Please read the guide through if you aren't familiar with it already.
|
|
|
|
Note that `fix:` and `feat:` are for **actual code changes** (that might affect logic). For typo or document changes, use `docs:` or `chore:` instead:
|
|
|
|
* ~~`fix: typo`~~ -> `docs: fix typo`
|
|
|
|
If you are working in a project with a monorepo, like `nuxt/framework`, ensure that you specify the main scope of your commit in brackets. For example: `feat(nuxi): add 'do-magic' command`.
|
|
|
|
#### Making the pull request
|
|
|
|
If you don't know how to send a pull request, we recommend reading [the guide](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request).
|
|
|
|
When sending a pull request, make sure your PR's title also follows the [Commit Convention](#commit-conventions).
|
|
|
|
If your PR fixes or resolves existing issues, please make sure you mention them in the PR description.
|
|
|
|
It's ok to have multiple commits in a single PR; you don't need to rebase or force push for your changes as we will use `Squash and Merge` to squash the commits into one commit when merging.
|
|
|
|
We do not add any commit hooks to allow for quick commits. But before you make a pull request, you should ensure that any lint/test scripts are passing.
|
|
|
|
In general, please also make sure that there are no _unrelated_ changes in a PR. For example, if your editor has made any changes to whitespace or formatting elsewhere in a file that you edited, please revert these so it is more obvious what your PR changes. And please avoid including multiple unrelated features or fixes in a single PR. If it is possible to separate them, it is better to have multiple PRs to review and merge separately. In general, a PR should do _one thing only_.
|
|
|
|
#### Once you've made a pull request
|
|
|
|
Once you've made a pull request, we'll do our best to review it promptly.
|
|
|
|
If we assign it to a maintainer, then that means that person will take special care to review it and implement any changes that may be required.
|
|
|
|
If we request changes on a PR, please ignore the red text! It doesn't mean we think it's a bad PR - it's just a way of easily telling the status of a list of pull requests at a glance.
|
|
|
|
If we mark a PR as 'pending', that means we likely have another task to do in reviewing the PR - it's an internal note-to-self, and not necessarily a reflection on whether the PR is a good idea or not. We will do our best to explain via a comment the reason for the pending status.
|
|
|
|
[See PR decision making flowchart](https://kroki.io/mermaid/svg/eNqFk89vm1AMx-_9K3wrqZYcdpymRk3SdJ22qYqmVTuahwGrD0zfj6So7H-fHyTNehoHBH7G34-_NqWVg6nRBfi5uQC9bl4fawzwxG0BUsLDDtgDh-Wf6XQ-nw-rWEHJLwOsXu_TGSBc-uDYhBS-_Jy7a17QIr2QB2xB8j1L9CB7cp6rOqSUA4caWgHPBQGVJZng_1XZEoboaIB1dgUb9iZ6D-UUhJYMec-hT5WuQDFCzelGkJMPcMAeggAWhdO8Md4SFcspfUd7pgMYUeXniPatzk1RvElYzMn6Y7zrnMIDl9BL1BSyoB1LW1nVSX4lhdOXCpLEqFjMzu1sxMSG2oCBpR1gk50xLDolUKMKQGOiQ3PE-SbyBKU4kK4TF2LLgdVRbYybCchiW0WsaDafX9-PYmt9us1uDqhz4baLOhMnDTyI9DhljWmrxPSb_ABbJflFjst-aoJfwIpBa_v_mLWj58jabkiGG_SjPdh1lg3mls5J43mtpMquKdPs0PWzM8kPGeAuO005cXQS1C1G-25B0koeKT8ALarFp0lmLdEWMLasYymioWSRkmgopxp1_9yZQTdSi7gR2h93YiPk3xcIItBg25--W068d2rilyxtSue0aprctCrJ3dvJ3W0yOjtuTYp_zb6Tq04OpWgBeQ8fQbEaGU3EBhpqcv1DJp2Lvz5hNKI).
|
|
|
|
### Create a module
|
|
|
|
If you've built something with Nuxt that's cool, why not [extract it into a module](/guide/going-further/modules), so it can be shared with others? We have [many excellent modules already](https://modules.nuxtjs.org/), but there's always room for more.
|
|
|
|
If you need help while building it, feel free to [check in with us](/community/getting-help).
|
|
|
|
### Make an RFC
|
|
|
|
We highly recommend [creating a module](#create-a-module) first to test out big new features and gain community adoption.
|
|
|
|
If you have done this already, or it's not appropriate to create a new module, then please start by creating a new discussion. Make sure it explains your thinking as clearly as possible. Include code examples or function signatures for new APIs. Reference existing issues or pain points with examples.
|
|
|
|
If we think this should be an RFC, we'll change the category to RFC and broadcast it more widely for feedback.
|
|
|
|
An RFC will then move through the following stages:
|
|
|
|
* `rfc: active` - currently open for comment
|
|
* `rfc: approved` - approved by the Nuxt team
|
|
* `rfc: ready to implement` - an issue has been created and assigned to implement
|
|
* `rfc: shipped` - implemented
|
|
* `rfc: archived` - not approved, but archived for future reference
|
|
|
|
### Conventions across ecosystem
|
|
|
|
The following conventions are _required_ within the `nuxt/` organization and recommended for other maintainers in the ecosystem.
|
|
|
|
#### Module conventions
|
|
|
|
Modules should follow the [Nuxt module template](https://github.com/nuxt/starter/tree/module). See [module guide](/guide/going-further/modules) for more information.
|
|
|
|
#### Use core `unjs/` libraries
|
|
|
|
We recommend the following libraries which are used throughout the ecosystem:
|
|
|
|
* [pathe](https://github.com/unjs/pathe) - universal path utilities (replacement for node `path`)
|
|
* [ufo](https://github.com/unjs/ufo) - URL parsing and joining utilities
|
|
* [unbuild](https://github.com/unjs/unbuild) - rollup-powered build system
|
|
* ... check out the rest of the [unjs/](https://github.com/unjs) organization for many more!
|
|
|
|
#### Use ESM syntax and default to `type: module`
|
|
|
|
Most of the Nuxt ecosystem can consume ESM directly. In general we advocate that you avoid using CJS-specific code, such as `__dirname` and `require` statements. You can [read more about ESM](/concepts/esm).
|
|
|
|
#### What's Corepack
|
|
|
|
[Corepack](https://nodejs.org/api/corepack.html) makes sure you are using the correct version for package manager when you run corresponding commands. Projects might have `packageManager` field in their `package.json`.
|
|
|
|
Under projects with configuration as shown below, corepack will install `v7.5.0` of `pnpm` (if you don't have it already) and use it to run your commands.
|
|
|
|
```jsonc [package.json]
|
|
{
|
|
"packageManager": "pnpm@7.5.0"
|
|
}
|
|
```
|
|
|
|
#### Use ESLint
|
|
|
|
We use [ESLint](https://eslint.org/) for both linting and formatting with [`@nuxt/eslint-config`](https://github.com/nuxt/eslint-config).
|
|
|
|
##### IDE Setup
|
|
|
|
We recommend using [VS Code](https://code.visualstudio.com/) along with the [ESLint extension](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint). If you would like, you can enable auto-fix and formatting when you save the code you are editing:
|
|
|
|
```json [settings.json]
|
|
{
|
|
"editor.codeActionsOnSave": {
|
|
"source.fixAll": false,
|
|
"source.fixAll.eslint": true
|
|
}
|
|
}
|
|
```
|
|
|
|
#### No Prettier
|
|
|
|
Since ESLint is already configured to format the code, there is no need to duplicate the functionality with Prettier. To format the code, you can run `yarn lint --fix` or `pnpm lint --fix` or referring the [ESLint section](#use-eslint) for IDE Setup.
|
|
|
|
If you have Prettier installed in your editor, we recommend you disable it when working on the project to avoid conflict.
|
|
|
|
**Note**: [we are discussing](https://github.com/nuxt/eslint-config/issues/224) enabling prettier in future.
|
|
|
|
#### Package manager
|
|
|
|
For libraries, we recommend `pnpm`. For modules, we still recommend `yarn` but we may well switch this recommendation to `pnpm` in future once we support plug and play mode with Nuxt itself.
|
|
|
|
It is important to enable corepack to ensure you are on the same version of the package manager as the project. Corepack is built-in to new node versions for seamless package manager integration.
|
|
|
|
To enable it, run
|
|
|
|
```bash
|
|
corepack enable
|
|
```
|
|
|
|
You only need to do this one time, after Node.js is installed on your computer.
|
|
|
|
## Writing documentation
|
|
|
|
Documentation is an essential part of Nuxt. We aim to be an intuitive framework - and a big part of that is making sure that both the developer experience and the docs are perfect across the ecosystem. 👌
|
|
|
|
Here are some tips that may help improve your documentation:
|
|
|
|
* Avoid subjective words like _simply_, _just_, _obviously..._ when possible.
|
|
|
|
Keep in mind your readers can have different backgrounds and experiences. Therefore, these words don't convey meaning and can be harmful.
|
|
|
|
::alert{icon=❌}
|
|
**Avoid:** "Simply make sure the function returns a promise."
|
|
::
|
|
|
|
::alert{icon=✅}
|
|
**Prefer:** "Make sure the function returns a [promise](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise)."
|
|
::
|
|
|
|
* Prefer [active voice](https://developers.google.com/tech-writing/one/active-voice).
|
|
|
|
::alert{icon=❌}
|
|
**Avoid:** "An error will be thrown by Nuxt."
|
|
::
|
|
|
|
::alert{icon=✅}
|
|
**Prefer:** "Nuxt will throw an error."
|
|
::
|