Commit Graph

60 Commits

Author SHA1 Message Date
Sam McCall
19a7bfdb2d Oops, fix path to OpenMP headers. 2022-01-03 18:30:19 +01:00
Sam McCall
9d058532be Include omp{,-tools}.h in the releases
This is really ugly, but AFAICT:
 - omp.h is not a "builtin clang header" in the usual sense, but when
   openmp is built it installs to clang's resource dir to be "always
   available"
 - this makes it into clang packages, e.g. debian's libclang-common-11-dev.
 - as a result, if we don't ship it, then <omp.h> can be found by system
   clang but not by us.
2022-01-03 18:30:19 +01:00
Kirill Bobyrev
ca00967a89
Link to GitHub Discussions when opening an issue (#975)
That will increase the visibility of the Discussions mechanism.
2022-01-03 17:59:22 +01:00
Kadir Cetinkaya
1a5759b2da Explicitly set OSX_DEPLOYMENT_TARGET in cmake flags, as
matrix.config.env is not propagated into job's env variables.
2021-11-04 11:37:08 +01:00
Kirill Bobyrev
c0845399c6
Merge periodic workflow into autobuild (#786)
The only reason to have a separate periodic action was the ability to
run the action "manually" by creating an appropriate release. With the
workflow_dispatch, we can actually trigger the workflow manually with
a convenient UI. Hence, periodic is no longer needed.
2021-08-04 16:04:55 +03:00
Kirill Bobyrev
c576bf40d1
NFC: Improve Bug Report issue template
Since this is a Markdown file, line breaks are needed for proper formatting. Otherwise, Preview joins lines that were not supposed to be together.
2021-07-29 14:26:58 +03:00
Kadir Cetinkaya
e2345b0261 Build fat binaries for mac 2021-07-09 10:12:57 +02:00
Kirill Bobyrev
186c1cfe5b
Bump gRPC version: 1.33.2 -> 1.36.3 (#783)
Builds started to fail
(https://github.com/clangd/clangd/runs/2595990099?check_suite_focus=true)
because Abseil source file (built as a part of gRPC) was using
`std::numeric_limits` and `uint32_t` but not including `<limits>` and
`<cstdint>` directly
(df3ea785d8/absl/synchronization/internal/graphcycles.cc).

This worked with libstdc++ 10 but GitHub Actions recently updated the
toolchain for Ubuntu 18.04 LTS we're using
(0409144182 (diff-8d528b68ca937dfe5a0194829f0eb2633bc3d7a3105a637ccb534a4da765f7a3R17)).
libstdc++ 11 changed the standard headers and is now less forgiving when
it comes to `<limits>` and few other headers not being included directly
(https://gcc.gnu.org/gcc-11/porting_to.html#:~:text=%3Climits%3E%20%28for%20std%3A%3Anumeric_limits%29).

This patch increases the gRPC version we use to fix the CI. Another
viable solution is "downgrading" back to libstdc++10 (e.g. via `sudo
apt-get remove -y libgcc-11-dev`).

This also requires changes in
https://github.com/llvm/llvm-zorg/blob/master/buildbot/google/docker/buildbot-clangd-ubuntu-clang/Dockerfile
for consistency.
2021-06-07 15:30:56 +03:00
Kirill Bobyrev
c4786ebf83 Revert "Downgrade to libgcc10"
This reverts commit 608aa9953c in favor of
https://github.com/clangd/clangd/pull/783
2021-06-07 14:29:21 +02:00
Kadir Cetinkaya
608aa9953c Downgrade to libgcc10
gRPC version we use cannot be compiled with libstdc++ that comes with
gcc11 due to a change in transitive dependencies.

This is a temporary fix until we bump the grpc version in a bunch of
deployments.
2021-05-21 11:44:15 +02:00
Kadir Cetinkaya
d78d99d3f3 Package index-server-monitor in indexing-tools 2021-05-04 13:06:09 +02:00
Sam McCall
ec24d11c53 Rename clangd-indexing-tools-platform-version.zip -> clangd_indexing_tools-platform-version.zip
This allows autoupdate to work in our buggy clients.
See https://github.com/clangd/vscode-clangd/issues/180

Stylistic justification: "clangd_indexing_tools" is one "word" in the
"name-platform-version.zip" naming convention.
2021-04-22 12:17:05 +02:00
Kirill Bobyrev
d36dadfd99
Fix the typo (gthub -> github) 2021-04-21 18:42:27 +02:00
Kirill Bobyrev
fc7440e2e5
Allow using a different repository for the manual release (#754)
Extract the repository from the release message. This will help us have
more control over the release process.
2021-04-21 19:37:50 +03:00
Sam McCall
d561d317fc Script to generate compile_commands.json from compile_flags.txt
This enables background index for a compile_flags.txt driven project.
(We should really have a better solution for this)
2021-03-05 23:10:38 +01:00
Kadir Cetinkaya
411063a83a Use ubuntu-18 for older glibc
There's pthread_cond_clockwait@GLIBC_2.30 introduced with new glibc,
which isn't available in older versions. To prevent such breakages we
are sticking to ubuntu-18 rather than moving to ubuntu-20.

For a sample error see
https://github.com/kadircet/clangd/runs/2011039246?check_suite_focus=true.

Version label grabbed from
https://github.com/actions/virtual-environments.
2021-03-02 15:02:21 +01:00
Kadir Cetinkaya
239800b0c5
Trim trailing newlines for non-linux too 2021-03-02 08:34:05 +01:00
Kadir Cetinkaya
e279de4b94
Trim trailing newlines from cmake args 2021-03-02 08:24:46 +01:00
Kirill Bobyrev
fead93d1a9
Fix YAML syntax
Additional newline is created for CMake arguments.
2021-03-02 07:05:24 +01:00
Kirill Bobyrev
fc26be2c43
Fix the build after 40114796f0
That patch added new flags but gRPC is still built with GNU C++
compiler. If we're trying to build both gRPC and LLVM with the same set
of flags, we should enforce additional CMake flags for gRPC.
2021-03-02 06:58:25 +01:00
Kadir Cetinkaya
3d90b39e96
Get rid of stale fixme 2021-02-26 14:55:06 +01:00
Kadir Cetinkaya
40114796f0 Include lib_compat.h while building gRPC
While building clangd binaries we set required glibc version for symbols
to a minimum to cover systems with older glibc implementations. But we
were not doing that while building gRPC, which might depend on never
versions of these symbols.
2021-02-26 12:50:28 +01:00
Kirill Bobyrev
bef10dc3c8
Do not upload in autobuild job (#563)
Artifacts are used to pass data from one job to another but we upload
release assets in the same job we build them, hence artifacts are
redundant.
2021-02-17 12:53:11 +03:00
Kadir Cetinkaya
835256346b Use LLVM head for builds
clangd/actions/pick is currently broken because LLVM no longer has a
branch called master. We didn't have any releases for past 3 weeks, i've
contacted author in
https://github.com/ramasilveyra/last-successful-gh-commit/issues/2.
2021-02-16 16:16:17 +01:00
HO-COOH
405dee024a
fix clangd source link (#688) 2021-02-09 18:12:52 +03:00
Kirill Bobyrev
ebde6ecac4
Expand path to grpc-installation directory
Weekly snapshot builds are failing because CMake couldn't find gRPC and
Protobuf libraries. Expanding the path from relative to the full one
solves the problem.

Fixes: https://github.com/clangd/clangd/issues/641
2021-01-13 12:11:12 +01:00
Sam McCall
ae38d57cb9 Remove obsolete compiler hack from windows build config.
MSVC version is now 16.7+, see
https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md
2020-11-29 12:27:07 +01:00
Kirill Bobyrev
94b525b2ee
Bump gRPC version to 1.33.2 (#592)
* Bump gRPC version to 1.33.2

This is the same version we are using in our buildbot, so this will
surely be the "stable" version for us right now.
2020-11-17 18:02:12 +03:00
Kadir Cetinkaya
a276cdf62f Change escaping of double quotes to single quote
Release names contains quotes around commit hashes due to the escaping.
After this patch, they'll be gone.
2020-10-26 11:33:24 +01:00
Kirill Bobyrev
02bad4f0eb
Bundle headers in indexing-tools release archive (#570) 2020-10-23 17:00:11 +02:00
Kirill Bobyrev
8d1f3300c5
Enable gRPC support for macOS and Windows (#565) 2020-10-18 13:58:12 +02:00
Kirill Bobyrev
6f906275b0
Add clangd-index-server to release asset 2020-10-18 11:30:15 +02:00
Kirill Bobyrev
6ab953a853
Build clangd-indexer and upload an asset with it next to clangd.zip (#560) 2020-10-16 17:04:12 +02:00
Kirill Bobyrev
f34af43022
Enable gRPC support for clangd on Linux (#561)
This patch introduces remote index support for binaries built on Linux. Other platforms will be added soon.
2020-10-16 17:03:34 +02:00
Kirill Bobyrev
f779426513
Remove deprecated set-env command (#553)
Remove deprecated set-env command

Environment files are to be used instead now:

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
2020-10-15 11:36:18 +02:00
Kirill Bobyrev
5a40c019f1
Pull "pick" action into clangd/actions (#552) 2020-10-06 10:40:21 +02:00
dependabot[bot]
d1d8b39c4c Bump @actions/core from 1.2.2 to 1.2.6 in /.github/actions/pick
Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.2.2 to 1.2.6.
- [Release notes](https://github.com/actions/toolkit/releases)
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core)

Signed-off-by: dependabot[bot] <support@github.com>
2020-10-02 12:43:09 +02:00
Sam McCall
45b6fbdfb0 Try to fix static libz on linux 2020-09-24 16:33:20 +02:00
Haojian Wu
40dcef1871 Set MACOSX_DEPLOYMENT_TARGET flag.
Make sure we support older version of macOS (10.9+) when building clangd with
the latest macOS (10.15).
2020-09-14 12:36:51 +02:00
Sam McCall
9a0cad43e8 Issue template for cherrypicks 2020-06-10 05:16:38 +02:00
Sam McCall
55b106258d
Compat with older python 2020-05-08 00:01:38 +02:00
Sam McCall
61703d6bba
Fix typo 2020-05-07 19:57:36 +02:00
Sam McCall
b51dc0092f
Test that linux binary depends on glibc 2.18 and no other dynamic symbols (#372)
This regressed twice over the last two months (new floating point
function versions, and accidental dynamic linking against zlib).
We also want to avoid regressions when merging remote index.

The test is able to do a little bit more than we use in the automated
build (the --sym flag is unused, as is unversioned --lib=GLIBC) but they're
pretty useful when experimenting with how to fix things!

We run the test right at the end, because if it fails we want to be able
to download the binary artifact and inspect it.
Unfortunately by the nature of the test we can only run it when we
produce a build, so currently weekly.
2020-05-07 15:50:12 +02:00
Sam McCall
2de2ec4404 Link against older, more-compatible versiosn of glibc symbols.
They're binary-compatible, the old versions are more widely available
and the new versions are more highly optimized. We prefer the former.
2020-05-07 15:19:22 +02:00
Sam McCall
12c31b0756 Extract cflags to variable to avoid duplication. NFC 2020-05-07 15:19:22 +02:00
Sam McCall
722567248f
Fix static linking of zlib. (#370)
Fix static linking of zlib.

Use of the standard FindZLIB and thus support for ZLIB_LIBRARIES was
removed upstream in llvm/llvm-project@916be8fd6a
2020-05-07 12:44:29 +02:00
Sam McCall
d740d020b6 [logo] media cards with subtitles for vscode-clangd etc repositories 2020-04-22 13:30:04 +02:00
Sam McCall
45de907b37 Also create SVG logo 2020-04-21 12:45:07 +02:00
Sam McCall
adc3c29c7f Add logo. Programmer art! 2020-04-21 12:36:33 +02:00
Sam McCall
efb0a8fab5 Add LLVM license in preparation for adding logo 2020-04-21 12:35:42 +02:00