Zengtudor/glew-cmake
1
0
Fork 0
mirror of https://github.com/Perlmint/glew-cmake.git synced 2025-04-03 23:42:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update CMakeLists.txt

Browse Source 
Currently (well, at least on Windows), the created DLL files aren't installed in the correct output directory after a build. The dll files are installed in the 'lib' directory. Which actually is the place for the static library or the shared library's symbols file (.lib), not the actual shared library's runtime.
The shared library runtimes should be installed to the 'bin' output directory, as proposed in this PR.

See the ```CONFIGURATIONS``` option in [Install command introduction in the CMake manual](https://cmake.org/cmake/help/v3.14/command/install.html#introduction).

This also follows convention as used in other notable libraries as libpng, libogg/vorbis, freetype, zlib, tinyxml, etc.
This commit is contained in:
GekkieHenkie 2019-04-09 19:49:57 +02:00 committed by GitHub
parent 1fd6e0ba45
commit 6b50d6c09a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CMakeLists.txt
View File

@ -76,7 +76,6 @@ IF ( glew-cmake_BUILD_SHARED )
TARGET_INCLUDE_DIRECTORIES( libglew_shared PUBLIC ${INCLUDE_DIR} )
TARGET_LINK_LIBRARIES( libglew_shared ${GL_LIBRARY} ${PLATFORM_SPECIFIC_LIBRARIES} )
INSTALL( TARGETS libglew_shared DESTINATION lib )
INSTALL( TARGETS libglew_shared RUNTIME DESTINATION bin )
ENDIF ( )
@ -91,7 +90,6 @@ IF ( glew-cmake_BUILD_SHARED )
TARGET_COMPILE_DEFINITIONS( libglewmx_shared INTERFACE GLEW_MX)
TARGET_INCLUDE_DIRECTORIES( libglewmx_shared PUBLIC ${INCLUDE_DIR} )
TARGET_LINK_LIBRARIES( libglewmx_shared ${GL_LIBRARY} ${PLATFORM_SPECIFIC_LIBRARIES} )
INSTALL( TARGETS libglewmx_shared DESTINATION lib )
INSTALL( TARGETS libglewmx_shared RUNTIME DESTINATION bin )
ENDIF ( )
ENDIF ( )