caaa7b5131
Changing std::shared_ptr pointer/reference to const pointer/reference. New stats for all tests combined: 4 failed, 466 passed.
2021-02-09 09:01:13 -08:00
c6620cef90
Adding "Lazy allocation for unallocated values" (for old-style __init__) into load_value_and_holder. Deferring destruction of disowned holder until clear_instance, to remain inspectable for "uninitialized" or "disowned" detection. New stats for all tests combined: 5 failed, 465 passed.
2021-02-09 06:47:46 -08:00
233eb9e6a8
Adding unowned_void_ptr_from_direct_conversion to modified_type_caster_generic_load_impl. This fixes the last remaining segfault (test_numpy_dtypes). New stats for all tests combined: 12 failed, 458 passed.
2021-02-09 06:47:46 -08:00
0de26c411a
Bug fix: Adding have_value() to smart_holder_type_caster_load. With this test_builtin_casters succeeds. (All 42 tests build, 36 tests succeed, 5 run but have some failures, 1 segfault.)
2021-02-09 06:47:46 -08:00
3cc0a8a598
Introducing check_is_smart_holder_type_caster() function for runtime check, and reinterpreting record.default_holder as "uses_unique_ptr_holder". With this test_smart_ptr succeeds. (All 42 tests build, 35 tests succeed, 5 run but have some failures, 2 segfault.)
2021-02-09 06:47:46 -08:00
357266db8d
Adding remaining PYBIND11_SMART_POINTER_HOLDER_TYPE_CASTERS. static_assert for "necessary conditions" for both types of default holder, static_assert for "strict conditions" guarded by new PYBIND11_STRICT_ASSERTS_CLASS_HOLDER_VS_TYPE_CASTER_MIX. All tests build & run as before with unique_ptr as the default holder, all tests build for smart_holder as the default holder, even with the strict static_assert.
2021-02-09 06:47:46 -08:00
093e0f4514
Adding PYBIND11_SMART_POINTER_HOLDER_TYPE_CASTERS in test_class.cpp (with this all but one test succeed with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT).
2021-02-09 06:47:45 -08:00
bfe36cc7df
Softening static_assert, to only check specifically that smart_holder is not mixed with type_caster_base, and unique_ptr/shared_ptr holders are not mixed with smart_holder_type_casters.
2021-02-09 06:47:45 -08:00
97e41de4e2
Replacing condense_for_macro with much simpler approach.
2021-02-09 06:47:45 -08:00
1dcf115b22
Using __VA_ARGS__ in PYBIND11_SMART_POINTER_HOLDER_TYPE_CASTERS.
2021-02-09 06:47:45 -08:00
75f7eca26e
Introducing 1. type_caster_for_class_, used in PYBIND11_MAKE_OPAQUE, and 2. default_holder_type, used in stl_bind.h.
2021-02-09 06:47:45 -08:00
99e9595a9c
Introducing PYBIND11_SMART_POINTER_HOLDER_TYPE_CASTERS. Using it in test_smart_ptr.cpp. With this test_smart_ptr builds with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT and all but one test run successfully.
2021-02-09 06:47:45 -08:00
1a0c65f753
Simplifying from_unique_ptr(): typename D = std::default_delete<T> is not needed. Factoring out is_std_default_delete<T>() for consistentcy between ensure_compatible_rtti_uqp_del() and from_unique_ptr().
2021-02-09 06:47:45 -08:00
9c95dc4d8f
Factoring out struct and class definitions into anonymous namespace. Preparation for building with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT.
2021-02-09 06:47:45 -08:00
3134dfe779
Disabling shared_ptr&, shared_ptr* tests when building with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT for now, pending work on smart_holder_type_caster<shared_ptr>.
2021-02-09 06:47:45 -08:00
70eb4ea6e9
Adding enable_if !is_smart_holder_type_caster to existing initimpl::construct(). With this test_factory_constructors.cpp builds with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT.
2021-02-09 06:47:45 -08:00
8caf0f50df
Adding initimpl::construct() overloads, resulting in test_class_sh_factory_constructors feature parity for py::class_ and py::classh.
2021-02-09 06:47:45 -08:00
b69b4a9f55
Converting as many py::class_ to py::classh as possible, not breaking tests.
2021-02-09 06:47:45 -08:00
0228080a86
Adding // DANGER ZONE reminders.
2021-02-09 06:47:45 -08:00
1e4f0fdcaf
Removing include/pybind11/detail/smart_holder_type_casters.h from CMakeLists.txt, test_files.py (since it does not exist in this branch).
2021-02-09 06:47:45 -08:00
3f5a9c9bf4
Adding test_class_sh_factory_constructors, reproducing test_factory_constructors failure. Using py::class_ in this commit, to be changed to py::classh for debugging.
2021-02-09 06:47:45 -08:00
6349531306
Commenting out const in def_buffer(... const). With this, test_buffers builds and runs with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT. Explanation why the const needs to be removed, or fix elsewhere, is still needed, but left for later.
2021-02-09 06:47:45 -08:00
63abf87244
Removing detail/smart_holder_type_casters.h in separate commit.
2021-02-09 06:47:45 -08:00
c8eb29c8f5
Fixing up cast.h and smart_holder.h after rebase.
2021-02-09 06:47:45 -08:00
b9eb2a46c4
Setting record.default_holder correctly for PYBIND11_USE_SMART_HOLDER_AS_DEFAULT.
...
With this test_class.cpp builds and even mostly runs, except
`test_multiple_instances_with_same_pointer`, which segfaults because it is
using a `unique_ptr` holder but `smart_holder` `type_caster`.
Also adding `static_assert`s to generate build errors for such situations,
but guarding with `#if 0` to first pivot to test_factory_constructors.cpp.
2021-02-09 06:47:44 -08:00
f373e3d619
Fixing oversight introduced with commit 95425f13d6.
2021-02-09 06:47:44 -08:00
b69f9fed33
Removing test_type_caster_bare_interface, which was moved to the separate PR #2834 .
2021-02-09 06:47:44 -08:00
ce79f9126d
Introducing PYBIND11_USE_SMART_HOLDER_AS_DEFAULT macro (tested only undefined; there are many errors with the macro defined).
2021-02-09 06:47:44 -08:00
0f316720f7
Adding comment, simplifying naming, cmake addition.
2021-02-09 06:47:44 -08:00
0dfd3a6b7d
Copying files as-is from branch test_unique_ptr_member (PR #2672 ).
2021-02-09 06:47:44 -08:00
72f52be256
Unification of unique_ptr, unique_ptr_with_deleter code in smart_holder_poc.h. Leads to more fitting error messages. Enables use of unique_ptr<T, D> smart_holder_type_casters also for unique_ptr<T>.
2021-02-09 06:47:08 -08:00
a9bfcbdcc3
Adding smart_holder_type_casters for unique_ptr with custom deleter. SEVERE CODE DUPLICATION. This commit is to establish a baseline for consolidating the unique_ptr code.
2021-02-09 06:47:08 -08:00
231bd84fa0
Moving up is_smart_holder_type_caster, to also use in cast_is_temporary_value_reference.
2021-02-09 06:47:08 -08:00
692270a017
Removing test_type_caster_bare_interface, which was moved to the separate PR #2834 .
2021-02-09 06:47:08 -08:00
c9d73aaa43
Giving up on idea to use legacy init_instance only if is_base_of<type_caster_generic, type_caster<T>. There are use cases in the wild that define both a custom type_caster and class_.
2021-02-09 06:47:08 -08:00
149e332b3e
Adding classu alias for class_<U, std::unique_ptr<U>>.
2021-02-09 06:47:08 -08:00
1e4c2e04ae
Fixing oversight.
2021-02-09 06:47:08 -08:00
742bc0eaf7
Replacing detail::is_smart_holder<H> in cast.h with detail::is_smart_holder_type_caster<T>.
...
Moving get_local_load_function_ptr, init_instance_for_type to smart_holder_type_caster_class_hooks.
Expanding static_assert in py::type::handle_of<> to accommodate smart_holder_type_casters.
2021-02-09 06:47:08 -08:00
87acc89b21
Reintroducing py::classh, this time as a simple alias for py::class_<U, py::smart_holder>.
2021-02-09 06:47:08 -08:00
4a4087fdd5
Moving define PYBIND11_SMART_HOLDER_TYPE_CASTERS(T) down in the file. NO functional changes. Preparation for follow-up work (to keep that diff smaller).
2021-02-09 06:47:08 -08:00
d5b591d7f8
Making use of the new find_existing_python_instance() function factored out with PR #2822 .
2021-02-09 06:47:08 -08:00
c749d9b7fc
Adding tests/pure_cpp/CMakeLists.txt.
2021-02-09 06:47:08 -08:00
d91f2190ee
Adding new header files to tests/extra_python_package/test_files.py.
2021-02-09 06:47:08 -08:00
9077bcd1fc
Explicitly define copy/move constructors/assignments.
2021-02-09 06:47:08 -08:00
63fe989148
Adding copyright notices to new header files.
2021-02-09 06:47:08 -08:00
a15797d50e
CMake COMPARE NATURAL is not available with older versions.
2021-02-09 06:47:08 -08:00
94eeb34b01
Reusing type_caster_base make_copy_constructor, make_move_constructor with a trick.
2021-02-09 06:47:08 -08:00
56a71520b5
32-bit compatibility.
2021-02-09 06:47:08 -08:00
eac5b49fe1
clang-tidy fixes.
2021-02-09 06:47:08 -08:00
f19e80881c
Changing CMake file so that test_class_sh_module_local.py actually runs.
2021-02-09 06:47:07 -08:00
Ralf W. Grosse-Kunstleve